Commit graph

5682 commits

Author SHA1 Message Date
Mislav Marohnić
7387346196 Fix determining the current executable under Homebrew for Linux
We need to use `os.Lstat` instead of `os.Stat` if we are going to
manually inspect files for whether they are a symlink. On macOS, it
looks like `os.Stat` returns information about the symlink itself.
2022-06-20 15:25:29 +02:00
Caleb Brose
2e6f202031
Merge pull request #5752 from jungaretti/jungaretti/no-ssh-keys 2022-06-14 17:33:07 -05:00
Caleb Brose
be773a12d4 Create .ssh dir if not exists 2022-06-14 12:30:04 -05:00
Caleb Brose
83153fe9e5 Cleanups from PR comments 2022-06-14 14:33:41 +00:00
Jonathan Fenwick
ddb408e67b
Add check to see if current owner is attempting to fork the repo (#5794)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-06-14 13:13:24 +00:00
Spenser Black
5771fcb35e
Print auth help message based on environment (#5781)
This will check if `gh` is running in a CI environment. If so, it will
suggest using environment variables to set the auth token. Additionally,
if the CI environment is detected to be GitHub Actions, it will provide
some example code. If it is not a CI environment, it will print the
standard help message.

Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-06-14 12:27:11 +00:00
Caleb Brose
9f6e1c774b Check for key already exists 2022-06-13 19:31:44 +00:00
Caleb Brose
919dcebc45 Rename Context 2022-06-13 19:16:16 +00:00
Caleb Brose
b5580f9503 Refactor inferfaces from PR comments 2022-06-13 19:04:29 +00:00
cmbrose
ec58990715 Typo 2022-06-10 12:38:10 -05:00
cmbrose
e16a8adb6f Invert boolean 2022-06-10 11:14:19 -05:00
Mislav Marohnić
4c237708d8
Merge pull request #5779 from cli/merge-queue-api-fix
pr merge: fix merge queue API access for PAT consumers
2022-06-09 14:51:56 +02:00
Mislav Marohnić
9351f272dc pr merge: fix merge queue API access for PAT consumers
The github.com API right now doesn't seem to make merge queue APIs
available to people who use PAT to authenticate gh requests. This
switches the conditional request strategy to also do feature-detection
for dotcom (instead of just for Enterprise).
2022-06-09 14:38:58 +02:00
Sam Coe
743a747804
Use go-gh for SSH hostname alias translation (#5654) 2022-06-08 21:32:29 +00:00
Sam Coe
39dd3e66e8
Use go-gh repository.ParseWithHost (#5655) 2022-06-08 21:21:59 +00:00
Mislav Marohnić
4b488a7f6a
Merge pull request #5762 from cli/codespace-start-progress
Clean up progress indicator if codespace fails to start
2022-06-08 17:48:57 +02:00
dependabot[bot]
448b13864a
Bump github.com/AlecAivazis/survey/v2 from 2.3.4 to 2.3.5 (#5775)
Bumps [github.com/AlecAivazis/survey/v2](https://github.com/AlecAivazis/survey) from 2.3.4 to 2.3.5.
- [Release notes](https://github.com/AlecAivazis/survey/releases)
- [Commits](https://github.com/AlecAivazis/survey/compare/v2.3.4...v2.3.5)

---
updated-dependencies:
- dependency-name: github.com/AlecAivazis/survey/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-08 14:29:04 +00:00
Mislav Marohnić
da9203c751
Merge pull request #5596 from cli/mntlty/merge_queue
merge queue support for pr merge
2022-06-08 12:33:30 +02:00
Mislav Marohnić
4c6358dcbf Guard PR merge queue queries behind feature detection 2022-06-08 12:25:22 +02:00
Ariel Deitcher
53a8737c87 pr merge: add support for Merge Queue
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-06-08 12:24:36 +02:00
Mislav Marohnić
887578a640
Merge pull request #5764 from cli/fix-repo-list
Allow repo list to work with GHES earlier than 3.3
2022-06-08 12:13:29 +02:00
cmbrose
2c5532116d Restore empty flag 2022-06-07 12:38:01 -05:00
cmbrose
eebef06c67 Merge main and use func options again 2022-06-07 12:27:29 -05:00
cmbrose
9095556372 Merge remote-tracking branch 'upstream/trunk' into jungaretti/no-ssh-keys 2022-06-07 12:07:03 -05:00
cmbrose
60032db5eb Use function options pattern 2022-06-07 11:04:08 -05:00
Mislav Marohnić
f184d7ec58 pr create: allow forking repositories with INTERNAL visibility
The IsPrivate field of "internal" repositories is always true, but those
repositories aren't truly private and absolutely can be forked. We
shouldn't be checking for platform permissions in the client anyway, so
let's just drop this check and have the platform decide whether this is
a valid operation.
2022-06-07 17:56:06 +02:00
Mislav Marohnić
80f130184c repo edit: fix interactive mode in GHES < 3.3 2022-06-07 17:54:52 +02:00
Mislav Marohnić
aff26cbcfc Simplify repo list color check 2022-06-07 17:51:44 +02:00
Jonathan Fenwick
2abe1b3294
Remove auth logout confirmation prompt (#5751) 2022-06-07 15:26:53 +00:00
Mislav Marohnić
89886eeaf8 Fix repo visibility label in search repos output
The `Visibility` field will be empty for `search` results when made
against GHES versions < 3.3. If that is the case, fall back to
constructing the label using `IsPrivate` field.
2022-06-07 17:09:17 +02:00
Sam Coe
33975a95e4
Allow repo list to work with GHES earlier than 3.3 2022-06-06 12:45:55 -05:00
Mislav Marohnić
be9fed4e8e
Merge pull request #5763 from cli/dependabot/go_modules/github.com/stretchr/testify-1.7.2
Bump github.com/stretchr/testify from 1.7.1 to 1.7.2
2022-06-06 16:36:29 +02:00
dependabot[bot]
b5915a890a
Bump github.com/stretchr/testify from 1.7.1 to 1.7.2
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.1 to 1.7.2.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](https://github.com/stretchr/testify/compare/v1.7.1...v1.7.2)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-06-06 14:24:34 +00:00
Greggory Rothmeier
f15a8ca335
Extract LiveshareSession interface (#5725)
This will make it possible to inject a mock liveshare session for testing
2022-06-06 15:52:52 +02:00
Mislav Marohnić
8c5ae36311 Clean up progress indicator if codespace fails to start 2022-06-06 14:32:01 +02:00
cmbrose
8e8632ddab Prepend flag for scp support 2022-06-03 14:24:15 -05:00
cmbrose
2209a84c9d More cleanup 2022-06-03 14:07:41 -05:00
cmbrose
ce3a1323ed Remove TODOs 2022-06-03 14:05:24 -05:00
cmbrose
2310795b3f Actually check err 2022-06-03 13:53:16 -05:00
cmbrose
f67ca53c07 Refactor ssh_keys to a more common location 2022-06-03 13:39:52 -05:00
Jeff Hubbard
866eccc202
Merge pull request #5705 from 8Gitbrix/users/ajeyaseelan/fix-edit-cmd
codespace edit: interactively choose a codespace
2022-06-03 10:04:31 -07:00
Fengyi Li
04ed77ddf0
Update prebuild availability status display at codespace creation (#5737) 2022-06-02 17:20:12 +00:00
Mislav Marohnić
afb69d2d31 cs edit: 💅 implementation and tests 2022-06-01 17:18:17 +02:00
Mislav Marohnić
7d71f807c4
Merge pull request #5744 from cli/dependabot/go_modules/github.com/itchyny/gojq-0.12.8
Bump github.com/itchyny/gojq from 0.12.7 to 0.12.8

Closes #5731
2022-06-01 16:48:36 +02:00
dependabot[bot]
90602244d8
Bump github.com/itchyny/gojq from 0.12.7 to 0.12.8
Bumps [github.com/itchyny/gojq](https://github.com/itchyny/gojq) from 0.12.7 to 0.12.8.
- [Release notes](https://github.com/itchyny/gojq/releases)
- [Changelog](https://github.com/itchyny/gojq/blob/main/CHANGELOG.md)
- [Commits](https://github.com/itchyny/gojq/compare/v0.12.7...v0.12.8)

---
updated-dependencies:
- dependency-name: github.com/itchyny/gojq
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-06-01 14:38:17 +00:00
JP Ungaretti
a1629c70c0 Generate codespaces key 2022-05-31 17:19:16 -07:00
cmbrose
ac630880c6 Refactor to WithOptions 2022-05-31 15:52:16 -05:00
Mislav Marohnić
76a21a4792
Merge pull request #5719 from guerinoni/fix-quote-path
Quote path of repo in order to have a valid copy paste command
2022-05-30 17:26:30 +02:00
JP Ungaretti
83a9b87397 Fix errors 2022-05-26 21:49:59 +00:00
JP Ungaretti
76090a2ea7 Add key to RPC call 2022-05-26 21:45:20 +00:00