STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
5624 commits 87 branches 0 tags 160 MiB
Commit graph

46 commits

Author SHA1 Message Date
JP Ungaretti
f21faca03e Resolve feedback 2022-04-21 14:56:55 -07:00
JP Ungaretti
e8e9b58670 Clean up errors 2022-04-14 16:12:44 -05:00
JP Ungaretti
eaf8f84baf Merge branch 'trunk' into add-cs-jupyter 2022-04-14 15:27:40 -05:00
JP Ungaretti
33a1b95dbf Fix name of RPC service 2022-04-14 14:55:29 -05:00
Jose Garcia
b5a7a36ece Document why we have a loop retrying 2022-03-21 12:11:00 -04:00
Jose Garcia
cd6176d911 Rename to tries and clean up loop condition 2022-03-21 11:42:32 -04:00
Jose Garcia
74c8b2217e Increment retries 2022-03-21 11:36:12 -04:00
Jose Garcia
107ea6c440 Only sleep if conn is nil 2022-03-21 11:09:52 -04:00
Bernardo
c70e2a345e allow 2 go routines to send 2022-03-16 20:34:51 +00:00
Bernardo
7d07249150 review suggestions 2022-03-15 18:22:32 +00:00
Bernardo
06f1f6eb52 add comments 2022-03-15 05:59:18 +00:00
Bernardo
2163c2312a review suggestions 2022-03-15 05:50:18 +00:00
Jose Garcia
bc80675b6f Remove unused types 2022-03-14 10:34:52 -04:00
Jose Garcia
ed376f3691 Pass conn to handlers instead of obj stream 2022-03-14 10:29:31 -04:00
Bernardo
ca7e2d386d review suggestion: non-blocking send 2022-03-11 23:34:58 +00:00
Bernardo
a03e9d3c95 review suggestions 2022-03-11 22:53:01 +00:00
Bernardo
9b1a6607ce review suggestion: deregister handle after receiving notification 2022-03-07 22:00:16 +00:00
Bernardo
9616706984 review suggestion 2022-03-04 22:30:50 +00:00
JP Ungaretti
3582090fb8 Fix RPC call 2022-03-03 01:21:35 +00:00
Bernardo
383a711902 fix linter error 2022-03-02 17:59:46 +00:00
Bernardo
347e7dc67b delete unneeded comment 2022-03-02 01:22:05 +00:00
JP Ungaretti
9e3b955163 Add cs jupyter 2022-03-01 22:38:35 +00:00
Jose Garcia
35638cb82f Update tests for serverSharing 2022-02-28 08:22:09 -05:00
Jose Garcia
2328ccb881 Abstract port notification logic into liveshare 2022-02-28 07:56:37 -05:00
Jose Garcia
3847d965da Refactor port update data into liveshare 2022-02-25 08:09:12 -05:00
Jose Garcia
9556c72ecf Update event types and drop idea of global request 2022-02-17 17:05:56 -05:00
Jose Garcia
ee349700de Checkin almost final impl but wrong direction 2022-02-16 17:56:09 -05:00
Jose Garcia
c96807fae7 Clean up cruft 2022-02-15 15:34:04 -05:00
Jose Garcia
c90da9799d Tests for update port visibility 2022-02-15 15:30:06 -05:00
Jose Garcia
04a4e43dec Initial spike with request/event handling 2022-02-14 17:22:58 -05:00
Marwan Sulaiman
22c5269606
Fix flaky liveshare session test (#5111) 
* Fix flaky liveshare session test

* typo

* PR comments
 2022-01-27 11:20:50 -05:00
Jeff Hubbard
97d85d0ac0 Oops, left it as second from debugging 2021-10-28 16:33:13 -07:00
Jeff Hubbard
c18e54189c Adds a timeout context to the ssh waiter to prevent indefinite hanging 2021-10-27 15:40:49 -07:00
Mislav Marohnić
d68126af99 Avoid macOS prompt to allow incoming connections in liveshare tests 
Listening on the localhost interface disallows connections from the
outside anyway, so the OS firewall doesn't have to prompt whether the
user wants to allow incoming connections to the Go process.
 2021-10-14 14:23:36 +02:00
Jose Garcia
d5c9630fae
Merge pull request #4511 from cli/jg/keepalive-fix 
codespace ssh: fix for nil logger on non-debugging scenarios
 2021-10-13 14:44:10 -04:00
Jose Garcia
d6b5157eff Fix for nil logger on non-debugging scenarios 2021-10-13 14:15:26 -04:00
Marwan Sulaiman
b9bdef2b00
Add org scoped port forwarding + fix test formatting (#4497) 
* Add org scoped port forwarding + fix test formatting

* Redesign port visibility

* Update pkg/cmd/codespace/ports.go

Co-authored-by: Jose Garcia <josebalius@github.com>

* Change sub command to privacy

* Example pr comment

* Fix test mock

* Fix test mock

Co-authored-by: Jose Garcia <josebalius@github.com>
 2021-10-13 13:56:03 -04:00
Jose Garcia
5170a2931f Switch to standard lib log.Logger & support dfile 
- --debug-file flag can now be used in conjuction with --debug to
  specify the debug file path
- Push out logger concerns to callers of liveshare
 2021-10-12 15:45:05 -04:00
Jose Garcia
1aefc74378 Add more time between events 2021-10-07 16:48:09 -04:00
Jose Garcia
1ff58a3de7 Update docs, remove needless condition check 2021-10-07 16:39:43 -04:00
Jose Garcia
97cbdca84a Fix additional race in tests 2021-10-07 15:45:55 -04:00
Jose Garcia
2406f3f09a Fix races and remove unreachable code 2021-10-07 15:32:07 -04:00
Jose Garcia
8f5d6bb672 Tests for most of the new behavior 
- Made the heartbeat interval configurable for easier testing
- Moved span to the top of connect to capture the full execution
 2021-10-07 15:14:42 -04:00
Jose Garcia
55f4fcf05c Live Share session activity detection 
- Session now accepts two new options: ClientName and Logger
- Port forwarder now supports a keepAlive parameter which when true,
  instructs the PF to call the session's keepAlive method.
- Port forwarder uses a new traffic monitor to detect I/O traffic and
  notify the session when applicable.
- The SSH command introduces a new debug flag which enables the command
  to log to a new temporary file. The file path is printed to the user.
 2021-10-07 10:42:06 -04:00
Jose Garcia
53e4149c91 Update tests 2021-09-30 10:42:03 -04:00
Jose Garcia
f4a5f82312 Move internal/liveshare to pkg/liveshare 2021-09-30 10:34:27 -04:00