Commit graph

556 commits

Author SHA1 Message Date
vilmibm
7bbd70d6b2 use default to preserve non-interactive behavior 2020-01-15 11:27:25 -06:00
vilmibm
3468a46521 support preview in browser for issue create 2020-01-15 11:27:12 -06:00
vilmibm
d8cbb6a6a7 support previewing PRs in the browser 2020-01-14 17:03:53 -06:00
vilmibm
062d4f2367 note 2020-01-14 15:22:50 -06:00
vilmibm
164064064b e to edit body, enter to skip 2020-01-14 15:20:11 -06:00
vilmibm
e821d2781a towards extending survey.Editor behavior 2020-01-14 15:20:11 -06:00
Nate Smith
a9db4e8d21 Merge pull request #221 from github/release-the-kraken
Add changelog link to `gh version` and `gh --version`
2020-01-13 18:08:50 -06:00
Nate Smith
bf209d88a6 Merge pull request #222 from github/oauth-debug
Improve OAuth flow
2020-01-13 18:03:32 -06:00
Nate Smith
42f58eac4b Merge pull request #203 from github/preview-things
Preview issues and PRs on the terminal
2020-01-13 17:59:34 -06:00
vilmibm
daf02ff3ec de-inline go-termd 2020-01-13 16:10:22 -06:00
vilmibm
4592aaf63d clarify newline normalization 2020-01-13 15:36:43 -06:00
vilmibm
5bc6d220c4 review feedback 2020-01-13 15:32:07 -06:00
Mislav Marohnić
853fda13e9 Add more OAuth flow debugging to stderr with DEBUG=oauth 2020-01-13 20:31:31 +01:00
Mislav Marohnić
d6a437a93c Add a TODO to make scopes configurable 2020-01-13 20:17:20 +01:00
Corey Johnson
ced6809e1e add changelog to --version 2020-01-13 11:14:45 -08:00
Mislav Marohnić
bbeb558fce Narrow the scope of the local server handler
Before, the local server handled any request regardless of path, which
could potentially include requests generated by the browser such as the
one for favicon. This could lead to race conditions around reading the
code to continue to OAuth flow with.

Now, have the OAuth flow redirect to `localhost:PORT/callback` and only
handle `/callback` requests specifically.
2020-01-13 20:14:00 +01:00
Mislav Marohnić
635d2963f6 Add more explicit error handling around the OAuth flow 2020-01-13 20:13:41 +01:00
Corey Johnson
1921a74eec Add changelog func 2020-01-13 11:02:34 -08:00
Nate Smith
c5486ee3f2 Merge pull request #210 from github/noprinting
minor text edits
2020-01-13 12:19:01 -06:00
Lee Reilly
ffd756c18a Merge pull request #181 from github/draft-security-md
Add security.md
2020-01-13 10:18:39 -08:00
Nate Smith
83c647366b Merge pull request #213 from github/git-current-branch-compat
Read current git branch in a way that is compatible with older git
2020-01-10 16:06:27 -06:00
vilmibm
bc1ab20cdf turns out this has frightening state 2020-01-10 15:40:09 -06:00
vilmibm
bbdf30c8f8 add tests for pr/issue previewing in terminal 2020-01-10 15:40:09 -06:00
vilmibm
f911a234c2 print to proper handle 2020-01-10 15:12:54 -06:00
vilmibm
e42b097629 inline a markdown rendering lib
This commit inlines https://github.com/tj/go-termd for a few reasons:

- off the shelf it relies on a broken, erroneously released version of
blackfriday (a markdown parser)
- based on discussion with ampinsk, there are some tweaks we'd like to
make to markdown rendering beyond what the library exposes now
- it's a small library (around 300 sloc)

This commit only:

- messes with go.mod to fix the blackfriday issues
- adds an inclusion note
- renames the package
2020-01-10 14:44:51 -06:00
Tiernan L
756610301e Swap to show 2020-01-10 07:53:16 -10:00
vilmibm
4925c3cf01 preview PRs and issues in the terminal with -p 2020-01-10 11:41:26 -06:00
Mislav Marohnić
d8474d5990 Read current git branch in a way that is compatible with older git 2020-01-10 14:08:54 +01:00
Mislav Marohnić
f0ab533bbc Merge pull request #207 from github/tweak-windows-build
Improve naming of Windows release asset
2020-01-10 11:54:29 +01:00
Tiernan L
025845e9ff browser is sufficient
We used "browser" and "web browser" in multiple places. I made them all consistent.
2020-01-09 15:29:11 -10:00
Tiernan L
204e902dba browser is sufficient 2020-01-09 15:27:39 -10:00
Tiernan L
b2350be56a change print to view 2020-01-09 09:54:34 -10:00
Corey Johnson
869f50ec0f Merge pull request #205 from github/and-four-more
Add "show more" to the issues and PR results in `gh issue status` and `gh pr status`
2020-01-09 11:11:17 -08:00
Mislav Marohnić
ef8b376b09 Add npm run build script to download-exe action 2020-01-09 15:04:34 +01:00
Mislav Marohnić
a34d07aecb Improve .msi asset handling in upload-msi action
- Allow .msi file to be specified via input to action
- Delete obsolete .exe file after uploading .msi
2020-01-09 15:02:48 +01:00
Mislav Marohnić
abca8d8685 Add npm run build script to upload-msi action 2020-01-09 14:58:57 +01:00
Mislav Marohnić
88f0f3a8b2 Preserve original filename in build-msi action 2020-01-09 14:56:43 +01:00
Mislav Marohnić
30d06c13ba Add npm run build script to build-msi action 2020-01-09 14:54:13 +01:00
Corey Johnson
5ed1dbe02f Fix fixtures 2020-01-08 12:40:39 -08:00
Corey Johnson
c9bcf807b1 Make it work with PRs 2020-01-08 12:31:23 -08:00
Corey Johnson
4fcf13dac4 Make it work with PRs 2020-01-08 11:44:27 -08:00
Corey Johnson
30abea1813 Fix fixtures 2020-01-08 10:39:28 -08:00
Mislav Marohnić
2053809436 Merge pull request #201 from github/cleanup-scripts
Cleanup release scripts
2020-01-08 17:22:46 +01:00
Mislav Marohnić
0639ef8445 Cleanup unnecessary workflow bits 2020-01-08 17:17:40 +01:00
Mislav Marohnić
1f2277cdd3 Merge pull request #199 from github/generate-changelog
Generate changelog on release
2020-01-08 17:15:06 +01:00
Mislav Marohnić
09bc873104 Merge pull request #200 from github/fix-language-stats
Fix language stats for this repository
2020-01-08 17:01:24 +01:00
Corey Johnson
3eb820631d Add "and x more" text" 2020-01-07 14:51:49 -08:00
Corey Johnson
c6775eae6c Merge pull request #165 from github/appropriate-context-and-feedback
Add context and feedback output to commands
2020-01-07 12:22:36 -08:00
Mislav Marohnić
7edde9306a Move Windows build scripts under script/ 2020-01-07 15:51:57 +01:00
Mislav Marohnić
732b3ddbe3 Merge pull request #198 from github/build-matrix
Use build matrix for CI job
2020-01-07 15:38:14 +01:00