Commit graph

7167 commits

Author SHA1 Message Date
Greggory Rothmeier
7ced1227f9
Align devcontainer Go version with go.mod (#8570) 2024-01-12 13:58:56 -08:00
David Gardiner
e0f31b3932
Merge pull request #8569 from dmgardiner25/fix-codespaces-token-permissions
Move create codespace permission opt out behind `else` to fix token permissions
2024-01-12 13:31:06 -08:00
David Gardiner
20273d1f17 Move create codespace permission opt out behind else to fix token permissions 2024-01-12 12:16:38 -08:00
ihmpavel
72b6dc5d8c
chore: Unify calling gh in examples (#8560) 2024-01-11 09:07:23 -08:00
Andy Feller
e9fabfe9a9
Merge pull request #8479 from muzimuzhi/docs/backquote-gh-config
Backquote settings in `gh-config` docs
2024-01-10 08:18:25 -05:00
Sam Coe
785a340f78
Prevent downloading releases with assets that match windows reserved filenames (#8517)
* Prevent downloading releases with assets that match windows reserved filenames

* Add comment noting potential use of build constraints in the future
2024-01-09 09:53:57 -08:00
Heath Stewart
0cf5d22ead
Support template, jq flags with standard format flag (#7832)
* Use standard JSON flags for project command

Deprecates the --format flag and adds the standard JSON flags to properly filter, template, and write JSON.

* Add format flags cmdutil

Resolves PR feedback

* Remove unnecessary fields from JSON format flags

* Add standard format help to remaining commands

* Add JSON format regression tests

Also fixed a number of `project` commands that didn't format the right object as JSON.

* Resolve PR feedback
2024-01-09 09:46:39 -08:00
Andy Feller
b8a1ff6e70
Merge pull request #8542 from cli/andyfeller-patch-1
Remove redundant MSI signing environment variables typo
2024-01-08 08:59:48 -05:00
Andy Feller
48f5a15e0d
Update deployment.yml
Removed previous deployment step env vars
2024-01-08 08:48:55 -05:00
Yukai Chou
c73f41b32e Mark-up gh-config settings with backticks 2024-01-08 02:05:40 +08:00
Andy Feller
586eb8b865
Merge pull request #8453 from samueldurantes/samueldurantes/browse-help-message
Add more help message to browse command
2024-01-05 10:19:51 -05:00
Samuel Durante
109458cf66
Update pkg/cmd/browse/browse.go
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-01-05 10:53:15 -04:00
dependabot[bot]
d35ef85e31
build(deps): bump golang.org/x/crypto from 0.14.0 to 0.17.0 (#8473)
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.17.0.
- [Commits](https://github.com/golang/crypto/compare/v0.14.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-02 11:44:29 -08:00
Andy Feller
541ce0e5b4
Merge pull request #8465 from cli/andyfeller/213-windows-hsm-signing
Update deployment workflow for final HSM solution
2023-12-15 11:52:35 -05:00
Andy Feller
98f7ec0b63 Ensure Windows sign script fails based on signtool
This is a change based on PR discussion about ensuring the sign script fails if signtool errors, passing the last exit code from the called command as the result of the script.

For more information, see https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_automatic_variables?view=powershell-7.4#lastexitcode
2023-12-15 11:39:38 -05:00
Andy Feller
c626f9039b
Merge pull request #8459 from benebsiny/cli-8009
Verify the downloaded zip for `gh run view --log`
2023-12-15 08:41:09 -05:00
William Martin
9b4c06f0b2
Merge pull request #8463 from cli/dependabot/github_actions/github/codeql-action-3
build(deps): bump github/codeql-action from 2 to 3
2023-12-15 14:34:06 +01:00
Andy Feller
5ecdf166fb Update deployment workflow for final HSM solution
This applies the changes from the separate Windows HSM signing prototype development to the official deployment workflow including:

1. Use of Azure Code Signing client
2. Sourcing signtool.exe from runner
3. Moving from batch to PowerShell for Windows signing script
4. Using the same signing process for .exe and .msi
2023-12-14 13:15:38 -05:00
Andy Feller
441beb9de3 Fix signtool invocation 2023-12-14 11:42:34 -05:00
Andy Feller
ed573a1eb8 Fix sign script fail conditions
There is a bug in the sign.ps1 script as the opposite comparison operators were used.
2023-12-14 11:29:37 -05:00
Andy Feller
8861f95b9e Fix HSM goreleaser calling sign script 2023-12-14 11:14:23 -05:00
Andy Feller
6a96de14bf Fix HSM Windows signing 2023-12-14 11:02:28 -05:00
Andy Feller
3a476b81cb
Merge pull request #8464 from cli/andyfeller/213-windows-hsm-signing-testing
Fix issue sourcing signtool for Windows signing
2023-12-14 10:08:38 -05:00
Andy Feller
3790262123 Fix issue sourcing signtool for Windows signing
Workflow is currently breaking because there are multiple versions of signtool
installed on runners.  We face a challenge where we either hardcode this to a
specific version on the runner or always choose the latest version; this change
does the latter.
2023-12-14 09:50:29 -05:00
dependabot[bot]
1df8e833c7
build(deps): bump github/codeql-action from 2 to 3
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/v2...v3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-14 14:24:28 +00:00
Andy Feller
29f409666e
Merge pull request #8457 from cli/andyfeller/213-windows-hsm-signing-testing
Enhance HSM deployment prototype to use the same signing process for .exe and .msi
2023-12-14 07:10:13 -05:00
EBIBO
be81f9f0cb
Merge branch 'trunk' into cli-8009 2023-12-13 12:56:26 -05:00
benebsiny
0b73f2af86 Verify the downloaded zip for gh run view --log 2023-12-14 01:54:16 +08:00
Andy Feller
d3d4a681f2 Add missing PowerShell file from previous commit 2023-12-13 10:21:02 -05:00
Andy Feller
e01809c075 Unify Windows sign process on signtool
- converts the process from using script/sign.bat to script/sign.ps1 for supportability and capability
- resolves signtool on runner in order to run rather than hardcoded path
2023-12-13 10:19:36 -05:00
William Martin
6d11395c08
Merge pull request #8454 from cli/wm/fix-time-flake-tests
Fix flaky tests coupled to relative dates
2023-12-13 15:00:04 +01:00
William Martin
a9bdd8d186 Fix flaky tests coupled to relative dates 2023-12-13 14:44:16 +01:00
Samuel Durante
ab7e55e20a Add more help message to browse command 2023-12-12 20:36:40 -03:00
Andy Feller
0be047296e
Merge pull request #8450 from cli/andyfeller/213-windows-hsm-signing-testing
Fix release script to invoke HSM goreleaser config
2023-12-12 11:56:23 -05:00
Andy Feller
a2ec7ab43f Fix release script to invoke HSM goreleaser config 2023-12-12 10:48:38 -05:00
Andy Feller
f0f09bda57
Merge pull request #8421 from cli/andyfeller/213-windows-hsm-signing-testing
Create HSM testing workflow
2023-12-12 10:19:51 -05:00
Andy Feller
35f99ee426 Final fixes 2023-12-12 10:09:47 -05:00
Andy Feller
783dbf999a Remove fugue artifact 2023-12-12 09:56:35 -05:00
Andy Feller
bcbd848bfe Remove unnecessary copying, fix secrets part deux 2023-12-12 09:54:55 -05:00
Andy Feller
1fff21a63e Fixes based on actual secret names and signtool insights 2023-12-12 09:48:16 -05:00
William Martin
0f39935cc1
Merge pull request #8449 from cli/wm/remove-redundant-err
Remove redundant error on migration failure
2023-12-11 16:43:48 +01:00
William Martin
cceec8e0d0 Remove redundant error on migration failure 2023-12-11 16:25:20 +01:00
Sam Coe
52fb3b62b3
Update multi-account migration error msg (#8448)
* Make sure default host is stubbed out for all auth login tests

* Improve multi-account migration error message
2023-12-11 15:20:23 +00:00
Andy Feller
df249bc16c
Merge pull request #8447 from cli/andyfeller/8446-run-exported-jobs
Fix run exported jobs error for completedAt
2023-12-11 10:11:09 -05:00
Andy Feller
b442a1b4d2 Fix run exported jobs error for completedAt 2023-12-11 08:42:43 -05:00
Andy Feller
4f8d2f71e4 Moving options to metadata 2023-12-08 17:33:52 -05:00
Andy Feller
4054968fc3 Fix Dlib DLL path
Mixed up Unix and Windows path separators
2023-12-08 17:30:28 -05:00
Andy Feller
0af95d9314 Remove previous hsm test workflow 2023-12-08 17:29:19 -05:00
Andy Feller
5e8e645a7f Update HSM test using Desktop approach
This update leverages GitHub Desktop approach of downloading Azure Code Signing DLL and wiring it up as part of the existing signing process used by Windows builds.
2023-12-08 17:27:22 -05:00
Andy Feller
385bb48f21
Merge pull request #8428 from cli/dependabot/github_actions/actions/setup-go-5
build(deps): bump actions/setup-go from 4 to 5
2023-12-08 13:49:23 -05:00