Commit graph

40 commits

Author SHA1 Message Date
David Gardiner
73dfb87680
Use gRPC client to notify codespace of activity (#6870)
* Use gRPC client to notify codespace of activity

* Add test

* Update comment
2023-01-18 16:31:16 -06:00
David Gardiner
ce6b7d8762 Start SSH server with gRPC 2023-01-10 11:59:56 -08:00
David Gardiner
98eaac3e40 Rebuild container using gRPC client 2023-01-09 10:58:47 -08:00
David Gardiner
000a84d49b Address comments 2023-01-04 15:33:33 -08:00
David Gardiner
1e75a74d18 Create centralized Codespaces RPC invoker 2023-01-04 14:41:25 -08:00
JP Ungaretti
a29820ebe3 Use incremental rebuild by default 2022-11-01 21:00:14 +00:00
JP Ungaretti
982aa5ba82 Rename RPC command to RebuildContainer 2022-10-10 21:01:29 +00:00
JP Ungaretti
b373fbbe44 Remove else block 2022-10-09 01:00:14 +00:00
JP Ungaretti
30fcddeccb Use nil instead of []string{} 2022-10-09 00:59:54 +00:00
JP Ungaretti
d05cdf5ff3 Tidy up comments and errors 2022-10-08 06:30:42 +00:00
JP Ungaretti
da91216c31 Add new Rebuild function 2022-10-08 00:04:45 +00:00
Caleb Brose
83153fe9e5 Cleanups from PR comments 2022-06-14 14:33:41 +00:00
Caleb Brose
b5580f9503 Refactor inferfaces from PR comments 2022-06-13 19:04:29 +00:00
cmbrose
eebef06c67 Merge main and use func options again 2022-06-07 12:27:29 -05:00
cmbrose
9095556372 Merge remote-tracking branch 'upstream/trunk' into jungaretti/no-ssh-keys 2022-06-07 12:07:03 -05:00
Greggory Rothmeier
f15a8ca335
Extract LiveshareSession interface (#5725)
This will make it possible to inject a mock liveshare session for testing
2022-06-06 15:52:52 +02:00
cmbrose
f67ca53c07 Refactor ssh_keys to a more common location 2022-06-03 13:39:52 -05:00
JP Ungaretti
a1629c70c0 Generate codespaces key 2022-05-31 17:19:16 -07:00
cmbrose
ac630880c6 Refactor to WithOptions 2022-05-31 15:52:16 -05:00
JP Ungaretti
76090a2ea7 Add key to RPC call 2022-05-26 21:45:20 +00:00
JP Ungaretti
f21faca03e Resolve feedback 2022-04-21 14:56:55 -07:00
JP Ungaretti
e8e9b58670 Clean up errors 2022-04-14 16:12:44 -05:00
JP Ungaretti
eaf8f84baf Merge branch 'trunk' into add-cs-jupyter 2022-04-14 15:27:40 -05:00
JP Ungaretti
33a1b95dbf Fix name of RPC service 2022-04-14 14:55:29 -05:00
Bernardo
7d07249150 review suggestions 2022-03-15 18:22:32 +00:00
Bernardo
2163c2312a review suggestions 2022-03-15 05:50:18 +00:00
Bernardo
9b1a6607ce review suggestion: deregister handle after receiving notification 2022-03-07 22:00:16 +00:00
JP Ungaretti
3582090fb8 Fix RPC call 2022-03-03 01:21:35 +00:00
JP Ungaretti
9e3b955163 Add cs jupyter 2022-03-01 22:38:35 +00:00
Jose Garcia
2328ccb881 Abstract port notification logic into liveshare 2022-02-28 07:56:37 -05:00
Jose Garcia
3847d965da Refactor port update data into liveshare 2022-02-25 08:09:12 -05:00
Jose Garcia
ee349700de Checkin almost final impl but wrong direction 2022-02-16 17:56:09 -05:00
Jose Garcia
04a4e43dec Initial spike with request/event handling 2022-02-14 17:22:58 -05:00
Marwan Sulaiman
22c5269606
Fix flaky liveshare session test (#5111)
* Fix flaky liveshare session test

* typo

* PR comments
2022-01-27 11:20:50 -05:00
Marwan Sulaiman
b9bdef2b00
Add org scoped port forwarding + fix test formatting (#4497)
* Add org scoped port forwarding + fix test formatting

* Redesign port visibility

* Update pkg/cmd/codespace/ports.go

Co-authored-by: Jose Garcia <josebalius@github.com>

* Change sub command to privacy

* Example pr comment

* Fix test mock

* Fix test mock

Co-authored-by: Jose Garcia <josebalius@github.com>
2021-10-13 13:56:03 -04:00
Jose Garcia
1ff58a3de7 Update docs, remove needless condition check 2021-10-07 16:39:43 -04:00
Jose Garcia
2406f3f09a Fix races and remove unreachable code 2021-10-07 15:32:07 -04:00
Jose Garcia
8f5d6bb672 Tests for most of the new behavior
- Made the heartbeat interval configurable for easier testing
- Moved span to the top of connect to capture the full execution
2021-10-07 15:14:42 -04:00
Jose Garcia
55f4fcf05c Live Share session activity detection
- Session now accepts two new options: ClientName and Logger
- Port forwarder now supports a keepAlive parameter which when true,
  instructs the PF to call the session's keepAlive method.
- Port forwarder uses a new traffic monitor to detect I/O traffic and
  notify the session when applicable.
- The SSH command introduces a new debug flag which enables the command
  to log to a new temporary file. The file path is printed to the user.
2021-10-07 10:42:06 -04:00
Jose Garcia
f4a5f82312 Move internal/liveshare to pkg/liveshare 2021-09-30 10:34:27 -04:00
Renamed from internal/liveshare/session.go (Browse further)