Tyler McGoffin
8109594c4c
auth: Removed redundant ghauth.IsTenancy(host) check
2024-10-15 11:56:43 -07:00
Tyler McGoffin
81591a09b8
Use go-gh/auth package for IsEnterprise, IsTenancy, and NormalizeHostname
2024-10-15 11:56:43 -07:00
Tyler McGoffin
44fdb3320d
Upgrade go-gh version to 2.11.0
2024-10-15 11:56:43 -07:00
Tyler McGoffin
3a8417f6c7
Add test coverage to places where IsEnterprise incorrectly covers Tenancy
...
IsEnterprise currently returns `true` when `IsTenancy` returns true. We
prefer that this behavior is orthogonal. This commit adds failing tests to
the instances where IsEnterprise should not behave the same as IsTenancy.
These test cases are expected to pass with the inclusion of the coming
improvements to go-gh to handle the orthogonality of IsEnterprise and
IsTenancy.
2024-10-15 11:56:43 -07:00
William Martin
c657cfac37
Merge pull request #9745 from cli/wm/testscript-pr
...
Introduce testscript acceptance tests generally, and for the PR command specifically
2024-10-14 20:23:30 +02:00
William Martin
2a0be61d5e
Ensure pr create with metadata has assignment
2024-10-14 14:50:59 +02:00
William Martin
5e02326792
Document sharedCmds func in acceptance tests
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-10-14 14:36:34 +02:00
William Martin
f7b279db11
Correct testscript description in Acceptance readme
2024-10-14 14:35:35 +02:00
William Martin
b095d6bd58
Add link to testscript pkg documentation
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-10-14 14:33:49 +02:00
William Martin
f3589b2573
Add VSCode extension links to Acceptance README
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-10-14 14:33:17 +02:00
William Martin
c2c88b293e
Fix GH_HOST / GH_ACCEPTANCE_HOST misuse
2024-10-14 14:32:05 +02:00
William Martin
1f94cf9dac
Acceptance test PR list
2024-10-14 14:31:24 +02:00
William Martin
bfa5b6afa5
Support skipping Acceptance test cleanup
2024-10-14 13:59:55 +02:00
William Martin
4d986aaed4
Acceptance test PR creation with metadata
2024-10-14 13:54:31 +02:00
William Martin
fbc72fd2be
Suggest using legacy PAT for acceptance tests
2024-10-14 13:01:13 +02:00
William Martin
503659f11c
Add host recommendation to Acceptance test docs
2024-10-14 12:56:27 +02:00
Andy Feller
b91dab4456
Merge pull request #9721 from cli/bagtoad/cli-8946-list-licenses-and-gitignore-options
...
Add `repo license list/view` and `repo gitignore list/view`
2024-10-11 14:29:18 -04:00
bagtoad
41f5209708
Fix api tests after function signature changes
2024-10-11 12:20:12 -06:00
bagtoad
291370824b
Return nil instead of empty objects when err
2024-10-11 12:08:10 -06:00
bagtoad
b6cdbc9e22
Fix license list and view tests
2024-10-11 11:59:06 -06:00
William Martin
0d7ec44895
Validate required env vars not-empty for Acceptance tests
2024-10-11 18:08:42 +02:00
William Martin
846a39d7be
Add go to test instructions in Acceptance README
2024-10-11 17:57:08 +02:00
Kynan Ware
c6c938fafe
Apply suggestions from code review
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-10-11 09:53:33 -06:00
William Martin
fd66555510
Error if acceptance tests are targeting github or cli orgs
2024-10-11 17:51:17 +02:00
William Martin
f9b24990d6
Add codecoverage to Acceptance README
2024-10-11 16:31:23 +02:00
William Martin
9d569b3c11
Isolate acceptance env vars
2024-10-11 16:31:23 +02:00
William Martin
dc7c66c142
Add Writing Tests section to Acceptance README
2024-10-11 16:31:22 +02:00
William Martin
64f5b3c206
Add Debug and Authoring sections to Acceptance README
2024-10-11 16:31:22 +02:00
William Martin
ee5709a4b6
Acceptance test PR comment
2024-10-11 16:31:22 +02:00
William Martin
99a9b35410
Acceptance test PR merge and rebase
2024-10-11 16:31:22 +02:00
William Martin
320c5aba4a
Note syntax highlighting support for txtar files
2024-10-11 16:31:22 +02:00
William Martin
502daff2a1
Refactor acceptance test environment handling
2024-10-11 16:31:22 +02:00
William Martin
5745eb1c1c
Add initial acceptance test README
2024-10-11 16:31:22 +02:00
William Martin
eb9eeb10e1
Use txtar extension for testscripts
2024-10-11 16:31:22 +02:00
William Martin
99f7e048f9
Support targeting other hosts in acceptance tests
2024-10-11 16:31:22 +02:00
William Martin
464a69ae87
Use stdout2env in PR acceptance tests
2024-10-11 16:31:21 +02:00
William Martin
37171628c6
Acceptance test PR checkout
2024-10-11 16:31:21 +02:00
William Martin
5ed237c65a
Add pr view test script
2024-10-11 16:31:21 +02:00
William Martin
d7465bdf3c
Initial testscript introduction
2024-10-11 16:31:16 +02:00
bagtoad
9b0fc5d555
Merge branch 'bagtoad/cli-8946-list-licenses-and-gitignore-options' of https://github.com/cli/cli into bagtoad/cli-8946-list-licenses-and-gitignore-options
2024-10-09 22:51:38 -06:00
bagtoad
95ca152fea
Add examples for creating .gitignore files
2024-10-09 22:51:24 -06:00
Kynan Ware
d45777651d
Merge branch 'trunk' into bagtoad/cli-8946-list-licenses-and-gitignore-options
2024-10-09 22:42:29 -06:00
bagtoad
922a157206
Update help for license view
...
Updated `Use` to indicate that args can be an SPDX ID or license key.
Improved the examples docs to show the use of both.
2024-10-09 22:34:06 -06:00
bagtoad
9b94bee895
Refactor http error handling
2024-10-09 22:26:03 -06:00
bagtoad
8abed17a00
implement --web flag for license view
2024-10-09 22:21:26 -06:00
bagtoad
a42d3e2f79
Fix license view help doc, add LICENSE.md example
2024-10-09 21:46:41 -06:00
bagtoad
f07f49810a
Update help and fix heredoc indentation
2024-10-09 21:41:54 -06:00
bagtoad
282b3293c5
Add SPDX ID to license list output
2024-10-09 21:21:13 -06:00
bagtoad
d6c6c6b40c
Fix ExactArgs invocation
2024-10-09 21:15:16 -06:00
bagtoad
f064bda5ea
Add Long for license list indicating limitations
2024-10-09 21:10:35 -06:00
