Heath Stewart
81f3526740
Fix tests
2024-08-16 10:11:52 -07:00
Heath Stewart
009838a8db
Always print URL scheme to stdout
...
Fixes #9470
2024-08-16 10:11:46 -07:00
Fredrik Skogman
255f5301d5
Merge pull request #9467 from cli/attestation-tuf-root-update
...
Update attestation TUF root
2024-08-16 08:40:55 +02:00
Kynan Ware
0140e3de66
Merge pull request #9468 from cli/BagToad-external-contributors-note
...
Add note for external contributors to `working-with-us.md`
2024-08-15 15:47:56 -06:00
Andy Feller
0e690fad0e
Merge pull request #9462 from cli/9394-update-go-extension-workflow-template-to-reflect-recent-enhancements-to-cligh-extension-precompile
...
Update Go and other extension workflow templates to reflect recent enhancements to `cli/gh-extension-precompile`
2024-08-15 13:43:42 -04:00
Kynan Ware
d707102958
Add a note about external contributors to working-with-us.md
2024-08-15 11:24:40 -06:00
Cody Soyland
4618a267de
Update attestation TUF root
...
Signed-off-by: Cody Soyland <codysoyland@github.com>
2024-08-15 13:06:54 -04:00
Kynan Ware
5b7070f027
include required permissions to generate attestations
2024-08-14 15:16:45 -06:00
dependabot[bot]
0835642d3f
build(deps): bump github.com/creack/pty from 1.1.21 to 1.1.23 ( #9459 )
...
Bumps [github.com/creack/pty](https://github.com/creack/pty ) from 1.1.21 to 1.1.23.
- [Release notes](https://github.com/creack/pty/releases )
- [Commits](https://github.com/creack/pty/compare/v1.1.21...v1.1.23 )
---
updated-dependencies:
- dependency-name: github.com/creack/pty
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-08-14 11:35:19 -07:00
Kynan Ware
820f4f3469
Do not generate build attestations for otherBinWorkflow.yml
2024-08-14 12:02:11 -06:00
bagtoad
025dcc8e95
Use latest checkout version, generate attestations, and specify go version file input.
2024-08-14 10:20:41 -06:00
Cody Soyland
9e27af999e
Merge pull request #9442 from cli/require-sigstore-bundle-v0.3
...
Require Sigstore Bundle v0.2+ when verifying with `gh attestation`
2024-08-13 13:56:11 -04:00
Andy Feller
f33c98945c
Merge pull request #9451 from cli/dependabot/github_actions/actions/attest-build-provenance-1.4.1
...
build(deps): bump actions/attest-build-provenance from 1.4.0 to 1.4.1
2024-08-12 11:36:36 -04:00
dependabot[bot]
da43f6e476
build(deps): bump actions/attest-build-provenance from 1.4.0 to 1.4.1
...
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance ) from 1.4.0 to 1.4.1.
- [Release notes](https://github.com/actions/attest-build-provenance/releases )
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md )
- [Commits](210c191353...310b0a4a3b
2024-08-12 15:00:14 +00:00
Andy Feller
a863dfdb30
Merge pull request #9433 from benebsiny/cli-9310
...
Add `pr create --editor`
2024-08-12 10:10:18 -04:00
Andy Feller
369a105c45
Minor grammatical fix
2024-08-12 10:00:37 -04:00
Andy Feller
58ff5c4b28
Merge pull request #9385 from babakks/9299-improve-annotated-releases
...
Improve `gh release create --notes-from-tag` behavior with multiline tag annotation
2024-08-12 09:50:57 -04:00
Babak K. Shandiz
6dc729792d
Merge branch 'trunk' into 9299-improve-annotated-releases
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-08-10 21:55:41 +01:00
Babak K. Shandiz
668dbcefc6
Add test cases for PGP, SSH and X.509 signatures
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-08-10 21:50:31 +01:00
Babak K. Shandiz
b36b39df60
Explain why not looking for signature begin marker
...
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-08-10 21:29:22 +01:00
Andy Feller
3ca70905b2
Merge pull request #9444 from muzimuzhi/docs/unify-markup
2024-08-09 23:09:57 -04:00
Yukai Chou
ac77d6750d
Wrap flags with backticks, continued
2024-08-10 10:24:28 +08:00
Tyler McGoffin
18d58b8d84
Replace --project.* flags' name with title in docs ( #9443 )
...
With the upcoming migration from v1 project to v2 projects, we'd like the
language in our documentation to align with v2 project language. In v2,
projects are referred to by `title` and not `name`, though they are
functionally equivalent under the hood for the CLI
2024-08-09 13:55:14 -07:00
Cody Soyland
35b2cf70cf
Change to requiring bundle v0.2
...
Signed-off-by: Cody Soyland <codysoyland@github.com>
2024-08-09 16:36:16 -04:00
Cody Soyland
b783441540
Fix tests
...
Signed-off-by: Cody Soyland <codysoyland@github.com>
2024-08-09 16:14:04 -04:00
Cody Soyland
574e131072
Require Sigstore Bundle v0.3 when verifying with gh attestation
...
Signed-off-by: Cody Soyland <codysoyland@github.com>
2024-08-09 16:02:04 -04:00
Andy Feller
7fe14ee0c0
Merge pull request #9432 from cli/dependabot/go_modules/github.com/google/go-containerregistry-0.20.2
...
build(deps): bump github.com/google/go-containerregistry from 0.20.1 to 0.20.2
2024-08-09 14:00:57 -04:00
Andy Feller
dbcac5abc4
Merge pull request #9412 from sato11/docs-run-download-n
...
Document that `gh run download` downloads the latest artifact by default
2024-08-08 17:33:06 -04:00
Prabhat Kumar Sahu
ab34d868aa
Change gh repo set-default --view to print to stderr when no default exists ( #9431 )
...
Change logging of `gh repo set-default --view` to `stderr` when no default exists to better conform with expectations and unix standards.
---------
Signed-off-by: Prabhat <iprabhatdev@gmail.com>
2024-08-08 13:44:52 -07:00
Junichi Sato
330a385f9e
Document that gh run download downloads the latest artifact by default
...
This commit addresses the documentation issue.
The discussion at #7018 has confirmed that it is undocumented that
the current behavior of `gh run download` with `-n` and no `run-id`
downloads the latest artifact.
Although the behavior has not been created intentionally, it is the one
that should be documented and the future releases should warn before
a breaking change.
2024-08-08 19:35:16 +09:00
benebsiny
e18c002283
Deduplicate the initialization of editor mode
2024-08-08 18:07:52 +08:00
Tyler McGoffin
40ccd2ef92
Merge pull request #9435 from cli/add-AC-to-triage-reqs
...
Add Acceptance Criteria requirement to triage.md for accepted issues
2024-08-07 14:55:19 -07:00
Tyler McGoffin
fa06623f9b
Update docs/triage.md
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-08-07 11:46:22 -07:00
Tyler McGoffin
c5ea30da47
Add Acceptance Criteria requirement to triage.md for accepted issues
...
To better facilitate community collaboration and to help reduce the amount
of information any collaborator needs to peruse in a given issue,
clear Acceptance Criteria on accepted issues should be included. This will
reduce the amount of back and forth on PRs submitted by ensuring
expectations for a given issue are clear
2024-08-07 11:01:09 -07:00
benebsiny
e2275d7ef6
Add pr create --editor
2024-08-07 23:14:15 +08:00
dependabot[bot]
8356df0188
build(deps): bump github.com/google/go-containerregistry
...
Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry ) from 0.20.1 to 0.20.2.
- [Release notes](https://github.com/google/go-containerregistry/releases )
- [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml )
- [Commits](https://github.com/google/go-containerregistry/compare/v0.20.1...v0.20.2 )
---
updated-dependencies:
- dependency-name: github.com/google/go-containerregistry
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-07 14:25:20 +00:00
Andy Feller
86964d8809
Merge pull request #9407 from muzimuzhi/tab-indents
...
Unify use of tab indent in non-test source files
2024-08-06 13:18:24 -04:00
Andy Feller
000b2f95e0
Merge branch 'trunk' into tab-indents
2024-08-06 13:08:48 -04:00
Andy Feller
983e13c623
Merge pull request #9400 from cli/dependabot/github_actions/actions/attest-build-provenance-1.4.0
...
build(deps): bump actions/attest-build-provenance from 1.3.3 to 1.4.0
2024-08-06 13:07:36 -04:00
Andy Feller
626bbf010a
Merge pull request #9411 from cli/andyfeller/cli-9274-gh-variable-get-ghes
...
Update `gh variable get` to use repo host
2024-08-06 10:03:00 -04:00
Andy Feller
c088951944
Fix host handling in variable and secret delete
...
This change updates `gh variable delete` and `gh secret delete` to use the host associated with the repository rather than the default host. Along with these changes is minor refactoring of the tests to ensure appropriate Dotcom vs GHES targeting works as expected.
Minor edit to `gh variable get` testing to simplify some conditional logic in test setup.
2024-08-02 15:11:22 -04:00
Yukai Chou
d7b8ecf33d
Unify use of tab indent in non-test source files
...
Found with
rg '(^ | \t|\t )' -g '*.go' -g '!*_test.go'
Mixed indent exceptions:
- wrapped long list items with extra 2-space indent
- code snippets using space indent
- commented code lines having "\t*// \t+" prefix
2024-08-03 00:35:30 +08:00
Andy Feller
22a5a4c899
Update gh variable get to use repo host
...
Closes #9274
This change addresses a bug where repository and repository environment variables are not being retrieved from the appropriate host, causing GHES users to fail without specifying `GH_HOST` to force `gh variable set` to do the right thing.
In addition, the tests for this command have been updated to check both github.com and GHES variations to ensure this works.
2024-08-02 10:36:32 -04:00
Eugene
89cbcfe7eb
Merge pull request #9392 from cli/eugene/gh-attestation-case-insensitivity
...
handle attest case insensitivity
2024-07-31 15:19:49 -07:00
dependabot[bot]
ad96ad3580
build(deps): bump actions/attest-build-provenance from 1.3.3 to 1.4.0
...
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance ) from 1.3.3 to 1.4.0.
- [Release notes](https://github.com/actions/attest-build-provenance/releases )
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md )
- [Commits](5e9cb68e95...210c191353
2024-07-31 14:55:39 +00:00
ejahnGithub
87ff22d37d
Merge branch 'tmp-07-31' into eugene/gh-attestation-case-insensitivity
2024-07-31 07:31:58 -07:00
ejahnGithub
1eaf712dd1
update test and remove logic to check SourceRepositoryOwnerURI is empty string
2024-07-31 07:29:43 -07:00
Eugene
12715fdcc6
Merge branch 'trunk' into eugene/gh-attestation-case-insensitivity
2024-07-30 14:07:09 -07:00
ejahnGithub
596ee8bd71
update test
2024-07-30 13:22:49 -07:00
ejahnGithub
580ddf6997
minor fix
2024-07-30 13:14:16 -07:00
