Kynan Ware
861563269a
Merge branch 'trunk' into kw/first-pass-accessible-prompter
2025-04-09 08:07:56 -06:00
Meredith Lancaster
7b20ee5549
Merge pull request #10749 from malancas/update-to-sigstore-go-v0.7.1
...
Update github.com/sigstore/sigstore-go to 0.7.1 and fix breaking function change
2025-04-09 11:58:20 +02:00
Andy Feller
47225bcf56
Merge pull request #10737 from cli/andyfeller/muted-text-part2-github-cli-833
...
Ensure muted text is thematic and customizable
2025-04-08 16:59:36 -04:00
Andy Feller
6dd8f809b1
Merge pull request #10720 from cli/andyfeler/colorize-label-optin
...
Introduce configuration setting for displaying issue and pull request labels in rich truecolor
2025-04-08 16:44:25 -04:00
Andy Feller
93e51c583b
Update pkg/cmd/run/shared/presentation.go
2025-04-08 16:40:39 -04:00
Andy Feller
644dbe6275
Apply suggestions from code review
...
Co-authored-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2025-04-08 15:56:23 -04:00
Andy Feller
5c12f5633e
Test for explicit config disable of label colors
2025-04-08 15:27:36 -04:00
Andy Feller
c5206109ca
Use truthy value for GH_COLOR_LABELS
2025-04-08 15:24:18 -04:00
Kynan Ware
d230b08c43
test(prompter): re-add skipped test for accessible confirm default
2025-04-08 13:09:15 -06:00
Kynan Ware
fa03157beb
doc(help): label GH_ACCESSIBLE_PROMPTER as preview
2025-04-08 13:04:04 -06:00
Kynan Ware
19387b8418
fix(prompter): rename GH_ACCESSIBLE_PROMPTER
2025-04-08 12:52:39 -06:00
Kynan Ware
9cf341302e
refactor(prompter): explicit return values
2025-04-08 12:03:55 -06:00
Kynan Ware
8821f77fbb
doc(prompter): remove senseless comment
2025-04-08 12:00:02 -06:00
Kynan Ware
c4be95afd9
refactor(prompter): remove unused variable
2025-04-08 11:58:50 -06:00
Kynan Ware
ef58e627f9
test(prompter): timeout for tests is 1s
2025-04-08 11:44:14 -06:00
Kynan Ware
d8d3874778
fix(prompter): use os.lookupenv for accessible prompter
2025-04-08 11:38:54 -06:00
Kynan Ware
fb80b5bd86
test(prompter): remove needless NO_COLOR set
2025-04-07 14:56:33 -06:00
Kynan Ware
c5ffb3cbfe
test: use example.com in tests
2025-04-07 14:54:41 -06:00
Kynan Ware
66407402c0
doc: comment typos and formatting
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-07 14:53:31 -06:00
Kynan Ware
0543aac53c
test(prompter): add basic survey prompter test
2025-04-07 12:54:03 -06:00
Kynan Ware
2a851e33e8
test(prompter): fix race conditions
2025-04-07 11:59:05 -06:00
Kynan Ware
5996f882fc
doc(envs): speech synthesis prompter
2025-04-07 10:40:29 -06:00
Kynan Ware
ca00061a53
Merge pull request #10731 from cli/kw/gh-cli-868-pin-actions-to-sha
...
Pin third party actions to commit sha
2025-04-07 09:28:35 -06:00
Andy Feller
918cafc222
Deprecate ColorScheme.Gray for ColorScheme.Muted
...
This commit converts all of the places using ColorScheme.Gray and ColorScheme.Grayf to Muted and Mutedf.
There is a little extra tidying up with local variable names or converting code to use Mutedf format.
2025-04-06 10:18:48 -04:00
Kynan Ware
e21243fe9b
ci: pin third party actions to commit sha
2025-04-04 21:45:54 -06:00
Kynan Ware
f89700160b
doc(prompter): clarify comments
2025-04-04 15:08:17 -06:00
Kynan Ware
0b49522467
refactor(prompter): less magic strings
2025-04-04 15:07:21 -06:00
Kynan Ware
2e48cadf58
fix(prompter): remove impossible condition
2025-04-04 15:05:23 -06:00
Kynan Ware
5c39e0bd10
fix(prompter): notes about Confirm default
2025-04-04 14:52:25 -06:00
Kynan Ware
4cf048a8d1
fix(prompter): input returns default when blank
2025-04-04 11:33:10 -06:00
Kynan Ware
5b0d49c6ec
test(prompter): more tests for bad input
2025-04-04 11:06:40 -06:00
Andy Feller
e067eacd81
Refactor ColorScheme initializer
...
This commit completely removes the iostreams.NewColorScheme() initializer function in favor of exporting the type fields for greater clarity in its use.
The result being code specifying only the fields that matter to test cases.
2025-04-04 11:57:37 -04:00
Andy Feller
addbc6ac5c
Add label color env var to help topic, unused fix
...
This commit adds the new environment variable to the `gh environment` help topic.
Additionally, there is a small fix for Go linter for an unused variable raised as a problem.
2025-04-04 11:02:44 -04:00
Andy Feller
e9a12853cb
Merge branch 'trunk' into andyfeler/colorize-label-optin
2025-04-04 09:47:41 -04:00
Kynan Ware
a30df14b6a
refactor(prompter): rename env var for speech synthesizer friendly prompter
2025-04-03 13:08:16 -06:00
Kynan Ware
49ddacf5b8
docs(prompter): doc prompter interface
2025-04-03 13:06:31 -06:00
Kynan Ware
02fc12e7b7
fix(linter): linter errors
2025-04-03 08:51:54 -06:00
Kynan Ware
88e6285b49
test(prompter): move to external package
2025-04-03 08:45:58 -06:00
Kynan Ware
8827803bd1
test(prompter): skip vt10x tests on Windows
2025-04-03 08:25:33 -06:00
Andy Feller
5f03c208a1
Fix comment language
2025-04-02 18:32:37 -04:00
Andy Feller
3eca268a7f
Introduce color_labels support, update commands
...
This commit implements the actual changes around configuration setting / environment variable logic for displaying labels using their RGB hex color code in terminals with truecolor support.
One of the subtler changes in this commit is renaming generic ColorScheme.HexToRGB logic to render truecolor to ColorScheme.Label as this feature was being used exclusively for labels. This is due to confusion about introducing the new `color_labels` config on top of generic coloring logic.
2025-04-02 18:24:20 -04:00
Andy Feller
b52c131d4c
Merge pull request #10709 from cli/andyfeller/table-datetime-contrast-github-cli-832
...
Ensure table datetime columns have thematic, customizable muted text
2025-04-02 17:20:15 -04:00
Kynan Ware
e299b56c0f
test(prompter): remove needless variable declaration
2025-04-02 13:08:36 -06:00
Kynan Ware
e42af35839
tests(prompter): rename huhprompter
2025-04-02 13:00:46 -06:00
Kynan Ware
0d7fd36f11
test(prompter): replace assert with require
2025-04-02 12:58:44 -06:00
Kynan Ware
94bbd26aab
fix(prompter): rename huhprompter
2025-04-02 12:56:44 -06:00
Kynan Ware
f7de9e0c11
test(prompter): go-expect based prompter tests
2025-04-02 12:56:44 -06:00
Kynan Ware
88a98ea63a
feat(prompter): include no as false-y value
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-02 11:58:10 -06:00
William Martin
bab2bc8172
Acceptance test issue/pr create/edit with project ( #10707 )
2025-04-02 14:50:10 +02:00
Kynan Ware
92b1a8e0f0
test(prompter): remove t.parallel calls
...
t.Parallel() cannot be used when env vars are being set.
2025-03-31 16:01:16 -06:00
