Commit graph

1965 commits

Author SHA1 Message Date
Mislav Marohnić
8626befd3f Merge remote-tracking branch 'origin' into webInList 2020-07-16 14:51:34 +02:00
Mislav Marohnić
4b87f5b18a
Merge pull request #1367 from cli/fix-internal-alias
fix variable shadowing
2020-07-16 14:46:40 +02:00
Mislav Marohnić
b0fede93c9
Merge pull request #1365 from cli/pr-checkout-fixes
pr checkout fixes for branch names
2020-07-16 14:31:04 +02:00
Mislav Marohnić
067d05a030
Merge pull request #1366 from cli/template-naming
Improve support for legacy issue/PR template names
2020-07-16 14:30:25 +02:00
Mislav Marohnić
68b347cffc
Merge pull request #1362 from cli/triage-releasing-tweaks
Expand our releasing, triage docs
2020-07-16 14:28:55 +02:00
vilmibm
3f5893bcb4 fix variable shadowing 2020-07-15 12:36:45 -05:00
Nate Smith
619ef43f76
Merge pull request #1191 from cli/shell-alias
shell aliases
2020-07-15 12:24:36 -05:00
vilmibm
86912b31b2 stub sh lookup 2020-07-15 12:17:36 -05:00
vilmibm
cf3af450eb minor docs 2020-07-15 11:40:35 -05:00
vilmibm
cfb8eebf30 quietly return exit code of external command 2020-07-15 11:39:48 -05:00
vilmibm
acaaa28fd7 helper function for finding sh 2020-07-15 11:30:20 -05:00
Mislav Marohnić
07bee6a63c Improve support for legacy issue/PR template names
Now supports names such as `PULL-REQUEST-TEMPLATE` (dashes instead of
underscores) and `issue_template.txt` (any file extension, including no
extension), is valid.
2020-07-15 18:16:16 +02:00
Mislav Marohnić
dfb774cd38 Verify HTTP stubs in pr checkout tests 2020-07-15 16:18:36 +02:00
Mislav Marohnić
c232c8872c Abort pr checkout when PR has an invalid head branch name 2020-07-15 16:16:38 +02:00
Mislav Marohnić
305cd290ee Fix pr checkout <owner>:<branch> when it matches the default branch
First, consolidate the functionality between `pr merge` and `pr
checkout` that resolves the default branch name of the base repo. With
an added bonus, the new approach avoids an API request when one isn't
necessary.

Then, ensure that checking out 3rd-party PRs will result in local branch
name such as `<owner>/<branch>` when the head branch of the repository
matches the default branch of the base repository. We already have had
code in place to take care of this, but it only took effect in the `pr
checkout <number>`-style invocation.
2020-07-15 15:35:42 +02:00
Mislav Marohnić
6825944cad Reference named queries in pr checkout HTTP stubs 2020-07-15 14:54:30 +02:00
Mislav Marohnić
ee928a14a5 Add more notes to our releasing docs 2020-07-15 14:17:00 +02:00
Mislav Marohnić
e886df594b Add a note about help-wanted in triage docs 2020-07-15 14:12:57 +02:00
Mislav Marohnić
c8cf54c10c
Merge pull request #1258 from cli/ghe-remotes
Parse and respect non-github.com git remotes
2020-07-15 13:07:30 +02:00
Mislav Marohnić
6e9fab68c8
Merge pull request #1359 from cli/scopes-admin
Improvements to checking OAuth scopes
2020-07-15 13:05:27 +02:00
vilmibm
a9d93f8c57 correct docs 2020-07-14 19:42:05 -05:00
nate smith
4bd0435c38 successfully use sh for windows aliases 2020-07-14 16:19:01 -05:00
vilmibm
f99b54a731 WIP: experimental bash support for windows 2020-07-14 16:13:00 -05:00
vilmibm
bbd756a99f split shell alias execution into new function 2020-07-14 16:13:00 -05:00
nate smith
c3a5384895 add experimental powershell support for shell aliases 2020-07-14 16:12:51 -05:00
vilmibm
3a9167cfe4 Implement shell aliases
This command adds --shell to `gh alias set`, allowing specified aliases
to be run through a shell interpreter.
2020-07-14 16:12:07 -05:00
Nate Smith
2b96d2ce1f
Merge pull request #1343 from cli/improve-issue
issue scriptability improvements
2020-07-14 12:45:03 -05:00
vilmibm
754dcb744c catch up to trunk 2020-07-14 12:36:54 -05:00
vilmibm
97107661fe review feedback 2020-07-14 12:30:53 -05:00
vilmibm
36ade42ba3 scriptability improvements: issue commands
This commit is part of work to make gh more scriptable. It includes both
some general purpose helpers towards this goal as well as improvements
to the issue commands. Other commands will follow.

- Adds `utils/terminal.go` for finding out about gh's execution environment
- introduces `stubTerminal` for either faking being attached to a tty or not during tests
- updates issue commands to behave better when not attached to a tty:
  - issue list doesn't print fuzzy dates
  - issue list doesn't print header
  - issue list prints state explicitly
  - issue create no longer hangs
  - issue create fails with clear error unless both -t and -b are specified
  - issue view prints raw issue body
  - issue view prints metadata in a consistent, linewise format
2020-07-14 12:30:53 -05:00
AliabbasMerchant
4304b9e3eb filterOptions struct for pr & issue list 2020-07-14 10:26:32 +05:30
AliabbasMerchant
73552ae75c Merge 'trunk' in webInList 2020-07-14 08:53:39 +05:30
Mislav Marohnić
28cd348176 Only check OAuth scopes when X-Oauth-Scopes header is present 2020-07-13 15:53:53 +02:00
Mislav Marohnić
55d31303ea Have admin:org scope satisfy read:org requirement
`admin:org` is inclusive of `read:org`, so if we find the former listed
in response headers, we can conclude that the token has necessary scopes
instead of letting a warning notice be shown.
2020-07-13 15:35:14 +02:00
Mislav Marohnić
87a9dc8d4b Merge remote-tracking branch 'origin' into ghe-remotes 2020-07-13 13:39:14 +02:00
Mislav Marohnić
53ff3842e7
Merge pull request #1335 from cli/query-names
Add names to all our GraphQL queries
2020-07-13 13:36:27 +02:00
Mislav Marohnić
7a289861d2 Name more queries in test stubs 2020-07-10 20:20:33 +02:00
Mislav Marohnić
13b9c98b2b Match named queries in test stubs 2020-07-10 20:04:54 +02:00
Mislav Marohnić
d96e88c223 Rename IssueCreate mutation
This follows the "NounVerb" convention we got going on
2020-07-10 18:08:16 +02:00
Mislav Marohnić
8c50745431 Merge remote-tracking branch 'origin' into query-names 2020-07-10 17:24:53 +02:00
Shubhankar Kanchan Gupta
1ddb4d76a7
Strip carriage returns in markdown rendering (#1351) 2020-07-10 16:01:15 +02:00
Mislav Marohnić
659a474a13
Merge pull request #1334 from cli/make-ldflags
Fix version and OAuth client information being injected via `make`
2020-07-10 14:00:34 +02:00
Mislav Marohnić
909aff827c Use makefile append operator 2020-07-10 13:41:55 +02:00
Mislav Marohnić
b30cf15094
Merge pull request #1295 from cli/path-error
Raise more informative path error when reading config file
2020-07-10 13:25:34 +02:00
Nate Smith
17c4eeea1d
Merge pull request #1337 from sibis/fix-1324
Show title while closing/reopening issue and merging PR
2020-07-08 10:10:19 -05:00
Sibi
2491e98c41 Title of the PR will be shown while closing, merging and re-opening & test cases updated 2020-07-08 12:22:38 +05:30
Sibi
125547fb7b Show title while closing/reopening issue and meriging PR 2020-07-08 01:25:19 +05:30
Mislav Marohnić
fbf425f048 go mod tidy 2020-07-07 17:57:52 +02:00
Mislav Marohnić
f4c4ce0b0a Add names to GraphQL queries made over shurcooL adapter 2020-07-07 17:53:40 +02:00
Mislav Marohnić
a7806a3e78 Add names to queries made over our homegrown GraphQL adapter 2020-07-07 17:53:40 +02:00