nilvng
874fa7ad4d
feat: add test
2024-11-07 10:20:23 +11:00
nilvng
a780b488a3
fix: ignore template flag
2024-11-07 10:20:23 +11:00
Kynan Ware
30066b0042
Merge pull request #9844 from its-miroma/dnf5
...
Set `dnf5` commands as default
2024-10-31 09:42:14 -06:00
Meredith Lancaster
1652051fc2
Merge pull request #9825 from malancas/verify-provenance-predicate-by-default
...
`gh attestation verify` should only verify provenance attestations by default
2024-10-30 15:45:18 -06:00
Meredith Lancaster
bb5136007e
Merge pull request #9838 from malancas/attestation-clean-up-tests
...
Clean up skipped online tests for `gh attestation verify`
2024-10-30 13:28:44 -06:00
Andy Feller
3b4301f62a
Merge pull request #9845 from cli/andyfeller/9807-repo-edit-visibility-confirmation
...
Require visibility confirmation in `gh repo edit`
2024-10-30 15:20:51 -04:00
Andy Feller
3f5fc85e41
Assert stderr for gh repo edit visibility tests
2024-10-30 13:31:00 -04:00
Meredith Lancaster
384057c2e2
bold all flags in docs
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-29 11:54:42 -06:00
Meredith Lancaster
271450883e
Update pkg/cmd/attestation/verify/verify.go
...
Co-authored-by: Phill MV <phillmv@github.com>
2024-10-29 11:53:28 -06:00
Andy Feller
15b2db9277
Require visibility confirmation in gh repo edit
...
This commit modifies interactive and non-interactive behaviors around `gh repo edit` as well as providing greater information about the impact.
1. `--help` usage is expanded to highlight the most significant consequences of changing visibility
1. `--help` usage and interactive experience call out GitHub Docs content that act as source of truth about full consequences of various changes
1. `gh repo edit` interactive experience will require confirmation for any visibility change
1. `gh repo edit` interactive experience will output potential stars and watchers lose regardless of visibility transition
1. `gh repo edit` will require `--visibility` flag to include new `--accept-visibility-change-consequences` flag regardless of interactivity
2024-10-29 10:25:04 -04:00
Meredith Lancaster
15d7e33ddb
update references
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-29 07:11:51 -06:00
Meredith Lancaster
7bfddec046
fix references
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-29 07:09:45 -06:00
Meredith Lancaster
efa6fafc47
Update pkg/cmd/attestation/verification/attestation.go
...
Co-authored-by: Phill MV <phillmv@github.com>
2024-10-29 07:06:23 -06:00
Miroma
a3f353d2f7
Set dnf5 commands as default
...
Fedora 41 is now stable! 🎉
Closes #9840
Co-authored-by: Melamit64 <151834564+melamit@users.noreply.github.com>
2024-10-29 09:52:03 +01:00
Meredith Lancaster
7598c4a58f
organize
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-28 15:38:06 -06:00
Meredith Lancaster
f8f3502cac
doc updates
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-28 15:37:58 -06:00
Meredith Lancaster
8a8f224a7a
fix test
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-28 15:28:00 -06:00
Meredith Lancaster
4ec696dacd
create common test fixture, organize tests
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-28 13:40:48 -06:00
Meredith Lancaster
502856082e
table tests
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-28 13:40:23 -06:00
Meredith Lancaster
f8b0f5e687
clean up test
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-28 13:02:12 -06:00
Meredith Lancaster
ce5bde4379
simplify signer workflow validation tests
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-28 12:59:04 -06:00
Meredith Lancaster
a820457b09
clean up skipped online tests
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-28 11:47:31 -06:00
William Martin
14d339d9ba
Merge pull request #9810 from cli/andyfeller/testscript-extension
...
Add comprehensive testscript for gh ext commandset
2024-10-28 13:05:32 +01:00
Andy Feller
37da12a9d2
Rename similar to other coarse commandset tests
...
Based on insights gained from reviewing conventions in #9815 with @jtmcg, I'm renaming this testscript to keep consistent with `gpg-key`, `label`, `ssh-key`, etc.
2024-10-28 12:54:50 +01:00
Andy Feller
911f070936
Skip extension testscript if bash isn't available
...
As this testscript creates a Bash-based script extension, the testscript should be skipped if it isn't on the path and executable.
Ideally, we would refactor this test to isolate that portion of the tests OR switch to a Go-based extension that can be compiled and run everywhere.
2024-10-28 12:54:50 +01:00
Andy Feller
ed24477fd3
Add comprehensive testscript for gh ext commandset
...
Rather than multiple separate testscripts per `gh ext` subcommand, this commit adds a comprehensive test around `gh extension` commandset.
2024-10-28 12:54:47 +01:00
William Martin
7066cdeb26
Merge pull request #9815 from cli/andyfeller/testscripts-ruleset
...
Add comprehensive testscript for `gh ruleset`
2024-10-28 12:52:24 +01:00
Andy Feller
6dc86e5f40
Rename testscript for consistency
...
Similar to `gpg-key`, `label`, `ssh-key`, this coarse grained testscript should be named after the commandset given it isn't a collection of targeted scenarios.
2024-10-28 12:40:15 +01:00
Andy Feller
c27677bda6
Add comprehensive testscript for gh ruleset
2024-10-28 12:40:12 +01:00
William Martin
f35c123b71
Merge pull request #9816 from cli/jtmcg/testscripts-project
...
Add acceptance test for `project` command
2024-10-28 12:24:53 +01:00
Meredith Lancaster
9ddaf13ef5
add predicate type to integration tests
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-25 15:32:16 -06:00
Meredith Lancaster
cef335c698
update tests to include predicate type
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-25 15:26:32 -06:00
Meredith Lancaster
28fa42a324
message formatting
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-25 15:00:11 -06:00
Meredith Lancaster
fa6536493f
predicate-type is no longer empty
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-25 14:54:52 -06:00
Meredith Lancaster
84f326542f
Merge branch 'verify-provenance-predicate-by-default' of github.com:malancas/cli into verify-provenance-predicate-by-default
2024-10-25 14:04:59 -06:00
Meredith Lancaster
e8013c0778
update documentation to indclude predicate-type information
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-25 14:04:54 -06:00
Meredith Lancaster
c552224081
Merge branch 'trunk' into verify-provenance-predicate-by-default
2024-10-25 13:58:20 -06:00
William Martin
a381ca5dc4
Merge pull request #9821 from cli/hard-fork-go-internal
...
Update testscript to use hard fork
2024-10-25 18:21:52 +02:00
Tyler McGoffin
7a5dc50324
Modify script to use the project number returned by the api upon creation
2024-10-25 09:03:50 -07:00
William Martin
30d9fc53d1
Update testscript to use hard fork
2024-10-25 16:29:23 +02:00
Tyler McGoffin
7148304344
Add acceptance test for project-create and project-delete
2024-10-24 12:53:52 -07:00
Tyler McGoffin
8b5c5385c7
Add TestProject to acceptance_test.go
2024-10-24 12:18:56 -07:00
Meredith Lancaster
4d57c79770
set provenance predicate type as default for predicate-type flag
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-24 11:40:55 -06:00
Tyler McGoffin
31e8a87598
Alphabetize test functions
...
While swarming on this, I've encountered many merge conflicts based on
where folks have introduced new test functions. Alphabetizing them should
reduce the number of merge conflicts we encounter while introducing more
of these tests moving forward
2024-10-24 10:01:39 -07:00
Kynan Ware
44ee177607
Merge pull request #9813 from cli/wm/update-acceptance-test-redaction
...
Note token redaction in Acceptance test README
2024-10-24 10:47:44 -06:00
William Martin
2a2adfed0f
Merge pull request #9787 from cli/jtmcg/testscripts-auth
...
Add acceptance tests for `gh auth` commands
2024-10-24 18:42:31 +02:00
William Martin
366aea95eb
Note token redaction in Acceptance test README
2024-10-24 18:35:30 +02:00
William Martin
0880dc4d79
Merge pull request #9812 from cli/wm-kw/ssh-key-and-org-testscripts.txtar
...
Add acceptance tests for `org` and `ssh-key` commands
2024-10-24 18:30:47 +02:00
bagtoad
f72a82db99
Refactor gpg-key delete to align with ssh-key delete
2024-10-24 09:59:02 -06:00
bagtoad
2f849f03ff
Add acceptance tests for org command
2024-10-24 09:58:06 -06:00