William Martin
8e89af96e8
Write tests for SwitchUser
2023-12-06 14:06:28 +01:00
William Martin
a0e5e4c709
Use NewIsolatedTestConfig in AuthConfig tests
2023-12-06 14:06:28 +01:00
Sam Coe
760dc91faa
Include environment variable users in auth status output
2023-12-06 14:06:28 +01:00
William Martin
b2997cc7bd
Handle multi account golden path in auth status
2023-12-06 14:06:28 +01:00
William Martin
e4ed4041cd
Use auth config and only print stdout in status
2023-12-06 14:06:28 +01:00
William Martin
5d10beb60a
Use config to look up user for status
2023-12-06 14:06:28 +01:00
William Martin
08c7bd1df2
Use real config and login in status tests
2023-12-06 14:06:28 +01:00
Sam Coe
eca5f72328
UX polish and standardization of language
2023-12-06 14:06:28 +01:00
William Martin
98381e63c9
Refactor switch test to be more structural
2023-12-06 14:06:28 +01:00
William Martin
7667fbdb5a
Handle logout having no candidates
2023-12-06 14:06:28 +01:00
William Martin
df274d4f3a
Implement auth switch
2023-12-06 14:06:28 +01:00
Sam Coe
2fc6dbd851
Add user flag to auth logout command
2023-12-06 14:06:28 +01:00
William Martin
72d5550407
Implemented auth logout for multiaccount
2023-12-06 14:06:28 +01:00
William Martin
1bf6023164
Display message when logging into existing account
2023-12-06 14:06:28 +01:00
William Martin
a9acece7dd
Split Login into adding a user and switching
...
It makes clear the steps that should be needed to "switch" which should be
shared between Login (add user and switch to it), Logout (remove user and switch
to another), and Switch (no modification and switch to a user)
2023-12-06 14:06:28 +01:00
William Martin
c4fcf9ba1a
Add test to ensure login command allows multiple users
2023-12-06 14:06:28 +01:00
William Martin
209aed30b4
Fix typo on migration comment
2023-12-06 14:06:28 +01:00
William Martin
a00294eff9
Fix double negatives in migration errors
2023-12-06 14:06:28 +01:00
William Martin
06c36a74c2
Remove host entries without valid tokens during migration
2023-12-06 14:06:28 +01:00
Sam Coe
4f33d88c5f
Set user level config values automatically when setting host level config values
2023-12-06 14:06:28 +01:00
Sam Coe
38b73e3f85
Set host level git_protocol on login
2023-12-06 14:06:28 +01:00
Sam Coe
eb771aecc9
Address PR comments
2023-12-06 14:06:28 +01:00
Sam Coe
d2ff55737c
Enable multi-account migration
2023-12-06 14:06:28 +01:00
Sam Coe
68e30beac4
Logout removes token from keyring using username
2023-12-06 14:06:28 +01:00
Sam Coe
2ca8b1ea94
Login sets token in keyring using username
2023-12-06 14:06:28 +01:00
Sam Coe
d8084f5f6d
Hide all keyring package implementation inside internal keyring package
2023-12-06 14:06:28 +01:00
Sam Coe
e0ebbc9e88
Add auth token migration to multi account migration
2023-12-06 14:06:28 +01:00
William Martin
9efa7248a9
Initial multi-account migration work
2023-12-06 14:06:28 +01:00
Andy Feller
cd2a6ad6dc
Merge pull request #8420 from cli/andyfeller/triage-the-final-enhancements
...
andyfeller/triage the final enhancements
2023-12-05 09:00:16 -05:00
Andy Feller
8302a293d0
Fix triage workflow, restore PR support
...
This commit reverts the triage workflow to restore the previous PR support using the `pull_request_target`, which is more secure as it doesn't allow fork repositories to change the workflow before it runs.
Additionally, this fixes an issue currently causing the workflow to break as cli/cli uses the `discuss` label but github/cli uses the `triage` label.
2023-12-05 08:46:45 -05:00
Andy Feller
bdfdc42624
Revert "Update triage.yml"
...
This reverts commit 3be9a0ed85 .
2023-12-05 08:33:00 -05:00
Zach Steindler
6eb650185b
Add progress indicator when installing an extension ( #8411 )
2023-12-04 19:52:11 +00:00
Sam Coe
08fb744229
Simplify git AddRemote to remove unused arg ( #8392 )
2023-12-04 15:48:08 -04:00
Andy Feller
fe390533c8
Merge pull request #8412 from cli/andyfeller/triage-patch
...
Simplify triage workflow given GitHub Actions limitations on OSS pull requests
2023-12-04 14:06:46 -05:00
Andy Feller
3be9a0ed85
Update triage.yml
2023-12-04 13:54:16 -05:00
Andy Feller
b215d03e7b
Merge pull request #8394 from cli/andyfeller/triage-enhancements
...
Enhance discussion triage workflow
2023-12-01 13:59:25 -05:00
Andy Feller
c7c74dd422
Merge pull request #8342 from muzimuzhi/docs/unify-markup
...
Unify doc mark-ups
2023-12-01 09:31:36 -05:00
Andy Feller
152ab207b5
For lint sake
2023-12-01 09:20:44 -05:00
Andy Feller
a9e430e9bc
Fix lint warning
2023-12-01 09:16:51 -05:00
Andy Feller
b77de0d458
Additional formatting changes
...
- gh help actions
- highlight 3 commands to run for more information
- gh extension
- wrapping url for online linking
- fix install subcommand missing backtick formatting
- gh release create
- fixing mixed indenting causing usage misalignment
- root help
- backtick wrap help command for more info for consistency
- gh help environment
- backtick wrap missed OWNER/REPO
- gh variable
- brought consistency to output when deleting or setting variable
2023-12-01 09:08:51 -05:00
Andy Feller
a6196994b5
Merge pull request #8381 from ffalor/prmerge
...
print info about merge when interactive
2023-12-01 08:43:37 -05:00
Andy Feller
8ab2f50e3e
Merge branch 'trunk' into prmerge
2023-12-01 08:00:31 -05:00
Andy Feller
109766fe14
Correcting label and language
...
- replacing triage for discuss
2023-11-30 23:09:46 -05:00
Andy Feller
a7753a9809
Refactor triage workflow
...
- replaces creating discussions for issues
- supports discussing both issues and pull requests
- populates more information about related issues and pull requests in triage issues
2023-11-30 23:00:30 -05:00
ffalor
74e5e84d71
Update pkg/cmd/pr/merge/merge.go
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2023-11-30 18:51:09 -06:00
nelsonchen304
3bb62d4724
Actions: filter to workflow runs for a specific commit ( #8350 )
2023-11-29 09:29:26 +00:00
Mika
2f31607096
Add timeout error in gh auth status ( #8337 )
2023-11-29 08:54:55 +00:00
David Gardiner
36bbcdd663
Merge pull request #8361 from mateusmarquezini/fix/issue_8356
...
Added a new error handling when the display name flag exceeds 48 characters
2023-11-28 12:03:32 -08:00
Mateus Marquezini
1d13d1fbed
Merge branch 'trunk' into fix/issue_8356
2023-11-28 16:29:24 -03:00
Mateus Marquezini
7a32b8b5f3
some code improvements after code review
2023-11-27 17:17:24 -03:00