David Gardiner
93f033fe87
Address comments
2022-09-27 16:01:10 -07:00
David Gardiner
b0eb1b379a
Implement gRPC client
2022-09-27 11:34:30 -07:00
Mislav Marohnić
a6636994bf
Disable flakey ports update visibility tests ( #6203 )
2022-09-06 15:31:36 +00:00
casswedson
00bc550dc6
chore: typo hunting ft. codespell
2022-07-09 21:41:09 -05:00
Caleb Brose
83153fe9e5
Cleanups from PR comments
2022-06-14 14:33:41 +00:00
Caleb Brose
b5580f9503
Refactor inferfaces from PR comments
2022-06-13 19:04:29 +00:00
cmbrose
eebef06c67
Merge main and use func options again
2022-06-07 12:27:29 -05:00
cmbrose
9095556372
Merge remote-tracking branch 'upstream/trunk' into jungaretti/no-ssh-keys
2022-06-07 12:07:03 -05:00
Greggory Rothmeier
f15a8ca335
Extract LiveshareSession interface ( #5725 )
...
This will make it possible to inject a mock liveshare session for testing
2022-06-06 15:52:52 +02:00
cmbrose
f67ca53c07
Refactor ssh_keys to a more common location
2022-06-03 13:39:52 -05:00
JP Ungaretti
a1629c70c0
Generate codespaces key
2022-05-31 17:19:16 -07:00
cmbrose
ac630880c6
Refactor to WithOptions
2022-05-31 15:52:16 -05:00
JP Ungaretti
76090a2ea7
Add key to RPC call
2022-05-26 21:45:20 +00:00
JP Ungaretti
f21faca03e
Resolve feedback
2022-04-21 14:56:55 -07:00
JP Ungaretti
e8e9b58670
Clean up errors
2022-04-14 16:12:44 -05:00
JP Ungaretti
eaf8f84baf
Merge branch 'trunk' into add-cs-jupyter
2022-04-14 15:27:40 -05:00
JP Ungaretti
33a1b95dbf
Fix name of RPC service
2022-04-14 14:55:29 -05:00
Jose Garcia
b5a7a36ece
Document why we have a loop retrying
2022-03-21 12:11:00 -04:00
Jose Garcia
cd6176d911
Rename to tries and clean up loop condition
2022-03-21 11:42:32 -04:00
Jose Garcia
74c8b2217e
Increment retries
2022-03-21 11:36:12 -04:00
Jose Garcia
107ea6c440
Only sleep if conn is nil
2022-03-21 11:09:52 -04:00
Bernardo
c70e2a345e
allow 2 go routines to send
2022-03-16 20:34:51 +00:00
Bernardo
7d07249150
review suggestions
2022-03-15 18:22:32 +00:00
Bernardo
06f1f6eb52
add comments
2022-03-15 05:59:18 +00:00
Bernardo
2163c2312a
review suggestions
2022-03-15 05:50:18 +00:00
Jose Garcia
bc80675b6f
Remove unused types
2022-03-14 10:34:52 -04:00
Jose Garcia
ed376f3691
Pass conn to handlers instead of obj stream
2022-03-14 10:29:31 -04:00
Bernardo
ca7e2d386d
review suggestion: non-blocking send
2022-03-11 23:34:58 +00:00
Bernardo
a03e9d3c95
review suggestions
2022-03-11 22:53:01 +00:00
Bernardo
9b1a6607ce
review suggestion: deregister handle after receiving notification
2022-03-07 22:00:16 +00:00
Bernardo
9616706984
review suggestion
2022-03-04 22:30:50 +00:00
JP Ungaretti
3582090fb8
Fix RPC call
2022-03-03 01:21:35 +00:00
Bernardo
383a711902
fix linter error
2022-03-02 17:59:46 +00:00
Bernardo
347e7dc67b
delete unneeded comment
2022-03-02 01:22:05 +00:00
JP Ungaretti
9e3b955163
Add cs jupyter
2022-03-01 22:38:35 +00:00
Jose Garcia
35638cb82f
Update tests for serverSharing
2022-02-28 08:22:09 -05:00
Jose Garcia
2328ccb881
Abstract port notification logic into liveshare
2022-02-28 07:56:37 -05:00
Jose Garcia
3847d965da
Refactor port update data into liveshare
2022-02-25 08:09:12 -05:00
Jose Garcia
9556c72ecf
Update event types and drop idea of global request
2022-02-17 17:05:56 -05:00
Jose Garcia
ee349700de
Checkin almost final impl but wrong direction
2022-02-16 17:56:09 -05:00
Jose Garcia
c96807fae7
Clean up cruft
2022-02-15 15:34:04 -05:00
Jose Garcia
c90da9799d
Tests for update port visibility
2022-02-15 15:30:06 -05:00
Jose Garcia
04a4e43dec
Initial spike with request/event handling
2022-02-14 17:22:58 -05:00
Marwan Sulaiman
22c5269606
Fix flaky liveshare session test ( #5111 )
...
* Fix flaky liveshare session test
* typo
* PR comments
2022-01-27 11:20:50 -05:00
Jeff Hubbard
97d85d0ac0
Oops, left it as second from debugging
2021-10-28 16:33:13 -07:00
Jeff Hubbard
c18e54189c
Adds a timeout context to the ssh waiter to prevent indefinite hanging
2021-10-27 15:40:49 -07:00
Mislav Marohnić
d68126af99
Avoid macOS prompt to allow incoming connections in liveshare tests
...
Listening on the localhost interface disallows connections from the
outside anyway, so the OS firewall doesn't have to prompt whether the
user wants to allow incoming connections to the Go process.
2021-10-14 14:23:36 +02:00
Jose Garcia
d5c9630fae
Merge pull request #4511 from cli/jg/keepalive-fix
...
codespace ssh: fix for nil logger on non-debugging scenarios
2021-10-13 14:44:10 -04:00
Jose Garcia
d6b5157eff
Fix for nil logger on non-debugging scenarios
2021-10-13 14:15:26 -04:00
Marwan Sulaiman
b9bdef2b00
Add org scoped port forwarding + fix test formatting ( #4497 )
...
* Add org scoped port forwarding + fix test formatting
* Redesign port visibility
* Update pkg/cmd/codespace/ports.go
Co-authored-by: Jose Garcia <josebalius@github.com>
* Change sub command to privacy
* Example pr comment
* Fix test mock
* Fix test mock
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-10-13 13:56:03 -04:00
