Mislav Marohnić
683d847dd2
Merge remote-tracking branch 'origin' into cli-migration
2021-09-21 17:38:41 +02:00
Jose Garcia
8a53c4369e
Merge pull request #179 from github/jg/close-session
...
liveshare: close sessions
2021-09-21 10:14:22 -04:00
Jose Garcia
e8e914c220
PR Feedback
...
- Upgrade to go-liveshare v0.19.0
- Remove export helper method
- Use local implementation
2021-09-21 10:05:48 -04:00
Alan Donovan
0f88081bfa
Merge pull request #178 from github/check-authorized-keys
...
ghcs ssh: check user has authorised SSH keys
2021-09-21 10:03:45 -04:00
Alan Donovan
d3d1ce726d
do logs too
2021-09-21 10:02:55 -04:00
Jose Garcia
7f682f9c39
Close Live Share sessions
...
- New helper method codespaces.CloseSession to be used using defer
- Upgrade to go-liveshare v0.17.0
2021-09-20 16:56:57 -04:00
Mislav Marohnić
836075215d
Merge remote-tracking branch 'origin' into cli-migration
2021-09-20 13:59:32 +02:00
Jose Garcia
85f79ed8e8
Merge pull request #159 from github/jg/ssh-cmd-flags
...
ghcs ssh: ssh flags and command support
2021-09-20 07:43:16 -04:00
Mislav Marohnić
8c0c7a8e19
Make GITHUB_TOKEN configurable through Go member
...
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-09-17 16:29:35 +02:00
Mislav Marohnić
c2f3537a32
Separate "main" package from "ghcs" package
...
To make "ghcs" importable, this separates out the `main()` function into
its own package that lives under "cmd/ghcs/main". Typically the main
package would be called "cmd/ghcs", but we wanted to leave the current
ghcs implementation where it is to avoid causing conflicts with current
work in progress.
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-09-17 16:26:20 +02:00
Jose Garcia
42e47a98d7
add docs, simplify map, error on invalid args
2021-09-16 15:22:47 -04:00
Mislav Marohnić
dbb4e0c177
Merge remote-tracking branch 'origin' into ruleguard
2021-09-16 11:46:50 +02:00
Jose Garcia
45a9715e9f
Merge pull request #158 from github/jg/go-liveshare-0.16.0
...
upgrade to go-liveshare 0.16.0
2021-09-15 15:40:58 -04:00
Jose Garcia
b2234969e4
update logs
2021-09-15 15:40:07 -04:00
Alan Donovan
06719866c9
move api to internal/
2021-09-15 13:13:10 -04:00
Mislav Marohnić
fb5a35568c
Ensure original errors are wrapped with "%w" instead of "%v"
2021-09-15 13:58:41 +02:00
Jose Garcia
f5adc9e3a7
remove all deprecation messages and deprecated functionality
2021-09-13 10:58:00 -04:00
Alan Donovan
b96341a5f9
Merge branch 'main' into ask-tty
2021-09-09 12:01:55 -04:00
Alan Donovan
cbb8253544
consolidate survey functions
2021-09-09 11:57:37 -04:00
Mislav Marohnić
c89c14aff0
Merge remote-tracking branch 'origin' into jg/logs-flags
2021-09-09 12:55:32 +02:00
Jose Garcia
d8138c08b8
revert errgroup usage for ssh and logs
2021-09-08 14:56:16 -04:00
Jose Garcia
c86cd34f5e
switch to Errorln
2021-09-08 13:38:27 -04:00
Jose Garcia
efc6fd369c
merge upstream
2021-09-08 13:37:35 -04:00
Jose Garcia
b79ea871fd
rename arg
2021-09-03 16:04:00 -04:00
Alan Donovan
2c660fa2e5
avoid ListenTCP helper
2021-09-03 12:55:40 -04:00
Alan Donovan
43198b24aa
use errgroup
2021-09-03 12:50:11 -04:00
Jose Garcia
9193b03b69
introduce follow, deprecate tail
2021-09-03 12:40:01 -04:00
Jose Garcia
b1d83fe294
codespace flag, deprecate argument
2021-09-03 11:33:33 -04:00
Alan Donovan
a56a84947a
Update ghcs for go-liveshare@v0.12.0
2021-09-03 10:11:29 -04:00
Alan Donovan
981b2545bc
sketch of changes for https://github.com/github/go-liveshare/pull/13
2021-09-02 17:08:17 -04:00
Alan Donovan
4e2c20606a
Merge branch 'main' into join-session
2021-09-02 15:57:34 -04:00
Alan Donovan
cee761238b
update go-liveshare@v0.11.0
2021-09-02 15:54:00 -04:00
Alan Donovan
3485bacc97
fix StartSharing data race
2021-09-02 15:53:56 -04:00
Alan Donovan
8570f4111d
sketch after API changes in go-liveshare#11
2021-09-02 12:38:27 -04:00
Alan Donovan
65c19a3317
Merge pull request #107 from github/spelling-again
...
use correct correct spelling of codespace
2021-09-02 11:38:25 -04:00
Alan Donovan
72a2099a50
fix breakage from API changes
2021-09-01 17:50:24 -04:00
Alan Donovan
49ccdd3d21
use correct correct spelling of codespace
2021-09-01 17:26:26 -04:00
Alan Donovan
37b2f5e979
Merge branch 'main' into runcommand
2021-08-31 17:18:52 -04:00
Alan Donovan
f1c3a22a0b
Merge branch 'main' into product-spelling
2021-08-31 16:24:41 -04:00
Alan Donovan
c0aae52289
move port choice, and PortForwarder.Start call, into clients
2021-08-31 13:58:46 -04:00
Alan Donovan
bbcf2dd321
spell product names (Codespaces, Live Share) correctly
2021-08-31 11:15:26 -04:00
Alan Donovan
40317e91f8
cleanup to ssh api
2021-08-30 17:46:04 -04:00
Edmundo Gonzalez
903b7be7de
Comments from pr.
2021-08-30 21:01:13 +00:00
Edmundo Gonzalez
ee36a005b1
Merge remote-tracking branch 'origin/main' into edgonmsft/codespaces-ssh-rpc
2021-08-30 05:01:22 +00:00
Edmundo Gonzalez
5db9e2d83e
PR changes.
2021-08-30 04:48:56 +00:00
Jose Garcia
634796e8a8
merge main
2021-08-27 18:18:30 -04:00
Alan Donovan
38ff786a7d
cmd/ghcs: style tweaks
2021-08-27 12:03:20 -04:00
Edmundo Gonzalez
b6094e0006
Changes to point to RPC service.
2021-08-26 21:50:20 +00:00
Jose Garcia
55f0dad3db
merge upstream
2021-08-19 18:30:10 +00:00
Mislav Marohnić
517aae2805
Merge remote-tracking branch 'origin' into docs
2021-08-17 14:42:09 +02:00
