Kynan Ware
ec7c8ed844
test(pr edit): fix typo in test name
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-05-15 13:41:38 -06:00
Kynan Ware
f6bb1ca756
refactor(pr edit): move httpclient initialization
2025-05-15 13:40:23 -06:00
Kynan Ware
54f48cfe46
fix(pr edit): remove merge conflict artifact, extra detector
2025-05-15 09:48:44 -06:00
Kynan Ware
a03c9cec7b
Merge branch 'kw/gh-cli-epic-900-actors-are-assignable' into kw/gh-cli-909-911-assign-actors-to-prs
2025-05-15 09:42:39 -06:00
Kynan Ware
d72018d312
feat(pr edit): fetch assignable actors
2025-05-15 09:33:36 -06:00
Kynan Ware
f559068106
feat(pr edit): fetch assigned actors
2025-05-15 09:33:36 -06:00
Kynan Ware
6162a7c524
fix(api): correct var name capitalization
2025-05-15 09:33:36 -06:00
Kynan Ware
999ffbdfe7
Merge pull request #10960 from cli/kw/gh-cli-901-910-assign-actors-to-issues
...
`gh issue edit`: actors are assignable to issues
2025-05-15 09:24:32 -06:00
Kynan Ware
bcd47f1fb1
fix(api): correct var name capitalization
2025-05-15 09:13:46 -06:00
Kynan Ware
5dc854c75e
doc(issue edit): clarify synchronous handling of assignees
2025-05-14 11:50:11 -06:00
Kynan Ware
08cd1dc7db
feat(issue edit): replacing actor assignee is done synchronously with updateIssue
2025-05-14 11:43:29 -06:00
Kynan Ware
dfd600713f
refactor(api): rename assignable user types and methods
2025-05-14 08:53:47 -06:00
Kynan Ware
218152f7c5
fix(issue edit): resolve race condition in actor assignment
2025-05-09 23:26:06 -06:00
Kynan Ware
0efdfed068
feat(issue edit): support assigning actors to issues
2025-05-09 22:56:09 -06:00
Kynan Ware
ee9d169204
feat(issue edit): fetch assignable actors
2025-05-09 15:13:11 -06:00
William Martin
55cd3c34cd
Feature detect v1 projects on pr edit
2025-05-07 16:17:15 +02:00
William Martin
a2fcb9b2df
Merge pull request #10915 from cli/wm/projectsv1-deprecation-pr-create-rest
...
Feature detect v1 projects on interactive `pr create`
2025-05-06 15:24:04 +02:00
William Martin
4967a5edd5
Merge pull request #10911 from cli/wm/projectsv1-deprecation-pr-web
...
Feature detect v1 projects on web mode pr create
2025-05-06 14:19:15 +02:00
Kynan Ware
7b86830ade
Merge pull request #10729 from nopcoder/trunk
...
Fix panic on `gh pr view 0`
2025-05-02 09:47:48 -06:00
William Martin
1a5b7ca60c
Feature detect v1 projects for preview URL
...
As far as I can see, when there is project metadata, the preview option
will never be shown in the interactive multiselect, so I don't believe
this change has any functional difference. However, I did use the
opportunity to drive out tests for generateCompareURL
2025-05-02 17:42:23 +02:00
William Martin
5a3aee056a
Feature detect v1 projects on interactive pr create
2025-05-02 17:42:23 +02:00
William Martin
9822bb5d07
Feature detect v1 projects on web mode pr create
2025-05-02 15:11:04 +02:00
William Martin
e995a873cb
Feature detect v1 projects on non-interactive pr create
2025-05-02 15:08:34 +02:00
William Martin
c5d8e6f8f5
Merge pull request #10821 from cli/wm/projectsv1-deprecation-pr-view
...
Feature detect v1 projects on pr view
2025-05-02 15:07:40 +02:00
William Martin
64370ce73e
Cleanup run command stubbed finders in tests
2025-05-02 14:48:52 +02:00
Barak Amar
232c024987
Merge branch 'trunk' into trunk
2025-05-01 22:16:55 +03:00
William Martin
3bcf9758ad
Feature detect v1 projects on pr view
2025-05-01 15:31:36 +02:00
Sinan Sonmez (Chaush)
0a1e7a1fdc
Add --delete-last option to pr comment and issue comment ( #10596 )
...
* deletion for issues with confirmation flag
* add handling for interaction case
* finish implementation for issues
* finish the implementation for issues
* finalize the implementation for PR
* fix missing --yes flag for PR
* address PR comments related to feedbacks
* improve CommentablePreRun for pre checks
* improve confirmation prompt and truncate long comment body
* address PR comments on tests
* Truncate comment for confirmation prompt
Signed-off-by: Babak K. Shandiz <babakks@github.com>
* Improve test case descriptions
Signed-off-by: Babak K. Shandiz <babakks@github.com>
* Fix mock comment body
Signed-off-by: Babak K. Shandiz <babakks@github.com>
* Remove irrelevant prompt stub
Signed-off-by: Babak K. Shandiz <babakks@github.com>
* Use `opts.Interactive` as TTY indicator
Signed-off-by: Babak K. Shandiz <babakks@github.com>
* Fix expected `Interactive` value
Signed-off-by: Babak K. Shandiz <babakks@github.com>
* Polish `TestNewCmdComment`
Signed-off-by: Babak K. Shandiz <babakks@github.com>
---------
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Co-authored-by: Babak K. Shandiz <babakks@github.com>
2025-05-01 14:12:55 +01:00
Barak Amar
a491578751
Merge branch 'trunk' into trunk
2025-04-29 14:33:21 +03:00
Barak Amar
692bdaf578
Apply code review changes
2025-04-29 14:32:51 +03:00
Azeem Sajid
9ed733fa5e
Add closingIssuesReferences JSON field to pr view ( #10544 )
...
* [gh pr view] Support `closingIssuesReferences` JSON field
* Support pagination
* Support pagination
* Fix typo
* Add more fields
2025-04-29 11:48:20 +01:00
Barak Amar
afba7b9e8b
Merge branch 'trunk' into trunk
2025-04-28 18:17:36 +03:00
William Martin
fb97b3efaa
Fix pr create when push.default tracking and no merge ref ( #10863 )
...
* Fix pr create when push.default tracking and no merge ref
* Update pkg/cmd/pr/shared/find_refs_resolution.go
---------
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
2025-04-24 16:41:14 +00:00
William Martin
c208b1f075
Feature detect v1 projects on web mode issue create
2025-04-17 21:04:08 +02:00
William Martin
c8dd61d837
Feature detect v1 projects on non-interactive issue create
2025-04-17 17:51:38 +02:00
Barak Amar
a1f5d42283
Update the test code to align with latest changes
2025-04-17 17:13:28 +03:00
Barak Amar
265139f268
Merge branch 'trunk' into trunk
2025-04-17 09:56:12 -04:00
William Martin
a9dbda6913
Rework ref usage when finding and creating PRs
2025-04-15 13:38:10 -06:00
Kynan Ware
028caa3823
docs(pr create): clarify BaseRepo type in submitPR
2025-04-15 13:38:10 -06:00
Kynan Ware
339e1a25f3
docs(pr create): add link for user:branch syntax
2025-04-15 13:38:10 -06:00
Kynan Ware
76de5f07ca
test(pr finder): run test in parallel
2025-04-15 13:38:10 -06:00
Kynan Ware
bf7bf99f54
fix(pr create & stubs): handle exitcode in stubs
2025-04-15 13:38:10 -06:00
Kynan Ware
81d00a36f8
fix(pr create): use existing local variables
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-15 13:38:10 -06:00
Kynan Ware
15ea861b79
docs(pr create): help text, doc user:branch syntax
...
Document the user:branch syntax for the `--head`` flag in `gh pr create`.
2025-04-15 13:38:10 -06:00
Kynan Ware
7bb5d71f4c
doc(pr create): improve head repo resolution comments
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-15 13:38:10 -06:00
Kynan Ware
041f02c980
docs(pr create): standard <user>:<branch> syntax
...
Standardize <user>:<branch> syntax wherever it is described in comments.
2025-04-15 13:38:10 -06:00
Kynan Ware
6dae35b442
test(finder): change assert to require
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-15 13:38:10 -06:00
Kynan Ware
e9e57f3ee3
doc(pr create): fix typo in comments
...
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
2025-04-15 13:38:10 -06:00
Kynan Ware
d524cbddc2
docs(pr create): clarify comment on head branch syntax
2025-04-15 13:38:10 -06:00
Kynan Ware
e999976b3d
refactor(pr create): add PullRequestRefs HasHead
2025-04-15 13:38:10 -06:00
