Commit graph

5743 commits

Author SHA1 Message Date
Mark Phelps
994fbebf0a
Merge pull request #5873 from cli/fix-codespace-pending-create-panic 2022-07-11 10:05:34 -04:00
Mislav Marohnić
0f67999d52
Merge pull request #5915 from cli/pr-status-headref
pr status: fix detecting PR for curent branch
2022-07-11 14:00:59 +02:00
Mislav Marohnić
04485144ea pr status: fix detecting PR for curent branch 2022-07-11 13:16:33 +02:00
dependabot[bot]
dd8ad5c5fa
Bump github.com/gabriel-vasile/mimetype from 1.4.0 to 1.4.1 (#5903)
Bumps [github.com/gabriel-vasile/mimetype](https://github.com/gabriel-vasile/mimetype) from 1.4.0 to 1.4.1.
- [Release notes](https://github.com/gabriel-vasile/mimetype/releases)
- [Commits](https://github.com/gabriel-vasile/mimetype/compare/v1.4.0...v1.4.1)

---
updated-dependencies:
- dependency-name: github.com/gabriel-vasile/mimetype
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-11 11:00:24 +02:00
Mislav Marohnić
24798b4ee0
Merge pull request #5910 from casswedson/typo-smash
chore: typo hunting ft. codespell
2022-07-11 09:18:14 +02:00
casswedson
00bc550dc6 chore: typo hunting ft. codespell 2022-07-09 21:41:09 -05:00
Mark Phelps
6014b31d03 Fix case where codespace created while in provisioning state causes panic 2022-07-01 13:08:44 -04:00
Caleb Brose
604adc57ef
Merge pull request #5859 from cli/cmbrose/fix-auto-key-path
Use `codespaces.auto` instead for the automatic ssh keys
2022-06-29 12:35:42 -05:00
cmbrose
b2fe329011 Close files to actually fix windows 2022-06-29 12:28:21 -05:00
Caleb Brose
4eac4fbf4c Make a new dir per test to work around windows failures 2022-06-29 11:48:23 -05:00
Caleb Brose
b5348f661e Handle case of partial name match 2022-06-29 11:36:27 -05:00
Caleb Brose
1aa457499d Use Fatal instead to avoid nil-ref 2022-06-29 11:27:18 -05:00
Caleb Brose
fb4ad53dd0 Check MkdirAll error 2022-06-29 11:17:24 -05:00
Caleb Brose
1bae759d3e Don't use strings.Replace 2022-06-29 11:10:50 -05:00
Caleb Brose
77ecd0a147 Rename public key first for edge cases 2022-06-29 10:56:31 -05:00
Caleb Brose
2ac379f689 Comment 2022-06-29 10:54:07 -05:00
Caleb Brose
c5b07762d1 Check the key paths too 2022-06-29 10:51:17 -05:00
Caleb Brose
19b5400811 Handle back compat 2022-06-29 10:46:44 -05:00
Caleb Brose
0687f66208
Use codespaces.auto instead for the automatic ssh keys 2022-06-28 16:26:18 -05:00
Mark Phelps
38ea62afba
Codespaces list by repo (#5854)
* WIP

* Allow to list codespaces by repo

* Tests

* Cleanup

* respond to PR feedback

* Address review comments
2022-06-28 13:34:04 +00:00
Mislav Marohnić
8adfc9a4f2
Merge pull request #5850 from cli/dependabot/go_modules/github.com/stretchr/testify-1.7.5
Bump github.com/stretchr/testify from 1.7.4 to 1.7.5
2022-06-27 12:02:48 +02:00
dependabot[bot]
0ef1ba59d1
Bump github.com/stretchr/testify from 1.7.4 to 1.7.5
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.4 to 1.7.5.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](https://github.com/stretchr/testify/compare/v1.7.4...v1.7.5)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-06-24 14:28:00 +00:00
Sam Coe
cacff4ad6d
Use go-gh config package (#5771) 2022-06-23 11:50:04 +00:00
Mislav Marohnić
5227af0c99
Merge pull request #5844 from cli/linux-keyring-perm
Linux installation: ensure GPG keyring is world-readable
2022-06-23 12:10:11 +02:00
Sam Coe
074ed50b8a
Integrate go-gh API package (#5614) 2022-06-23 04:05:31 +01:00
Mislav Marohnić
449460ebb0 Linux installation: ensure GPG keyring is world-readable
This alleviates problems with umask at the time of installation.
2022-06-22 21:40:42 +02:00
Mislav Marohnić
6e3689d58b
Apply UI polish around codespaces org-admin commands (#5843) 2022-06-22 20:35:56 +02:00
Ashwin Jeyaseelan
47f5abdb6f
8gitbrix/add delete org codespace (#5827)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-06-22 18:28:09 +02:00
Greggory Rothmeier
2294f49d07
Add support for org admins to stop a members codespace (#5812) 2022-06-22 13:56:22 +02:00
Mislav Marohnić
d76c1f352a
Merge pull request #5841 from wilhelmeek/avoid-keep-multiselect
clear pr create multiselect on select
2022-06-22 12:13:00 +02:00
wilhelm
0f02371734
clear pr create multiselect on select 2022-06-22 17:43:41 +10:00
Jake Shorty
5893c9864d
Merge pull request #5828 from cli/jshorty/indent-billable-owner-notice
Indent org billable owner notice for new codespaces
2022-06-21 09:32:27 -06:00
Jake Shorty
bb753731e6 Update test for indentation 2022-06-21 15:19:24 +00:00
Mislav Marohnić
14a9af8378
Merge pull request #5822 from cli/fix-find-executable
Fix determining the current executable under Homebrew for Linux
2022-06-21 16:45:43 +02:00
dependabot[bot]
e50234d12a
Bump github.com/stretchr/testify from 1.7.3 to 1.7.4 (#5833)
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.3 to 1.7.4.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](https://github.com/stretchr/testify/compare/v1.7.3...v1.7.4)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-21 14:34:28 +00:00
Greggory Rothmeier
4b36dc031f
Add flag to list codespaces under an organization (#5807)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-06-21 13:57:40 +00:00
Greggory Rothmeier
9b86fe41c0
Simplify codespace picker (#5826)
This doesn't change anything about how it's formatted, but extracts a
new function formatCodespacesForSelect so we can test and see how it
treats the different combinations of codespaces.

Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-06-21 15:47:11 +02:00
Mislav Marohnić
01bff6b91e
Merge pull request #5802 from greggroth/gregg/repo-secrets
Allow working with Codespaces repo secrets
2022-06-21 15:44:31 +02:00
Mislav Marohnić
7d0b37d8f3
Merge pull request #5825 from gdomingu/ship-retention-period-flag
Uncomment retention period flag for create cmd
2022-06-21 13:58:59 +02:00
Jake Shorty
c48e6ee4c9 Indent org billable owner notice for new codespaces 2022-06-20 21:36:01 +00:00
Gabe D
95b7533a5f Uncomment retention period flag from create cmd 2022-06-20 18:40:56 +00:00
Jake Shorty
faef89144d
Merge pull request #5816 from cli/jshorty/codespace-pre-flight-api
Notify user when codespace usage is covered by organization
2022-06-20 11:33:24 -06:00
Mislav Marohnić
456a0f1bb0
Merge pull request #5715 from azchohfi/arm64
Added Arm64 compilation
2022-06-20 19:24:14 +02:00
Jake Shorty
df3b40999e Flip conditional 2022-06-20 17:13:42 +00:00
Jake Shorty
832f35e000 PreFlight => BillableOwner for less confusion 2022-06-20 17:12:07 +00:00
ffalor
2388f51927
Add --match-head-commit field to gh pr merge (#5692)
Co-authored-by: Sam Coe <samcoe@users.noreply.github.com>
2022-06-20 17:18:00 +02:00
Mislav Marohnić
25b6a89ff3
Merge pull request #5824 from cli/dependabot/go_modules/github.com/stretchr/testify-1.7.3
Bump github.com/stretchr/testify from 1.7.2 to 1.7.3
2022-06-20 17:14:15 +02:00
dependabot[bot]
caaeb5ab11
Bump github.com/stretchr/testify from 1.7.2 to 1.7.3
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.2 to 1.7.3.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](https://github.com/stretchr/testify/compare/v1.7.2...v1.7.3)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-06-20 14:40:36 +00:00
Mislav Marohnić
7387346196 Fix determining the current executable under Homebrew for Linux
We need to use `os.Lstat` instead of `os.Stat` if we are going to
manually inspect files for whether they are a symlink. On macOS, it
looks like `os.Stat` returns information about the symlink itself.
2022-06-20 15:25:29 +02:00
Jake Shorty
2b9f9bb92a Add test for individual case 2022-06-19 18:38:38 +00:00