Commit graph

1230 commits

Author SHA1 Message Date
Corey Johnson
99940fa062 Update test 2020-04-28 12:15:37 -07:00
Corey Johnson
660cce7790 Take a URL 2020-04-28 12:15:33 -07:00
Corey Johnson
f22f584e8d Handle closed issues 2020-04-28 11:53:25 -07:00
Corey Johnson
bf94a31619 not on issues disabled
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
2020-04-28 10:05:56 -07:00
Corey Johnson
7ba6615919 Close test now works
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
2020-04-28 09:51:28 -07:00
Corey Johnson
a2f0cc6de7 Issue close works
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
2020-04-28 09:31:19 -07:00
Corey Johnson
ad48d8b3c3 Add issue close
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
2020-04-28 09:13:08 -07:00
Corey Johnson
e5fc3e9bbd Update issue_test.go
Add test for closing issue

Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
2020-04-28 09:11:19 -07:00
Corey Johnson
2d0d86f7e7
Merge pull request #815 from cli/heathy-helping
Update `gh help` output
2020-04-27 11:42:52 -07:00
Corey Johnson
3d2ee3c9b2 fix whitespace 2020-04-27 10:07:47 -07:00
Nate Smith
a7931a07c9
Merge pull request #816 from vilmibm/whack-a-mole
missed a remote url
2020-04-22 16:35:28 -05:00
vilmibm
97e3a57244 fix tests 2020-04-22 16:16:14 -05:00
vilmibm
03e60758d0 missed a thing 2020-04-22 16:08:47 -05:00
Corey Johnson
e68be52ed0 Use the correct field 2020-04-22 14:03:44 -07:00
Corey Johnson
4b2382c737 Merge branch 'heathy-helping' of https://github.com/cli/cli into heathy-helping 2020-04-22 14:02:09 -07:00
Corey Johnson
c9d5935ee3 move to use 2020-04-22 14:00:08 -07:00
Corey Johnson
4dff85d3c1 Merge remote-tracking branch 'origin/master' into heathy-helping 2020-04-22 13:56:53 -07:00
Nate Smith
9d7590cbfc
Merge pull request #810 from cli/respect-protocol
respect git_protocol setting
2020-04-22 15:54:38 -05:00
Corey Johnson
c064b07e6d Add quote 2020-04-22 13:51:35 -07:00
Corey Johnson
0d79257312
use backets
Co-Authored-By: Amanda Pinsker <ampinsk@github.com>
2020-04-22 13:50:52 -07:00
Corey Johnson
833f8b4f2c
Update command/root.go
Co-Authored-By: Amanda Pinsker <ampinsk@github.com>
2020-04-22 13:50:06 -07:00
Corey Johnson
6d20283a7a Move feedback to the bottom 2020-04-22 13:49:42 -07:00
vilmibm
f1bee0c9b9 use more clear name 2020-04-22 15:49:16 -05:00
Corey Johnson
b5299ef5d7
pointy brackets ftw
Co-Authored-By: Amanda Pinsker <ampinsk@github.com>
2020-04-22 13:46:51 -07:00
Nate Smith
f7aea8e349
Merge pull request #814 from cli/respect-editor
respect configured editor
2020-04-22 14:37:11 -05:00
vilmibm
f26690adc9 support GH_EDITOR 2020-04-22 14:33:56 -05:00
vilmibm
9641eee38a use more clear name 2020-04-22 14:31:09 -05:00
vilmibm
bec58ede98 respect ssh
this adds recognition of the git_protocol setting when:

- creating a repo
- cloning a repo
- forking a repo
- forking/pushing during pr create
- checking out a PR

additionally, it:

- consolidates remote adding to use AddRemote; this introduces a fetch
where there previously hadn't been one
- changes repo clone to accept an ssh url
- changes repo fork to accept an ssh url

i just added basic unit tests; adding new test cases for all of the
above scenarios seemed like diminishing returns.
2020-04-22 14:21:01 -05:00
Corey Johnson
a4429aae41 rearrange code 2020-04-22 10:00:33 -07:00
vilmibm
3c8b87c9c6 respect configured editor 2020-04-22 11:23:14 -05:00
Corey Johnson
be51d095ea Separating core from non-core commands 2020-04-21 13:30:07 -07:00
Nate Smith
80d7513537
Merge pull request #728 from cli/gh-config
gh config
2020-04-21 12:25:35 -05:00
vilmibm
d4dd4a68bf fix error handling 2020-04-21 11:25:23 -05:00
vilmibm
fcf258620c ignore MarkHidden errors 2020-04-21 11:23:38 -05:00
vilmibm
6e55e899fa handle defaults at the Config level instead of ConfigMap 2020-04-21 10:59:44 -05:00
vilmibm
bba63439dc slopwip for defaults 2020-04-21 10:32:57 -05:00
Mislav Marohnić
2ddd61afcc
Merge pull request #795 from cli/contributing-docs
Tweak CONTRIBUTING docs to clarify our stance about installation instructions
2020-04-21 10:05:57 +02:00
vilmibm
db9f4c36aa oops 2020-04-20 16:51:23 -05:00
vilmibm
3220f2ef53 linter appeasement 2020-04-20 14:00:06 -05:00
vilmibm
c4693077aa move config stuff to its own package 2020-04-20 13:57:16 -05:00
vilmibm
815f461e8b more strict erroring around missing user/token 2020-04-20 12:49:46 -05:00
vilmibm
b1d5264524 do not import testing outside of a _test file 2020-04-20 12:37:52 -05:00
vilmibm
1a5bc0687e usage cleanup 2020-04-20 12:33:32 -05:00
vilmibm
bd907ec74d favor %w over %s for error wrapping 2020-04-20 12:22:12 -05:00
Nate Smith
664d250a61
Merge pull request #785 from pabs3/debian-instructions
Update Debian instructions for modern apt versions
2020-04-20 10:36:34 -05:00
vilmibm
e823ad0c6c staunch some type bleeding 2020-04-17 15:27:52 -05:00
vilmibm
a0b7f37935 clean up Config interface 2020-04-17 15:21:44 -05:00
vilmibm
a325db3051 new config infrastructure
- adds config get and config set commands
- supports arbitrary k/v strings set at top and host level
- supports writing an updated config, preserving comments
- supports mostly lazy evaluation of yaml
2020-04-17 15:17:44 -05:00
Mislav Marohnić
206cff9b67
Please avoid adding installation instructions for your OS 2020-04-17 15:34:41 +02:00
Mislav Marohnić
2f02a79df0
Touch up CONTRIBUTING docs 💅 2020-04-17 15:29:12 +02:00