Commit graph

639 commits

Author SHA1 Message Date
vilmibm
99c312e8ce accept a remote name instead of doing magic remote naming in repo fork 2021-01-20 15:32:19 -08:00
vilmibm
03f99a0140 Merge remote-tracking branch 'origin/trunk' into remote-renaming-847 2021-01-20 15:10:20 -08:00
Nate Smith
5430728a0a
Merge pull request #2813 from cli/token-from-env-err
More descriptive error when aborting auth due to environment variables
2021-01-20 15:06:52 -08:00
Björn Heinrichs
c9f79271b1
Add --maintainer-edit flag (#2250)
* Add --maintainer-edit flag

Closes #2213 while retaining backwards compatibility.

* Fix linting

* Adjust documentation and validation

* Negate logic and fix build errors

* rename to no-maintainer-edit

* test

* use a positive option instead of negative

Co-authored-by: vilmibm <vilmibm@github.com>
2021-01-20 14:51:27 -08:00
Sam Coe
b9b1079493
Display reviews when viewing pull requests 2021-01-20 12:15:25 -08:00
Mislav Marohnić
dcf5a27f53
Merge pull request #1862 from edualb/trunk
[#1755] SSH key management (gh ssh-key list)
2021-01-20 20:47:21 +01:00
Mislav Marohnić
4a2cc8d2a4 Simplify ssh-key list
Do not require nor request `read:public_key` scope by default.
2021-01-20 20:23:57 +01:00
edualb
e26a1b98a1 add ssh-key command 2021-01-20 20:23:38 +01:00
Cristian Dominguez
2086d135f3
Respect system/user timezone in API requests (#2630)
* Respect system/user timezone in API requests

* Fall back to a known timezone if TZ is not set

Co-authored-by: Cristian Dominguez <cristiand391@users.noreply.github.com>
2021-01-20 10:44:46 -08:00
Mislav Marohnić
c9407b2629 More descriptive error when aborting auth due to environment variables
Old message:

    read-only token in GH_TOKEN cannot be modified

This message was vague and some users did not understand that this
refers to the value that is read from environment variables.

New message:

    $ GH_TOKEN=123 ghd auth login -h github.com
    The value of the GH_TOKEN environment variable is being used for authentication.
    To have GitHub CLI store credentials instead, first clear the value from the environment.
2021-01-20 18:27:35 +01:00
Mislav Marohnić
b5366c6ebf
Merge pull request #2794 from cristiand391/use-testify-assertion
Use Testify assertions in tests
2021-01-19 14:08:25 +01:00
Mislav Marohnić
75ebb863e3 Use testify assertions for error matching 2021-01-19 13:59:37 +01:00
Cristian Dominguez
45f4a1f087 Equal: flip arguments position 2021-01-18 21:00:59 -03:00
Mislav Marohnić
66546e2245 When pr merge --delete-branch flag is supplied, avoid prompting for it 2021-01-18 18:10:20 +01:00
Cristian Dominguez
3afb1d0b1a Use Testify assertions in test 2021-01-16 19:19:30 -03:00
Devon Romanko
df31fae9c6 remove prompt for deleting branches on pr merge in interactive mode when -d flag is passed 2021-01-15 17:34:00 -05:00
Devon Romanko
2c35eb04ff address pr comments 2021-01-15 16:54:46 -05:00
Devon Romanko
85e0e44920 Add prompt to delete local branch when attempting to merge a PR that is already merged 2021-01-15 07:25:24 -05:00
Sam
b0ae09e627
Merge pull request #2535 from cli/create-comments
Create issue comments
2021-01-12 11:24:09 -08:00
Cristian Dominguez
ce151420f3 Migrate legacy tests 2021-01-11 21:07:19 -03:00
Sam Coe
723e9e31ba
Address PR comments 2021-01-11 13:56:17 -08:00
Sam Coe
155507d31d
Make comment command easier to test 2021-01-05 15:14:25 -08:00
xhqr
8b5c5896f2
[repo/create] Create local repo dir with non tty. (#2671)
This addresses issue #2587.
2021-01-05 14:40:52 -08:00
Sam Coe
1fc8b66b26
Address PR comments 2021-01-05 10:36:03 -08:00
Sam Coe
f862123071
Modify issue commenting to adhere to designs and add tests 2021-01-05 10:35:09 -08:00
Yuki Osaki
338bf1d112
fix linter issue 2021-01-05 10:35:09 -08:00
Yuki Osaki
8ef2bb4d14
Comment on issues from editor 2021-01-05 10:35:09 -08:00
Mislav Marohnić
ca83106a38
Merge pull request #2727 from cristiand391/remove-unused-methods
Remove unused methods
2021-01-05 15:33:56 +01:00
Cristian Dominguez
21a57d9253 Remove unused methods 2021-01-04 07:35:41 -03:00
Camelid
8ff4cc40e6 view: Add missing newline
Add a newline at the end of the 'View this {issue, pull request} on
GitHub' message. `gh repo view` already had a newline at the end, so
this only changes `issue view` and `pr view`.
2020-12-27 11:37:59 -08:00
Nate Smith
230441e1a5
Merge pull request #2222 from Crunch09/issue-2115
add `gist clone` command
2020-12-18 13:07:44 -08:00
Mislav Marohnić
782932bfae
Merge pull request #2636 from cli/docs-completion
Improve `completion` docs for bash, zsh, fish
2020-12-17 18:21:19 +01:00
Mislav Marohnić
18b19e074d Fix link in version output
It now correctly links to the tagged release instead of to the latest
release.
2020-12-17 12:37:22 +01:00
Mislav Marohnić
9d50221669 Improve completion docs for bash, zsh, fish 2020-12-16 16:57:28 +01:00
Nate Smith
3b1e526a27
Merge pull request #2529 from cli/441-secrets
gh secret {set,list,remove}
2020-12-15 11:16:53 -06:00
Mislav Marohnić
65e5ba9da1
Merge pull request #2493 from gunadhya/repo-clone-wiki
Initial fix for gh-repo-clone wiki
2020-12-15 18:01:55 +01:00
Mislav Marohnić
39a0a8c57c Improve clone wiki test 2020-12-15 17:45:13 +01:00
gunadhya
fd57835bb9 Fix repo clone wiki 2020-12-15 17:45:03 +01:00
Mislav Marohnić
a77f3ddb49
Merge pull request #2575 from cli/pr-view-comments
Add ability to view comments with `pr view`
2020-12-15 16:31:03 +01:00
Mislav Marohnić
1e4fa60478
Merge pull request #2462 from cli/view-comments
Add issue comment viewing
2020-12-15 16:22:32 +01:00
Mislav Marohnić
b1f93426eb
Merge pull request #2449 from cli/git-credentials
Set up git authentication when logging in to gh
2020-12-15 16:14:07 +01:00
vilmibm
352cde0563 do not process filename arguments 2020-12-14 10:44:26 -08:00
vilmibm
a5a043c5a5 automatically set vis when just -r passed 2020-12-10 15:24:09 -08:00
vilmibm
3306351162 use type for Visibility 2020-12-10 15:11:08 -08:00
vilmibm
e1e838c281 more explicit success message 2020-12-10 15:04:56 -08:00
vilmibm
2e6639fe78 show number of selected repositories in secret list 2020-12-10 14:59:37 -08:00
vilmibm
408d5c6d96 no space in usage placeholder 2020-12-10 13:23:35 -08:00
vilmibm
4e8a680575 remove implied org functionality from secret set 2020-12-10 13:22:11 -08:00
vilmibm
1675bd9249 remove implied org functionality from secret remove
also fill in missing test cases >_>
2020-12-10 12:45:38 -08:00
vilmibm
c036e6699c remove implied org functionality from secret list 2020-12-10 12:36:57 -08:00