Commit graph

1387 commits

Author SHA1 Message Date
vilmibm
9f0a19911a de-register review until it's ready to ship 2020-05-11 12:04:05 -05:00
Corey Johnson
fe49c2d8b7
Merge pull request #862 from cli/cli-syntax
Add command line syntax doc
2020-05-11 09:54:04 -07:00
Corey Johnson
a7cef60aae
Merge pull request #889 from cli/hacky-help
Fix the help docs on subcommands
2020-05-11 09:39:53 -07:00
Mislav Marohnić
1f0db96f2a Avoid relying on Cobra help internals 2020-05-11 12:38:22 +02:00
Nate Smith
c7f7bfc328
Merge pull request #787 from cli/issue-pr-create-metadata
Add flags to add additional metadata to `issue/pr create`
2020-05-08 15:04:15 -05:00
Nate Smith
5ba3baa3c8
Merge pull request #762 from doi-t/reviewers-in-pr-view
Add Reviewers to pr view in CLI
2020-05-08 14:46:08 -05:00
Nate Smith
07dc617566
Merge pull request #840 from cli/credits
hackday: gh credits
2020-05-08 14:37:35 -05:00
vilmibm
b15692fab3 review feedback 2020-05-08 14:29:50 -05:00
Nate Smith
77ed118022
Merge pull request #880 from cli/pr-status-crash
Fix `pr status -R` crash with closed PR on the default branch
2020-05-08 14:23:51 -05:00
Nate Smith
27de1fdc36
Merge pull request #881 from cli/go1.14
Upgrade to Go 1.14 in CI
2020-05-08 14:15:04 -05:00
Corey Johnson
a46e7cab2f Update docs 2020-05-08 11:54:13 -07:00
Corey Johnson
9267804ef3 Update docs 2020-05-08 11:44:30 -07:00
Mislav Marohnić
c682d90466 Add tests for issue/pr create with metadata 2020-05-08 20:32:46 +02:00
Mislav Marohnić
4a3588d611
Merge pull request #839 from cli/issue-pr-create-metadata-wizard
Prompt for additional metadata during `issue/pr create`
2020-05-08 18:55:12 +02:00
Mislav Marohnić
8c84d6881e Avoid aborting survey if reviewers/assignees/labels/projects/milestones are empty 2020-05-08 18:49:43 +02:00
Mislav Marohnić
1128439cd1 issue/pr create: hide "Add metadata" if viewer does not have triage permission 2020-05-08 18:37:08 +02:00
Corey Johnson
ba1b3424c1 Remove unused funcs
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
2020-05-08 09:22:50 -07:00
Mislav Marohnić
d7e6d21766 Order projects, teams, and labels by name 2020-05-08 18:22:14 +02:00
Corey Johnson
70223d1e32 Don't always use the root command help
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
2020-05-08 09:19:19 -07:00
Mislav Marohnić
1f774b4158 Add spinner while loading metadata 2020-05-08 18:11:57 +02:00
Mislav Marohnić
34fc3457d6 Skip interactive mode in pr create if title & body were passed
This matches `issue create` behavior 4b32e3f215
2020-05-08 18:06:05 +02:00
Mislav Marohnić
cedf94f450 Name some values for readability 2020-05-08 17:58:33 +02:00
Mislav Marohnić
df144926b8 Rename data variable to something more descriptive 2020-05-08 17:56:47 +02:00
Mislav Marohnić
716036161b Rename titleBody (now a misnomer) to something more descriptive 2020-05-08 17:55:46 +02:00
Mislav Marohnić
72e99e9530 Merge branch 'issue-pr-create-metadata' into issue-pr-create-metadata-wizard 2020-05-08 17:46:47 +02:00
Mislav Marohnić
d0f168f4c3 Merge remote-tracking branch 'origin/master' into issue-pr-create-metadata 2020-05-08 17:46:17 +02:00
Mislav Marohnić
3000847bb2
Merge pull request #874 from cli/httpmock
Parallelism-safe mechanism for stubbing HTTP responses
2020-05-08 17:34:57 +02:00
Nate Smith
2621b85ff9
Merge pull request #876 from cli/review
non-interactive gh pr review
2020-05-08 10:22:57 -05:00
vilmibm
6538cca693 switch to using body flag. small TODOs 2020-05-08 10:07:20 -05:00
vilmibm
c40f064baa sigh 2020-05-07 14:58:00 -05:00
vilmibm
46522a2add fix current branch tests 2020-05-07 14:51:17 -05:00
vilmibm
8a5290d2b4 clarify error msg 2020-05-07 14:51:08 -05:00
vilmibm
5dbec25f44 handle pr for branch case 2020-05-07 14:27:33 -05:00
Mislav Marohnić
1fb27af96b Bump golangci-lint 2020-05-07 21:04:44 +02:00
Mislav Marohnić
0eb471899a Upgrade to Go 1.14 in CI 2020-05-07 21:03:42 +02:00
Mislav Marohnić
93c61a83b2 Fix pr status -R crash with closed PR on the default branch
At the time we have a reference to `baseRepo`, we might still not have
contacted the API nor obtained any information about the default branch
for the repository. This expands the `PullRequests()` query to always
report the default branch so we may choose how to render entries that
belong on the current branch.
2020-05-07 20:53:03 +02:00
vilmibm
d81e622700 lightest weight reviewing
this commit add very basic non-interactive PR reviewing. You can either
review the "current" or a passed PR (number or URL) as approved, changes
requested, or commented via CLI flags.
2020-05-07 13:30:34 -05:00
Corey Johnson
5cf6fb4af4 Update doc 2020-05-07 10:13:36 -07:00
Corey Johnson
67f65a09d0 Update doc 2020-05-07 09:28:34 -07:00
Mislav Marohnić
a7242f4ca3
Merge pull request #863 from cli/close-cmd-syntax
Tweak syntax in `issue/pr close` docs
2020-05-07 16:55:13 +02:00
Mislav Marohnić
51e46c75b3
Merge pull request #879 from cli/issue-template-name-fix
Fix parsing some issue template names
2020-05-07 16:30:46 +02:00
Mislav Marohnić
5913a72532
Merge pull request #819 from rista404/interactive-when-defaults-807
Disable interactive mode for `issue create` if all flags are passed
2020-05-07 16:29:04 +02:00
Mislav Marohnić
8b9e7df705 Fix parsing some issue template names
YAML parsing sometimes gets sabotaged by asterisks that follow the end
of frontmatter (`---`). We now scope YAML parsing to only frontmatter
and we don't pass any contents that follow.
2020-05-07 15:50:01 +02:00
Mislav Marohnić
0a4d4ee007 Replace FakeHTTP with httpmock which is now compatible 2020-05-07 15:19:14 +02:00
Mislav Marohnić
256d31950a Migrate a single test over to httpmock to demonstrate its use 2020-05-06 22:06:37 +02:00
Mislav Marohnić
1d4065e4c4 Add a HTTP mocking interface that matches incoming requests
This adds a thread-safe RoundTripper that can be used for mocking HTTP
requests in tests. Incoming requests are matched based on their
contents, not the order the stubs were registered in.
2020-05-06 22:03:32 +02:00
Mislav Marohnić
4ef468c19a Merge branch 'codeql' 2020-05-06 10:21:55 +02:00
Mislav Marohnić
c62c00761e Tweak CodeQL workflow 2020-05-06 10:16:08 +02:00
Justin Hutchings
e0071329f5
Remove strategy, remove autobuild 2020-05-05 13:45:06 -07:00
Corey Johnson
cb8d9963e3 Add note for variable naming 2020-05-05 09:55:27 -07:00