Commit graph

8249 commits

Author SHA1 Message Date
Sarah Barili
a02f84528a
Update internal/codespaces/rpc/invoker.go
Co-authored-by: Caleb Brose <5447118+cmbrose@users.noreply.github.com>
2024-11-08 09:11:44 -07:00
Sarah Barili
6d5a26cfd1 adding username validation to the invoker ssh server 2024-11-06 14:45:41 -07:00
Andy Feller
e356c69a6f
Merge pull request #9881 from cli/cmbrose/cs-config-autokey
Create the automatic key when specified with -i
2024-11-06 16:24:43 -05:00
Andy Feller
2435f6915b Minor nit suggestion 2024-11-06 16:12:55 -05:00
Tyler McGoffin
ef8999749a
Merge pull request #9884 from cli/dependabot/github_actions/actions/attest-build-provenance-1.4.4
Bump actions/attest-build-provenance from 1.4.3 to 1.4.4
2024-11-06 11:53:12 -08:00
Caleb Brose
509a181d79
Remove unimplemented tests 2024-11-06 19:10:28 +00:00
William Martin
0f85e4e0e0
Merge pull request #9883 from cli/9882-gh-cache-list-json-should-return-when-no-caches-exist-instead-of-text-message
Print empty array for `gh cache list` when `--json` is provided
2024-11-06 18:18:44 +01:00
Meredith Lancaster
2f47d1c81c
Merge pull request #9877 from malancas/simplify-sigstore-verify-result-handling
Simplify Sigstore verification result handling in `gh attestation verify`
2024-11-06 09:38:07 -07:00
Caleb Brose
940560acf2
Fix ssh directory 2024-11-06 16:13:29 +00:00
Meredith Lancaster
f376ac1a2c Merge branch 'trunk' into simplify-sigstore-verify-result-handling 2024-11-06 07:59:23 -07:00
Meredith Lancaster
446a0d5885
Merge pull request #9848 from malancas/attestation-refactor-policy 2024-11-06 07:50:25 -07:00
dependabot[bot]
2318fde15f
Bump actions/attest-build-provenance from 1.4.3 to 1.4.4
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) from 1.4.3 to 1.4.4.
- [Release notes](https://github.com/actions/attest-build-provenance/releases)
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md)
- [Commits](1c608d11d6...ef244123eb)

---
updated-dependencies:
- dependency-name: actions/attest-build-provenance
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-11-06 14:14:48 +00:00
William Martin
f608221737
Merge pull request #9862 from cli/dependabot/go_modules/github.com/creack/pty-1.1.24
Bump github.com/creack/pty from 1.1.23 to 1.1.24
2024-11-06 14:57:59 +01:00
William Martin
a569d1030d Export empty results for cache list 2024-11-06 13:02:14 +01:00
Tyler McGoffin
fe5afb1205
Merge pull request #9876 from akx/delete-workflow-run-copy
Fix verbiage for deleting workflow runs
2024-11-05 15:11:51 -08:00
Caleb Brose
b4c221dfb7
Create the automatic key when specified with -i 2024-11-05 22:30:15 +00:00
Aarni Koskela
1c4c8e5145 Fix verbiage for deleting workflow runs
It's not deleting _workflows_ (which are specified in YAML)...
2024-11-04 17:55:35 +02:00
Meredith Lancaster
b9c9f0acc2 move comment
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-04 07:35:42 -07:00
Meredith Lancaster
3281bd457c simplify logic, add comments
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-04 07:32:10 -07:00
Meredith Lancaster
91967cced8
Update pkg/cmd/attestation/verify/verify.go
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-01 09:51:05 -06:00
Meredith Lancaster
43810a5fc3 use predicate type stored in enforcementCriteria
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-01 09:17:47 -06:00
Meredith Lancaster
bb1584b52a comment
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-01 09:02:56 -06:00
Meredith Lancaster
a6d15b4f60 update OIDC issuer logic
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-01 09:02:23 -06:00
Meredith Lancaster
a5eca00d0d remove emtpy string checks
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-01 08:20:32 -06:00
dependabot[bot]
815fcb72b5
Bump github.com/creack/pty from 1.1.23 to 1.1.24
Bumps [github.com/creack/pty](https://github.com/creack/pty) from 1.1.23 to 1.1.24.
- [Release notes](https://github.com/creack/pty/releases)
- [Commits](https://github.com/creack/pty/compare/v1.1.23...v1.1.24)

---
updated-dependencies:
- dependency-name: github.com/creack/pty
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-11-01 14:10:24 +00:00
Meredith Lancaster
0fb82a6e7c comments
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 17:11:02 -06:00
Meredith Lancaster
a7a70fc91c check for SAN and SANRegex
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 16:59:25 -06:00
Meredith Lancaster
50cda0df44 add Valid method for EnforcementCriteria
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 16:56:49 -06:00
Meredith Lancaster
8336f797ad use sigstore-go certificate.Summary type for criteria
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 16:27:21 -06:00
Meredith Lancaster
9f3d00960c keep comment
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 16:16:09 -06:00
Meredith Lancaster
a81cb730fc update VerifyCertExtensions args
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 16:14:28 -06:00
Meredith Lancaster
e6d0a067e6
Update pkg/cmd/attestation/verification/extensions.go
Co-authored-by: Phill MV <phillmv@github.com>
2024-10-31 16:09:45 -06:00
Meredith Lancaster
7948ce4dc9 rename function
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 16:09:08 -06:00
Meredith Lancaster
6f4b5ddc40 remove artifact from EnforcementCriteria
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 16:07:25 -06:00
Meredith Lancaster
56731c9b70 remove unneeded result handling struct
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 12:26:06 -06:00
Kynan Ware
30066b0042
Merge pull request #9844 from its-miroma/dnf5
Set `dnf5` commands as default
2024-10-31 09:42:14 -06:00
Meredith Lancaster
9cdeb31fc6 reorganize funcs
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 08:32:35 -06:00
Meredith Lancaster
61b60e9430 fix runner setting
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 08:19:33 -06:00
Meredith Lancaster
bb0dcd9db4 fix wrong field settings
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-30 17:19:15 -06:00
Meredith Lancaster
318bd90356 update extensions tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-30 16:21:15 -06:00
Meredith Lancaster
bf4f04f797 Merge branch 'trunk' into attestation-refactor-policy 2024-10-30 16:14:30 -06:00
Meredith Lancaster
84c823c55f clean up extension verification tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-30 16:12:57 -06:00
Meredith Lancaster
8b02c43085 add tests for newEnforcementCriteria
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-30 16:05:39 -06:00
Meredith Lancaster
1652051fc2
Merge pull request #9825 from malancas/verify-provenance-predicate-by-default
`gh attestation verify` should only verify provenance attestations by default
2024-10-30 15:45:18 -06:00
Meredith Lancaster
4fa5f0c5ee update extensions test
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-30 15:44:53 -06:00
Meredith Lancaster
fa2574c1a8 Merge remote-tracking branch 'upstream/trunk' into attestation-refactor-policy 2024-10-30 15:29:27 -06:00
Meredith Lancaster
93c78a2134 use sigstore specific err
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-30 15:28:34 -06:00
Meredith Lancaster
b44c9d3003 undo policy method changes
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-30 15:23:50 -06:00
Meredith Lancaster
bb5136007e
Merge pull request #9838 from malancas/attestation-clean-up-tests
Clean up skipped online tests for `gh attestation verify`
2024-10-30 13:28:44 -06:00
Andy Feller
3b4301f62a
Merge pull request #9845 from cli/andyfeller/9807-repo-edit-visibility-confirmation
Require visibility confirmation in `gh repo edit`
2024-10-30 15:20:51 -04:00