ANKDDEV
419a01271a
docs: add help topic for auth scopes
2024-12-06 17:03:31 +03:00
ANKDDEV
694e209142
docs: improve help for browse command
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-12-06 16:33:57 +03:00
ANKDDEV
3e647385f7
docs: improve docs for browse command as of #5352
2024-12-06 13:45:22 +03:00
Andy Feller
d60e5ffba3
Merge pull request #10016 from cli/andyfeller/cli-cli-10013-pr-checks-json-watch-mutex
...
Error for mutually exclusive json and watch flags
2024-12-05 12:22:24 -05:00
Meredith Lancaster
2b7c6f6a16
add integration test for bundle-from-oci option
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-05 09:58:27 -07:00
Andy Feller
acfdae466e
Merge pull request #10009 from cli/wm/safepaths
...
Use safepaths for run download
2024-12-05 11:43:10 -05:00
Meredith Lancaster
2137a483de
include alg with digest when fetching bundles from OCI
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-05 09:27:14 -07:00
Andy Feller
c9ecf310b3
Error for mutually exclusive json and watch flags
...
Closes #10013
This commit enhances `gh pr checks` to exit with an error when mutually exclusive `--json` and `--watch` flags are used. Users are encouraged to either 1) retrieve information about the checks via `--json` or 2) watch and wait on PR checks that are being updated.
2024-12-05 10:23:13 -05:00
William Martin
9bd8f09774
Use safepaths for run download
2024-12-04 22:12:58 +01:00
William Martin
a47b4c9f1d
Use consistent slice ordering in run download tests
2024-12-04 13:02:25 +01:00
Tyler McGoffin
1136764c36
Merge commit from fork
...
The fix
2024-12-03 15:12:05 -08:00
Meredith Lancaster
3b043f6350
comment
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-03 12:37:42 -07:00
Meredith Lancaster
efca3bdfd9
try switch statement
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-03 12:34:33 -07:00
Meredith Lancaster
2a6ee87ba0
remove duplicate err checking
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-03 12:29:35 -07:00
Meredith Lancaster
f0f86ecd23
get bundle issuer in another func
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-03 12:22:56 -07:00
Meredith Lancaster
d737d3b933
more logic updating to remove nesting
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-03 12:19:28 -07:00
Meredith Lancaster
1ffd22565d
inverse logic for less nesting
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-03 11:52:08 -07:00
Andy Feller
8720479b0b
Consolidate logic for isolating artifacts
2024-12-03 13:33:00 -05:00
Meredith Lancaster
6a7243bb7b
remove unneeded nesting
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-03 10:54:22 -07:00
Phill MV
963a6fe8fa
Merge branch 'trunk' into phillmv/improve-gh-at-inspect
2024-12-03 11:52:46 -05:00
William Martin
7c241cf4e6
Merge pull request #9992 from cli/wm/fix-pr-checkout-panic
...
Fix PR checkout panic when base repo is not in remotes
2024-12-03 14:04:32 +01:00
William Martin
694e565384
Fix PR checkout panic when base repo is not in remotes
2024-12-02 17:20:57 +01:00
Tim Rogers
c719d920c3
When renaming an existing remote in gh repo fork, log the change
...
When running `gh repo fork` in the context of an existing repo, the CLI offers to create a remote for the fork:
```
? Would you like to add a remote for the fork? Yes
```
If you accept, it prints a log stating that the `origin` remote has been created:
```
✓ Added remote origin
```
Where there is an existing `origin` remote, this is renamed to `upstream`, but this is done silently without any notification to the user.
```bash
$ git remote -v
origin https://github.com/timrogers/badger.github.io.git (fetch)
origin https://github.com/timrogers/badger.github.io.git (push)
upstream https://github.com/badger/badger.github.io.git (fetch)
upstream https://github.com/badger/badger.github.io.git (push)
```
It seems kinda fine to rename the remote without explicitly confirming since this is not a truly destructive action, but it should make it clear what it is doing.
This updates the logging to explicitly log about the renaming of
the existing remote:
```
✓ Renamed remote origin to upstream
```
Fixes #9982 .
2024-11-30 21:19:55 +00:00
Phill MV
1cbdcedc80
Merge branch 'trunk' into phillmv/improve-gh-at-inspect
2024-11-27 16:40:22 -05:00
Andy Feller
1fe14c956d
Merge commit from fork
...
Use only one pattern for credential helper matching
2024-11-27 15:57:08 -05:00
William Martin
bd44d33eaa
Add checkout test that uses ssh git remote url
2024-11-27 13:06:35 +01:00
William Martin
72a6fd00a4
Rename backwards compatible credentials pattern
2024-11-27 12:21:55 +01:00
William Martin
efd8ff6d46
General cleanup and docs
2024-11-26 22:30:11 +01:00
William Martin
19d62826d6
Allow repo sync fetch to use insecure credentials pattern
2024-11-26 22:30:07 +01:00
William Martin
6b7f1ff060
Allow client fetch to use insecure credentials pattern
2024-11-26 22:30:03 +01:00
William Martin
7affcadb5e
Allow client push to use insecure credential pattern
2024-11-26 22:29:58 +01:00
William Martin
75712de712
Allow client pull to use insecure credential pattern
2024-11-26 22:29:51 +01:00
William Martin
46922694dc
Support secure credential pattern
2024-11-26 22:29:38 +01:00
Phill MV
c8e6ac2e6c
wip, linting, getting tests to pass
2024-11-26 16:19:05 -05:00
Meredith Lancaster
389d0b31dc
wording
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-26 13:49:32 -07:00
Meredith Lancaster
92c623ab54
var naming
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-26 13:38:09 -07:00
Meredith Lancaster
a326f5cb18
drop table view
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-26 13:36:51 -07:00
Meredith Lancaster
c9be8ce7b9
Merge branch 'print-policy-info' of github.com:malancas/cli into print-policy-info
2024-11-26 13:35:24 -07:00
Meredith Lancaster
645d7501f0
order policy info so relevant info is printed next to each other
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-26 13:35:19 -07:00
Meredith Lancaster
ab3f368dd1
Merge branch 'trunk' into print-policy-info
2024-11-26 09:01:39 -07:00
Andy Feller
b133f9cce0
Merge pull request #9791 from cli/kw/cli-9773-informative-message-for-workflow-scope
...
Print friendly error when `release create` fails due to missing `workflow` OAuth scope
2024-11-26 08:30:59 -05:00
Meredith Lancaster
c7d3e6daeb
Update pkg/cmd/attestation/verification/policy.go
...
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-25 14:50:16 -07:00
Meredith Lancaster
4b83d8e73b
Update pkg/cmd/attestation/verification/policy.go
...
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-25 14:49:56 -07:00
Meredith Lancaster
241bb2edd1
Update pkg/cmd/attestation/verification/policy.go
...
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-25 14:49:44 -07:00
bagtoad
deb34d6456
Refactor error handling for missing "workflow" scope in createRelease
2024-11-23 16:59:49 -07:00
Kynan Ware
a4f96d29e3
Refactor workflow scope checking
...
Refactor the logic for checking `workflow` scope checking in releases to be in the positive - check if the scope is there, not check if it isn't there. Then, when the function is called we invert it.
Also update comments to be more imperative.
This refactor also incorporates @andyfeller's suggestion to use `slices`.
Co-Authored-By: Andy Feller <andyfeller@github.com>
2024-11-23 13:17:09 -07:00
Phill MV
b50022db08
wip: added new printSummaryInspection
2024-11-22 17:08:51 -05:00
Andy Feller
cdfc12caf5
Expand logic and tests to handle edge cases
...
This commit expands filepathDescendsFrom(string, string) to handle edge cases such as mixing absolute and relative paths or artifact name edge cases.
Additionally, tests for filepathDescendsFrom() and downloadrun() have been expanded to verify additional use cases.
2024-11-22 15:26:11 -05:00
Kynan Ware
ae87caf8d6
Merge pull request #9948 from cli/kw/use-heredoc-for-several-command-docs
...
Fix some multiline command documentation to use `heredoc` strings
2024-11-22 10:11:32 -07:00
Meredith Lancaster
862786cca6
Merge branch 'trunk' into print-policy-info
2024-11-22 09:10:19 -07:00
