Commit graph

2900 commits

Author SHA1 Message Date
Mislav Marohnić
a77f3ddb49
Merge pull request #2575 from cli/pr-view-comments
Add ability to view comments with `pr view`
2020-12-15 16:31:03 +01:00
Mislav Marohnić
1e4fa60478
Merge pull request #2462 from cli/view-comments
Add issue comment viewing
2020-12-15 16:22:32 +01:00
Mislav Marohnić
d81b2927a5
Merge pull request #2488 from cristiand391/new-release-notification
Notify new releases only once per day
2020-12-15 16:15:01 +01:00
Mislav Marohnić
b1f93426eb
Merge pull request #2449 from cli/git-credentials
Set up git authentication when logging in to gh
2020-12-15 16:14:07 +01:00
Mislav Marohnić
ae68da6520
Merge pull request #2230 from alissonbrunosa/fix-2179
Add support for ssh_config Include directives
2020-12-15 16:11:27 +01:00
Mislav Marohnić
2843ffff23 Classify the update package as internal 2020-12-15 16:09:08 +01:00
Sam Coe
42c97509ca Simplify CheckForUpdate handling of state file 2020-12-15 16:03:37 +01:00
Cristian Dominguez
0ec8c2e9ed Notify new releases only once per day 2020-12-15 16:03:37 +01:00
Mislav Marohnić
935f6444ae Refactor ssh parser for format compatibility & testability
- Per ssh_config(5), keywords and arguments may be separated by an `=`
  sign as well as whitespace.
- When following the `Include` directive, skip directories that were
  returned as the result of globbing.
- Respect the `Host` context when recursing into `Include`s
- Avoid having tests read from the actual filesystem.
- Avoid repeatedly looking up the home directory.
2020-12-15 15:59:18 +01:00
Alisson Santos
dc8698ee46 Make ssh parser to parse included config files 2020-12-15 15:37:17 +01:00
Mislav Marohnić
f3ea05f2e1
Merge pull request #2624 from nopeinomicon/patch-1
Add openSUSE distro package install instructions
2020-12-15 15:24:59 +01:00
Mislav Marohnić
cba15d0109
Clarify openSUSE Tumbleweed instructions 2020-12-15 15:16:33 +01:00
Emily Roberts
b8522f683c
Add openSUSE distro package install instructions
Added the instructions to install the GitHub CLI from the openSUSE distribution repositories
2020-12-15 01:17:44 -07:00
Mislav Marohnić
c765c71e47
Merge pull request #2556 from pete-woods/build-static-binaries
Build static binaries on Linux
2020-12-14 21:04:15 +01:00
Mislav Marohnić
3ad9f39ec4
Merge pull request #2582 from dyl10s/Remove-Unknown-Check
Allow API request to be made if a PR is in an "UNKNOWN" state
2020-12-14 21:01:23 +01:00
Mislav Marohnić
cee4f853dc
Merge pull request #2580 from ismaell/ldflags-fix
Filter flags taken from LDFLAGS into CGO_LDFLAGS
2020-12-14 20:30:56 +01:00
Nate Smith
46f2eae88f
Merge pull request #2612 from yzgyyang/patch-1
Document installation instructions for FreeBSD
2020-12-14 13:15:59 -06:00
Guangyuan Yang
1fb542250a
Document installation instructions for FreeBSD 2020-12-14 13:51:36 +08:00
Sam Coe
dee7077fcf
Extract shared comment and reaction group code 2020-12-09 14:35:29 -05:00
Sam Coe
efc05dee90
Use spinner helper 2020-12-09 13:50:08 -05:00
Dylan Strohschein
f853a4b0e2 Allow API request to be made if the PR is in an unknown state 2020-12-09 00:25:21 +00:00
Ismael Luceno
d7f68e9ee2 Filter flags taken from LDFLAGS into CGO_LDFLAGS
Make sure we take only flags compatible with cgo.

Solves: https://github.com/cli/cli/issues/2577
2020-12-08 22:39:38 +01:00
Sam Coe
9f101ff0a2
Add comments to pr view 2020-12-08 14:18:05 -05:00
Sam Coe
b2edf782cf
Reverse order of issue lookup checks 2020-12-08 14:16:40 -05:00
Sam Coe
bec5e0cd77
Address PR comments 2020-12-08 10:24:02 -05:00
Sam Coe
bad5a59427
Update non-tty comment output 2020-12-07 14:25:05 -05:00
Sam Coe
8c5e5a3820
Appease the linter 2020-12-07 14:25:05 -05:00
Sam Coe
c843a4fa13
Add issue comment viewing 2020-12-07 14:25:04 -05:00
Mislav Marohnić
ada59236c6 Add workflow to the list of default OAuth scopes we request
Since GitHub CLI now offers to authenticate your Git as well, the token
we request here will be used for git pushes. Since we do anticipate our
users making edits to their GitHub Actions workflow files, we want them
to be able to push their changes, and this scope allows that.
2020-12-07 20:12:58 +01:00
Mislav Marohnić
38ea595ce2 Fix refresh test 2020-12-07 20:07:20 +01:00
Mislav Marohnić
bc81282a6c Merge remote-tracking branch 'origin' into git-credentials 2020-12-07 20:02:08 +01:00
Mislav Marohnić
3c76eb15a4 Add tests for auth git-credential command 2020-12-07 20:01:53 +01:00
Mislav Marohnić
381e83e6e5 Extend git credential prompt to auth refresh 2020-12-07 20:01:16 +01:00
Mislav Marohnić
c39dc28fa1 Rename auth/client to auth/shared 2020-12-07 17:08:42 +01:00
Pete Woods
03949a4d72
Build static binaries
Fixes #2555
2020-12-07 15:49:58 +00:00
Mislav Marohnić
f4152454f2
Merge pull request #2472 from cristiand391/preserve-metadata-state
Prompt: avoid resetting PR/issue metadata
2020-12-03 18:51:29 +01:00
Mislav Marohnić
8db2027c99 Allow interactive pr create even if we failed to look up commits 2020-12-03 18:02:24 +01:00
Mislav Marohnić
2b4372bc3a AskStubber now throws a more descriptive error when stubs do not match 2020-12-03 17:51:58 +01:00
Mislav Marohnić
be39f4363b Make MetadataSurvey testable by accepting an interface 2020-12-03 17:47:40 +01:00
Mislav Marohnić
d6add864b8 Ensure efficient resolving of issue/pr create metadata to GraphQL IDs
For metadata types chosen in interactive flow, we fetch all records from
the API in order to be able to display a multi-select interface.

For metadata defined via command-line flags, we resolve records that can
be looked up directly, avoiding fetching the entirety of expensive
datasets (e.g. all members of an organization) if we can.

The new approach ensures efficient fetching when interactive flow is
combined with values from flags.
2020-12-03 15:53:13 +01:00
Mislav Marohnić
8e1f736775
Merge pull request #2519 from cli/issue-create-browser-fix
Fix respecting chosen action in interactive `issue create`
2020-12-02 13:02:16 +01:00
Sam
0ade39351a
Merge pull request #2521 from cli/fix-env-auth-token
Properly check env auth tokens in CheckAuth
2020-12-01 21:08:59 -05:00
Mislav Marohnić
be759785f0 Fix "Continue in browser" for pr create coming from forks
Ensures that the `owner:` prefix is present when referencing the head branch
2020-12-01 21:23:39 +01:00
Mislav Marohnić
a84b9f09d4
Merge pull request #2456 from ismaell/build-flags
Simplify build flags setup
2020-12-01 20:52:32 +01:00
Mislav Marohnić
d74086da92
Merge pull request #2505 from nilsleiffischer/patch-1
Fix typo in an error message
2020-12-01 20:42:31 +01:00
Mislav Marohnić
faa1e44f52
Merge pull request #2455 from ismaell/install-target
Add make (un)install targets for POSIX systems 

Fixes #293
2020-12-01 20:33:37 +01:00
Mislav Marohnić
6f689ff051 Document make install 2020-12-01 20:31:20 +01:00
Sam Coe
e21c5100fa
Properly check env auth tokens in CheckAuth 2020-12-01 11:44:14 -05:00
Mislav Marohnić
df2ca9c9f9 Fix browser URL test on Windows 2020-12-01 15:55:40 +01:00
Mislav Marohnić
c92f416cc0 Simplify make install/uninstall 2020-12-01 15:46:18 +01:00