Mislav Marohnić
a77f3ddb49
Merge pull request #2575 from cli/pr-view-comments
...
Add ability to view comments with `pr view`
2020-12-15 16:31:03 +01:00
Mislav Marohnić
1e4fa60478
Merge pull request #2462 from cli/view-comments
...
Add issue comment viewing
2020-12-15 16:22:32 +01:00
Mislav Marohnić
b1f93426eb
Merge pull request #2449 from cli/git-credentials
...
Set up git authentication when logging in to gh
2020-12-15 16:14:07 +01:00
Sam Coe
dee7077fcf
Extract shared comment and reaction group code
2020-12-09 14:35:29 -05:00
Sam Coe
efc05dee90
Use spinner helper
2020-12-09 13:50:08 -05:00
Dylan Strohschein
f853a4b0e2
Allow API request to be made if the PR is in an unknown state
2020-12-09 00:25:21 +00:00
Sam Coe
9f101ff0a2
Add comments to pr view
2020-12-08 14:18:05 -05:00
Sam Coe
b2edf782cf
Reverse order of issue lookup checks
2020-12-08 14:16:40 -05:00
Sam Coe
bec5e0cd77
Address PR comments
2020-12-08 10:24:02 -05:00
Sam Coe
bad5a59427
Update non-tty comment output
2020-12-07 14:25:05 -05:00
Sam Coe
8c5e5a3820
Appease the linter
2020-12-07 14:25:05 -05:00
Sam Coe
c843a4fa13
Add issue comment viewing
2020-12-07 14:25:04 -05:00
Mislav Marohnić
38ea595ce2
Fix refresh test
2020-12-07 20:07:20 +01:00
Mislav Marohnić
bc81282a6c
Merge remote-tracking branch 'origin' into git-credentials
2020-12-07 20:02:08 +01:00
Mislav Marohnić
3c76eb15a4
Add tests for auth git-credential command
2020-12-07 20:01:53 +01:00
Mislav Marohnić
381e83e6e5
Extend git credential prompt to auth refresh
2020-12-07 20:01:16 +01:00
Mislav Marohnić
c39dc28fa1
Rename auth/client to auth/shared
2020-12-07 17:08:42 +01:00
Mislav Marohnić
f4152454f2
Merge pull request #2472 from cristiand391/preserve-metadata-state
...
Prompt: avoid resetting PR/issue metadata
2020-12-03 18:51:29 +01:00
Mislav Marohnić
8db2027c99
Allow interactive pr create even if we failed to look up commits
2020-12-03 18:02:24 +01:00
Mislav Marohnić
2b4372bc3a
AskStubber now throws a more descriptive error when stubs do not match
2020-12-03 17:51:58 +01:00
Mislav Marohnić
be39f4363b
Make MetadataSurvey testable by accepting an interface
2020-12-03 17:47:40 +01:00
Mislav Marohnić
d6add864b8
Ensure efficient resolving of issue/pr create metadata to GraphQL IDs
...
For metadata types chosen in interactive flow, we fetch all records from
the API in order to be able to display a multi-select interface.
For metadata defined via command-line flags, we resolve records that can
be looked up directly, avoiding fetching the entirety of expensive
datasets (e.g. all members of an organization) if we can.
The new approach ensures efficient fetching when interactive flow is
combined with values from flags.
2020-12-03 15:53:13 +01:00
Mislav Marohnić
8e1f736775
Merge pull request #2519 from cli/issue-create-browser-fix
...
Fix respecting chosen action in interactive `issue create`
2020-12-02 13:02:16 +01:00
Mislav Marohnić
be759785f0
Fix "Continue in browser" for pr create coming from forks
...
Ensures that the `owner:` prefix is present when referencing the head branch
2020-12-01 21:23:39 +01:00
Sam Coe
e21c5100fa
Properly check env auth tokens in CheckAuth
2020-12-01 11:44:14 -05:00
Mislav Marohnić
df2ca9c9f9
Fix browser URL test on Windows
2020-12-01 15:55:40 +01:00
Mislav Marohnić
dc1fad9cb0
Fix respecting chosen action in interactive issue create
...
The `action` variable started being shadowed in the `if` block in
6671106448
2020-12-01 15:28:39 +01:00
Max Horstmann
34d549e7b6
Document that reviewers can be teams ( #2465 )
...
Co-authored-by: Mislav Marohnić <mislav@github.com>
2020-11-26 17:31:15 +01:00
Zach Boyle
1135e5e3ed
set delete-branch merge flag default to false ( #2466 )
...
Co-authored-by: Divya Ramanathan <ramanad@umich.edu>
2020-11-26 11:54:28 +01:00
Cristian Dominguez
ab05736b98
don't reset previously added metadata
2020-11-25 13:30:54 -03:00
Cristian Dominguez
ea50666c30
Prompt: avoid resetting PR/issue metadata if no option is selected
2020-11-24 13:49:04 -03:00
vilmibm
cf37ce7463
no shorthand for --recover
2020-11-23 11:24:28 -08:00
vilmibm
d6e84a75fb
switch to recover instead of resubmit
2020-11-23 11:21:34 -08:00
vilmibm
1d408eb30d
linter appeasement
2020-11-23 11:21:28 -08:00
vilmibm
f68909b7a8
use TempFile though the testing is gross
2020-11-23 11:21:28 -08:00
vilmibm
fffd315a7e
fix dumb test
2020-11-23 11:21:28 -08:00
vilmibm
d300526318
preserve and restore issue/pr input on failure
2020-11-23 11:21:28 -08:00
vilmibm
e92cd43259
add IOStreams.ReadUserFile
2020-11-23 11:21:28 -08:00
Mislav Marohnić
d56d92c908
If git credential helper is non-defined, set gh as credential helper
2020-11-23 20:20:05 +01:00
Josh Soref
ded92972cd
spelling: template
2020-11-21 21:43:51 -05:00
Josh Soref
ec82d3c47e
spelling: settings
2020-11-21 21:43:51 -05:00
Josh Soref
76bd377253
spelling: error
2020-11-21 21:43:51 -05:00
Josh Soref
861d350440
spelling: dunno
2020-11-21 21:43:51 -05:00
Josh Soref
ddd438d5e1
spelling: dismissed
2020-11-21 21:43:51 -05:00
Josh Soref
e58b2dbe92
spelling: chestnuts
2020-11-21 21:43:51 -05:00
Josh Soref
0e681ca6c4
spelling: beginning
2020-11-21 21:43:46 -05:00
Mislav Marohnić
e36c9029d3
Fix broken tests
2020-11-20 20:33:08 +01:00
Mislav Marohnić
91d2adc134
Avoid re-requesting username if we already have it
2020-11-20 19:36:26 +01:00
Mislav Marohnić
67672fa88c
Prime user's git HTTPS credentials on auth login
2020-11-20 19:36:04 +01:00
Nate Smith
05a1a25271
match parent repo protocol when forking ( #2434 )
...
* match parent repo protocol when forking
* guard against nil and prefer PushURL
2020-11-20 12:00:49 -06:00
