Commit graph

3037 commits

Author SHA1 Message Date
Neel Redkar
a89fa1ebed add ability to force checkout 2021-01-22 22:29:01 +01:00
Mislav Marohnić
77cc378ae0
Merge pull request #2004 from marclop/f/add-self-assign-flag-to-issue-create
Allow assigning to or filtering by special `@me` keyword
2021-01-22 22:17:24 +01:00
Mislav Marohnić
e334a1f10c Add docs for using @me to reference self 2021-01-22 22:14:47 +01:00
Mislav Marohnić
73da25a96d Use concrete type instead of an interface to avoid forced casting 2021-01-22 22:05:33 +01:00
Mislav Marohnić
28c2d042e7 Extend @me replacing behavior to issue list 2021-01-22 22:05:33 +01:00
Marc Lopez
6ad0c57a31 issue/pr create: add "@me" syntax to self-assign
Signed-off-by: Marc Lopez <marc5.12@outlook.com>
2021-01-22 20:41:17 +01:00
Mislav Marohnić
7fecaaa8e2
Merge pull request #2740 from Matt-Gleich/homedir
Refactor to use os.UserHomeDir()
2021-01-22 20:29:39 +01:00
Mislav Marohnić
64fda21116 Avoid ever invoking go-homedir when config was found in a new location 2021-01-22 20:22:32 +01:00
Matthew Gleich
7d9461b819 ♻️ Refactor to use os.UserHomeDir() 2021-01-22 18:51:28 +01:00
Sam
188ff13d28
Merge pull request #2785 from n1lesh/auth-status-fail
Add fail message for non-existent hostname
2021-01-22 08:56:17 -08:00
Sam Coe
71fd2fa24c
Fix up test 2021-01-22 08:50:09 -08:00
Sam Coe
5e10638b0e
Merge branch 'trunk' into auth-status-fail 2021-01-22 08:46:24 -08:00
Mislav Marohnić
bdce08a793
Merge pull request #2801 from cli/cmd-stub-new
Deprecate `test` package
2021-01-22 17:34:35 +01:00
Mislav Marohnić
06cf2c9f81 Merge remote-tracking branch 'origin' into cmd-stub-new 2021-01-22 16:31:29 +01:00
Nate Smith
4d28c79192
Merge pull request #2810 from ptxmac/ptx/pr-merge-body
Add body argument to `pr merge` command.
2021-01-21 15:25:42 -08:00
vilmibm
6decf4384f simplify slightly, add tests 2021-01-21 15:18:08 -08:00
vilmibm
8624a9397e remove stray binary 2021-01-21 14:57:30 -08:00
Nate Smith
d25938e223
Merge pull request #2808 from KarelCoudijzer/fork-hang
Show progress while creating a new pull request
2021-01-21 14:54:15 -08:00
vilmibm
05d39ebd0d remove garbling spinner
one of the three new spinners produced less than ideal output when a
push happened; the other two do enhance the create experience and i
think we can get away without one for push.
2021-01-21 14:53:19 -08:00
Nate Smith
3a9e47bf1b
Merge pull request #2664 from cristiand391/gist-friendly-error
Print friendly error when 'gh gist <command>' is missing required argument
2021-01-21 14:41:03 -08:00
Nate Smith
29805a4003
Merge pull request #2588 from cdce8p/gh-clone-fetch
Only fetch default branch when adding upstream remote
2021-01-21 12:57:10 -08:00
vilmibm
b906826a68 i like trunk 2021-01-21 12:56:53 -08:00
vilmibm
dcedd32249 use newer command stubbing in tests 2021-01-21 12:32:40 -08:00
Nate Smith
4860cccd72
Merge pull request #2282 from cristiand391/repo-fork-gitflags
Add support for git flags in gh repo fork
2021-01-21 12:11:42 -08:00
vilmibm
48c89076f6 add positive case test 2021-01-21 12:04:19 -08:00
vilmibm
a27a94f8b5 Merge remote-tracking branch 'origin/trunk' into repo-fork-gitflags 2021-01-21 11:58:20 -08:00
Nate Smith
14b8047032
Merge pull request #2803 from cli/expectlines-deprecate
Deprecate `test.ExpectLines`
2021-01-21 11:45:20 -08:00
Sam
938f6f4bdd
Merge pull request #2809 from cli/deadcode
delete unused parameter
2021-01-21 09:56:15 -08:00
Sam
948088a143
Merge pull request #2776 from cli/pr-comments
Comment on pull requests
2021-01-21 09:55:52 -08:00
Mislav Marohnić
a70b69e359
Bring the "Press Enter" UI closer to the authentication experience
- "Press Enter" is both bold
- "Enter" is capitalized
- The prompt ends with "..."
2021-01-21 09:47:38 -08:00
Sam Coe
a26fba7800
Comment on pull requests 2021-01-21 09:47:38 -08:00
Mislav Marohnić
10b1314dc1 Hide ssh-key command until it's ready for prime-time 2021-01-21 17:55:44 +01:00
Mislav Marohnić
f89346f335
Merge pull request #2748 from cli/makefile-rewrite
Port build tasks to Go script
2021-01-21 17:36:36 +01:00
Mislav Marohnić
ad62d6a471
Merge pull request #2798 from cli/pr-merge-crossrepo
Handle case when a cross-repo PR was already merged
2021-01-21 17:36:00 +01:00
Mislav Marohnić
4158209d50
Merge pull request #2811 from cli/utils-spinner-buh-bye
Retire utils.Spinner in favor of IOStreams.StartProgressIndicator
2021-01-21 17:34:39 +01:00
Mislav Marohnić
3673a9beb2 Add more documentation for script/build.go 2021-01-21 17:16:11 +01:00
Mislav Marohnić
f1a9da40a4
Merge pull request #2812 from cli/updater-dev-version-match
Update notifier: avoid false positives when gh is built from source
2021-01-21 15:11:23 +01:00
Nate Smith
655728965d
Merge pull request #1882 from dfireBird/remote-renaming-847
feat: implement prompt for remote renaming
2021-01-20 16:19:10 -08:00
vilmibm
509e5dd0c9 fix tests 2021-01-20 16:10:56 -08:00
vilmibm
99c312e8ce accept a remote name instead of doing magic remote naming in repo fork 2021-01-20 15:32:19 -08:00
vilmibm
03f99a0140 Merge remote-tracking branch 'origin/trunk' into remote-renaming-847 2021-01-20 15:10:20 -08:00
Nate Smith
5430728a0a
Merge pull request #2813 from cli/token-from-env-err
More descriptive error when aborting auth due to environment variables
2021-01-20 15:06:52 -08:00
Björn Heinrichs
c9f79271b1
Add --maintainer-edit flag (#2250)
* Add --maintainer-edit flag

Closes #2213 while retaining backwards compatibility.

* Fix linting

* Adjust documentation and validation

* Negate logic and fix build errors

* rename to no-maintainer-edit

* test

* use a positive option instead of negative

Co-authored-by: vilmibm <vilmibm@github.com>
2021-01-20 14:51:27 -08:00
Sam
3bec668aaa
Merge pull request #2757 from cli/review-comments
Display reviews when viewing pull requests
2021-01-20 12:22:03 -08:00
Sam Coe
b9b1079493
Display reviews when viewing pull requests 2021-01-20 12:15:25 -08:00
Mislav Marohnić
dcf5a27f53
Merge pull request #1862 from edualb/trunk
[#1755] SSH key management (gh ssh-key list)
2021-01-20 20:47:21 +01:00
Mislav Marohnić
4a2cc8d2a4 Simplify ssh-key list
Do not require nor request `read:public_key` scope by default.
2021-01-20 20:23:57 +01:00
edualb
e26a1b98a1 add ssh-key command 2021-01-20 20:23:38 +01:00
Cristian Dominguez
2086d135f3
Respect system/user timezone in API requests (#2630)
* Respect system/user timezone in API requests

* Fall back to a known timezone if TZ is not set

Co-authored-by: Cristian Dominguez <cristiand391@users.noreply.github.com>
2021-01-20 10:44:46 -08:00
Mislav Marohnić
c9407b2629 More descriptive error when aborting auth due to environment variables
Old message:

    read-only token in GH_TOKEN cannot be modified

This message was vague and some users did not understand that this
refers to the value that is read from environment variables.

New message:

    $ GH_TOKEN=123 ghd auth login -h github.com
    The value of the GH_TOKEN environment variable is being used for authentication.
    To have GitHub CLI store credentials instead, first clear the value from the environment.
2021-01-20 18:27:35 +01:00