Commit graph

8118 commits

Author SHA1 Message Date
Tyler McGoffin
aaf4c4e4e3 Clean up auth-login-logout acceptance test with native functionality
The previous commit introduced two new functions, setEnvVar and
deleteEnvVar that are duplicative of functionality native to testscripts.
This commit switches to the native functionality and removes the
duplicative functions introduced in the previous commit.

Additionally, it removes the `--token` flag that was added to
`gh auth login`
2024-10-21 16:42:48 -07:00
Tyler McGoffin
52daa9cf7d Add --token flag to gh auth login to accept a PAT as a flag
Additionally, this commit adds acceptance testing for `gh auth login` and
`gh auth logout`.

The --token flag was necessary for adding testing for `gh auth login`
because the current implementation with `--with-token` appears to be
broken. It hangs, waiting for user input, but user input doesn't exit it.

Additionally, it appears that `--with-token` is intended to allow for TTY
input of an auth token, but it isn't implemented.

`--with-token` does work when used with the redirect operator `<` when the
token is saved in a file. However, due to limitations of testscripts, I
could not use a file for saving the token in a repeatable manner. Thus,
implementing the `--token` flag seemed like a quick solution to validate
that the direction I was going during testing was valid.

Whether the flag stays or not is up for discussion, and I'd love to get
input on that from the team.
2024-10-21 16:38:10 -07:00
Tyler McGoffin
665e814c5d Setup acceptance testing for auth and tests for auth-token and auth-status 2024-10-21 16:36:05 -07:00
Kynan Ware
6dab689718
Merge pull request #9794 from cli/kw/cli-9699-validate-local-extension-installs
Prevent local extension installations with invalid names and conflicts with core commands and other extensions
2024-10-21 13:40:09 -06:00
Andy Feller
1886d1b44b
Merge pull request #9782 from cli/andyfeller/testscripts-secret
Add acceptance tests for `secret` commands
2024-10-21 15:33:31 -04:00
bagtoad
daec7a0e0e Check extOwner for no value instead 2024-10-21 13:28:37 -06:00
bagtoad
35aa8521c4 Fix tests for invalid extension name 2024-10-21 12:47:14 -06:00
bagtoad
cc32f33583 Refactor to remove code duplication 2024-10-21 12:37:27 -06:00
Phill MV
857854d1b3
Merge pull request #9742 from cli/phillmv/fail-verification-if-no-attestations
`LiveSigstoreVerifier.Verify` should error if no attestations are present
2024-10-21 13:01:37 -04:00
Phill MV
a8b3f050ac
Merge branch 'trunk' into phillmv/fail-verification-if-no-attestations 2024-10-21 12:49:41 -04:00
Andy Feller
b3c0c39f47 Merge branch 'trunk' into andyfeller/testscripts-secret 2024-10-21 12:49:09 -04:00
Kynan Ware
d2a9d1c90b
Merge pull request #9786 from cli/kw/github-cli-590-add-search-acceptance-tests
Add acceptance tests for `search` command
2024-10-21 10:34:19 -06:00
Kynan Ware
e39a78ea29
Merge branch 'trunk' into kw/github-cli-590-add-search-acceptance-tests 2024-10-21 10:23:00 -06:00
bagtoad
1736de2cd1 Fix single quote not expanding vars 2024-10-21 10:20:37 -06:00
Andy Feller
acf62dacf2 Address @williammartin PR feedback 2024-10-21 11:53:05 -04:00
bagtoad
6923fb5cc8 add validation for local ext install 2024-10-20 16:37:40 -06:00
Andy Feller
f4f161c096 Refactor gh secret testscript
This is a bit of a refactor based on the work done in `gh workflow` as a better approach to verify secrets created are what we expect.

Changes made:

1. Removed `env2lower` as it wasn't being used in testscripts
2. Added `replace` custom command to deal with testing organization workflow secrets
3. Refactored secret testscripts to create and run workflow that tests the value of the secret provided
4. Minor reordering of test `acceptance` test functions as appending to the end is confusing and adds conflicts
5. Removed stdout TTY assertions
2024-10-18 15:56:03 -04:00
Tyler McGoffin
92ff87c6b7
Merge pull request #9783 from cli/jtmcg/testscripts-repo
Add acceptance tests for `repo` commands
2024-10-18 09:55:16 -07:00
Tyler McGoffin
ba324d85eb Wrap true in '' in repo-fork-sync 2024-10-18 09:37:30 -07:00
Tyler McGoffin
3f4a2aea2f Rename acceptance test directory from repos to repo 2024-10-18 09:37:30 -07:00
Tyler McGoffin
6c3ad5011b Remove unnecessary flags from repo-delete testscript 2024-10-18 09:31:02 -07:00
Tyler McGoffin
25f2956e67 Replace LICENSE
Makefile
README.md
acceptance
api
bin
build
cmd
context
docs
git
go.mod
go.sum
internal
pkg
script
share
test
utils commands with
2024-10-18 09:31:02 -07:00
Tyler McGoffin
ee0d9ab901 Wrap boolean strings in '' so it is clear they are strings 2024-10-18 09:31:02 -07:00
Tyler McGoffin
a5a77532df Remove unnecessary gh auth setup-git steps 2024-10-18 09:31:02 -07:00
Tyler McGoffin
e7549c93f9 Cleanup some inconsistencies and improve collapse some functionality 2024-10-18 09:31:02 -07:00
Tyler McGoffin
95ed11d9ba Add acceptance tests for repo deploy-key add/list/delete 2024-10-18 09:31:02 -07:00
Tyler McGoffin
96fa8534da Add acceptance tests for repo-fork and repo-sync 2024-10-18 09:31:02 -07:00
Tyler McGoffin
7508131356 Add acceptance test for repo-set-default 2024-10-18 09:31:02 -07:00
Tyler McGoffin
c572edbfd7 Add acceptance test for repo-edit 2024-10-18 09:31:02 -07:00
Tyler McGoffin
fb6f7733c4 Add acceptance tests for repo-list and repo-rename 2024-10-18 09:31:02 -07:00
Tyler McGoffin
0c632d7c4e Acceptance testing for repo-archive and repo-unarchive 2024-10-18 09:31:02 -07:00
Tyler McGoffin
60e20ee531 Add acceptance test for repo-clone 2024-10-18 09:31:02 -07:00
Tyler McGoffin
83cbdc4f36 Added acceptance test for repo-delete 2024-10-18 09:31:02 -07:00
Tyler McGoffin
18428671c3 Added test function for repos and repo-create test 2024-10-18 09:31:02 -07:00
bagtoad
b361cf4495 Implement acceptance tests for search commands 2024-10-18 10:17:34 -06:00
Andy Feller
1571a113c2 Merge branch 'trunk' into andyfeller/testscripts-secret 2024-10-18 09:46:25 -04:00
Tyler McGoffin
1313612245
Merge pull request #9701 from cli/jtmcg/9698
Add handling of empty titles for Issues and PRs
2024-10-17 14:57:57 -07:00
Tyler McGoffin
14acbe00a9 Remove . from test case for TestTitleSurvey 2024-10-17 14:45:35 -07:00
Tyler McGoffin
13ab02729b Clean up Title Survey empty title message code 2024-10-17 14:40:17 -07:00
Andy Feller
e335113706 Minor polish / consistency 2024-10-17 16:02:39 -04:00
Andy Feller
c1ccd81a7b
Merge pull request #9774 from cli/andyfeller/cli-9769-run-job-step-datetimes
Include startedAt, completedAt in run steps data
2024-10-17 13:36:38 -04:00
Andy Feller
6cb25c8a91
Merge pull request #9752 from cli/dependabot/go_modules/github.com/gabriel-vasile/mimetype-1.4.6
build(deps): bump github.com/gabriel-vasile/mimetype from 1.4.5 to 1.4.6
2024-10-17 13:05:32 -04:00
Andy Feller
e91052dd9b Fix typo in custom command doc 2024-10-17 10:59:54 -04:00
Andy Feller
7c534e6010 Refactor env2upper, env2lower; add docs
This commit refactors 2 new custom commands to work more like the native env command, allowing for multiple environment variables to be set.

Additionally, the documentation on acceptance tests have been expanded to list out custom commands.
2024-10-17 10:49:17 -04:00
William Martin
2850835b26
Merge pull request #9771 from cli/kw/github-cli-586-add-acceptance-tests-for-release-commands
Add acceptance tests for `release` commands
2024-10-17 16:28:55 +02:00
Andy Feller
5bbe69b1d1 Update secret note about potential failure
Environments are only supported for GitHub Actions with certain plans; `gh-acceptance-testing` at this time does not have this support.
2024-10-17 10:11:50 -04:00
Andy Feller
b1792403be Add testscripts for gh secret, helper cmds
These are initial testscripts for confidence around core `gh secret` subcommands around 1) repository, 2) repository environment, 3) organization secrets.

Each testscript exercises the 3 core subcommands of `gh secret`: 1) setting, 2) listing, and 3) deleting each type of secret.

Note should be made that repository environments do not exist for free accounts such as `gh-acceptance-testing`.
2024-10-17 10:09:08 -04:00
William Martin
24fc2db395 Remove stdout assertion from release 2024-10-17 16:06:14 +02:00
bagtoad
473faea573 Rename test files 2024-10-17 16:06:14 +02:00
bagtoad
a009933a16 Add acceptance tests for release commands 2024-10-17 16:06:10 +02:00