Commit graph

3553 commits

Author SHA1 Message Date
Andy Feller
ae5a71bbe4
Merge branch 'trunk' into add-issue-create-editor 2024-07-15 15:21:03 -04:00
notomo
28cc56cd45 Raise error if editor is used in non-tty mode 2024-07-13 11:01:48 +09:00
William Martin
f44f9a4e15
Merge pull request #9307 from cli/wm/9160-stateReason-panic
Fix panic when calling `gh pr view --json stateReason`
2024-07-12 17:46:45 +02:00
William Martin
940b54c708 Add tests for JSON field support on issue and pr view commands 2024-07-12 17:35:54 +02:00
Jesse Houwing
3b2ba9e1fa
docs: Update documentation for gh repo create to clarify owner 2024-07-12 13:20:43 +02:00
notomo
0b32e66bba Enable to use --web even though editor is enabled by config 2024-07-09 21:01:51 +09:00
notomo
0d37174076 Add editor hint message 2024-07-09 21:01:50 +09:00
notomo
50d0cb7279 Use prefer_editor_prompt config by issue create 2024-07-09 21:01:50 +09:00
notomo
30b3286533 Add prefer_editor_prompt config 2024-07-09 21:01:50 +09:00
notomo
8f77b4a23f Add issue create --editor 2024-07-09 21:01:50 +09:00
Corey Christous
9b40e0ca15
Update create.go 2024-07-07 13:57:05 -04:00
Zach Steindler
f972050dc9
gh attestation trusted-root subcommand (#9206)
Adds `trusted-root` subcommand to `gh attestation`.

For use in upcoming docs on how to do offline verification with artifact
attestations.

---------

Signed-off-by: Zach Steindler <steiza@github.com>
Co-authored-by: Fredrik Skogman <kommendorkapten@github.com>
2024-07-01 11:50:39 -04:00
William Martin
d4e33858ef Fetch variable selected repo relationship when required 2024-06-25 17:11:56 +02:00
William Martin
812889f390
Merge pull request #9128 from babakks/9118-add-json-fields-to-variable-get
Add `--json` option to `variable get` command
2024-06-25 15:30:49 +02:00
Phill MV
c9f9fac7dc
Update pkg/cmd/attestation/verify/verify.go
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-06-24 13:33:10 -04:00
Phill MV
c25dacc33e
Update pkg/cmd/attestation/verify/verify.go
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-06-24 13:32:51 -04:00
Phill MV
06607d3e95 s/originated/caller/ workflow 2024-06-24 10:05:58 -04:00
William Martin
d7c56bfb13 Remove beta note from attestation top level command 2024-06-24 15:46:00 +02:00
William Martin
846b6ec20b Fix whitespacing 2024-06-24 15:41:22 +02:00
Phill MV
8318e7a1de
Actually, let's keep download in beta for now. 2024-06-24 09:32:32 -04:00
Phill MV
40abc9a785 Removed beta note from gh at download. 2024-06-23 21:54:01 -04:00
Phill MV
152607e0e8 Removed beta note from gh at verify, clarified reusable workflows use case. 2024-06-23 21:53:09 -04:00
Forrin
c572383bda
Attestation Verification - Buffer Fix (#9198)
* swap scanner to readline for attestations
* replace readLine with readBytes
2024-06-14 13:55:58 -04:00
Andy Feller
5e7ba54b56
Merge pull request #9162 from joshuajtward/chore/GH-9038
feat: add `-a` flag to `gh run list`
2024-06-13 11:40:08 -04:00
Andy Feller
6190e269a0 Add gh run list tests for workflow selector
This commit adds tests to ensure disabled workflows are outputted as expected when called by name and the appropriate flags.
2024-06-13 11:30:38 -04:00
Wing
f647131e1d
Gracefully degrade when fetching annotations fails due to 403 (#9113)
Co-authored-by: William Martin <williammartin@github.com>
2024-06-13 14:33:06 +02:00
Josh Ward
c2f2753051 add comment to call out potentially brittle use of workflowShared 2024-06-13 09:24:18 +01:00
Phill MV
e8a13cfed3 replaced deprecated --json-result flag with --format=json in the gh at docstring. 2024-06-04 15:52:54 -04:00
Josh Ward
a10e532898 feat: add -a flag to gh run list 2024-06-03 09:53:34 +01:00
Meredith Lancaster
cd5562f5ac
Add signer-repo and signer-workflow flags to gh attestation verify (#9137)
* add signer-repo and signer-workflow flags

Signed-off-by: Meredith Lancaster <malancas@github.com>

* add check for SignerRepo option

Signed-off-by: Meredith Lancaster <malancas@github.com>

* add helper function and comment for clarity

Signed-off-by: Meredith Lancaster <malancas@github.com>

* update flag comment

Signed-off-by: Meredith Lancaster <malancas@github.com>

* reference correct field

Signed-off-by: Meredith Lancaster <malancas@github.com>

* move function to more relevant file

Signed-off-by: Meredith Lancaster <malancas@github.com>

* Update pkg/cmd/attestation/verify/verify.go

Co-authored-by: Zach Steindler <steiza@github.com>

* Update pkg/cmd/attestation/verify/verify.go

Co-authored-by: Zach Steindler <steiza@github.com>

* make all reusable workflow flags mutually exclusive

Signed-off-by: Meredith Lancaster <malancas@github.com>

* accept signer workflow without host

Signed-off-by: Meredith Lancaster <malancas@github.com>

* support client optionally providing host with signer workflow flag

Signed-off-by: Meredith Lancaster <malancas@github.com>

* comment

Signed-off-by: Meredith Lancaster <malancas@github.com>

* add tests for parsing signer workflow

Signed-off-by: Meredith Lancaster <malancas@github.com>

---------

Signed-off-by: Meredith Lancaster <malancas@github.com>
Co-authored-by: Zach Steindler <steiza@github.com>
2024-05-30 07:40:55 -06:00
Meredith Lancaster
8d0518645f
Add integration tests for gh attestation verify shared workflow use case (#9107)
* add initial shared workflow use case tests and test data

Signed-off-by: Meredith Lancaster <malancas@github.com>

* add more shared workflow tests

Signed-off-by: Meredith Lancaster <malancas@github.com>

* cleanup tests

Signed-off-by: Meredith Lancaster <malancas@github.com>

* pr feedback, replace shared with reusable

Signed-off-by: Meredith Lancaster <malancas@github.com>

* use demo repository with reusable workflow tests

Signed-off-by: Meredith Lancaster <malancas@github.com>

---------

Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-05-28 07:13:34 -06:00
Babak K. Shandiz
4aa6f8f2f3
Add createdAt field to tests
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-26 00:06:25 +01:00
Babak K. Shandiz
94dff4de04
Add createdAt field to Variable type
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-26 00:05:04 +01:00
Babak K. Shandiz
43e3e9410e
Add test for exporting as JSON
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-25 23:56:37 +01:00
Babak K. Shandiz
7add5a47bd
Add test for JSON output
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-25 23:56:36 +01:00
Babak K. Shandiz
840ddc5df5
Only populate selected repo information for JSON output
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-25 23:56:36 +01:00
Babak K. Shandiz
ab85baaab4
Add test to verify JSON exporter gets set
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-25 23:56:35 +01:00
Babak K. Shandiz
96549077cc
Add --json option support
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-25 23:56:35 +01:00
Babak K. Shandiz
9d8b783304
Use Variable type defined in shared package
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-25 23:56:35 +01:00
Babak K. Shandiz
2a5a4ce162
Add tests for JSON output
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-25 23:56:34 +01:00
Babak K. Shandiz
d8219426ba
Move Variable type and PopulateSelectedRepositoryInformation func to shared
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-25 23:56:34 +01:00
Arne Jørgensen
08a5589abe
Add a gh variable get FOO command (#9106)
Closes #9103.

---------

Co-authored-by: William Martin <williammartin@github.com>
2024-05-23 17:11:53 +02:00
William Martin
a66a646ca5 Add comment to pr diff regex 2024-05-23 11:59:56 +02:00
Katsuhiko Anda
e5e5c4fc43 Update regex in changedFilesNames to handle quoted paths 2024-05-23 03:13:16 +00:00
cawfeecake
105bafd2ec
fix: rename the Attempts field to Attempt; expose in gh run view and gh run ls (#8905)
Co-authored-by: William Martin <williammartin@github.com>
2024-05-22 14:39:13 +02:00
William Martin
7dc7b9838d
Merge pull request #9052 from jasonodonnell/trunk
Fix doc bug for gh run watch
2024-05-21 18:04:24 +02:00
Andy Feller
ff3a59802d
Merge pull request #9088 from leevic31/8535-remove-message-when-checking-for-extension-upgrades
Removed tty message when checking for extension upgrades
2024-05-20 08:55:52 -04:00
gabemontero
39e4cbd973 update generated content for man pages and website 2024-05-17 09:30:53 -04:00
gabemontero
77f964aa12 williammartin simplifications 2024-05-17 09:30:53 -04:00
gabemontero
c265753275 remove no-op if clause that returns 'No Aliases' 2024-05-17 09:30:53 -04:00