Mislav Marohnić
ae68da6520
Merge pull request #2230 from alissonbrunosa/fix-2179
...
Add support for ssh_config Include directives
2020-12-15 16:11:27 +01:00
Mislav Marohnić
935f6444ae
Refactor ssh parser for format compatibility & testability
...
- Per ssh_config(5), keywords and arguments may be separated by an `=`
sign as well as whitespace.
- When following the `Include` directive, skip directories that were
returned as the result of globbing.
- Respect the `Host` context when recursing into `Include`s
- Avoid having tests read from the actual filesystem.
- Avoid repeatedly looking up the home directory.
2020-12-15 15:59:18 +01:00
Alisson Santos
dc8698ee46
Make ssh parser to parse included config files
2020-12-15 15:37:17 +01:00
Mislav Marohnić
f3ea05f2e1
Merge pull request #2624 from nopeinomicon/patch-1
...
Add openSUSE distro package install instructions
2020-12-15 15:24:59 +01:00
Mislav Marohnić
cba15d0109
Clarify openSUSE Tumbleweed instructions
2020-12-15 15:16:33 +01:00
Emily Roberts
b8522f683c
Add openSUSE distro package install instructions
...
Added the instructions to install the GitHub CLI from the openSUSE distribution repositories
2020-12-15 01:17:44 -07:00
Mislav Marohnić
c765c71e47
Merge pull request #2556 from pete-woods/build-static-binaries
...
Build static binaries on Linux
2020-12-14 21:04:15 +01:00
Mislav Marohnić
3ad9f39ec4
Merge pull request #2582 from dyl10s/Remove-Unknown-Check
...
Allow API request to be made if a PR is in an "UNKNOWN" state
2020-12-14 21:01:23 +01:00
Mislav Marohnić
cee4f853dc
Merge pull request #2580 from ismaell/ldflags-fix
...
Filter flags taken from LDFLAGS into CGO_LDFLAGS
2020-12-14 20:30:56 +01:00
Nate Smith
46f2eae88f
Merge pull request #2612 from yzgyyang/patch-1
...
Document installation instructions for FreeBSD
2020-12-14 13:15:59 -06:00
Guangyuan Yang
1fb542250a
Document installation instructions for FreeBSD
2020-12-14 13:51:36 +08:00
Dylan Strohschein
f853a4b0e2
Allow API request to be made if the PR is in an unknown state
2020-12-09 00:25:21 +00:00
Ismael Luceno
d7f68e9ee2
Filter flags taken from LDFLAGS into CGO_LDFLAGS
...
Make sure we take only flags compatible with cgo.
Solves: https://github.com/cli/cli/issues/2577
2020-12-08 22:39:38 +01:00
Pete Woods
03949a4d72
Build static binaries
...
Fixes #2555
2020-12-07 15:49:58 +00:00
Mislav Marohnić
f4152454f2
Merge pull request #2472 from cristiand391/preserve-metadata-state
...
Prompt: avoid resetting PR/issue metadata
2020-12-03 18:51:29 +01:00
Mislav Marohnić
8db2027c99
Allow interactive pr create even if we failed to look up commits
2020-12-03 18:02:24 +01:00
Mislav Marohnić
2b4372bc3a
AskStubber now throws a more descriptive error when stubs do not match
2020-12-03 17:51:58 +01:00
Mislav Marohnić
be39f4363b
Make MetadataSurvey testable by accepting an interface
2020-12-03 17:47:40 +01:00
Mislav Marohnić
d6add864b8
Ensure efficient resolving of issue/pr create metadata to GraphQL IDs
...
For metadata types chosen in interactive flow, we fetch all records from
the API in order to be able to display a multi-select interface.
For metadata defined via command-line flags, we resolve records that can
be looked up directly, avoiding fetching the entirety of expensive
datasets (e.g. all members of an organization) if we can.
The new approach ensures efficient fetching when interactive flow is
combined with values from flags.
2020-12-03 15:53:13 +01:00
Mislav Marohnić
8e1f736775
Merge pull request #2519 from cli/issue-create-browser-fix
...
Fix respecting chosen action in interactive `issue create`
2020-12-02 13:02:16 +01:00
Sam
0ade39351a
Merge pull request #2521 from cli/fix-env-auth-token
...
Properly check env auth tokens in CheckAuth
2020-12-01 21:08:59 -05:00
Mislav Marohnić
be759785f0
Fix "Continue in browser" for pr create coming from forks
...
Ensures that the `owner:` prefix is present when referencing the head branch
2020-12-01 21:23:39 +01:00
Mislav Marohnić
a84b9f09d4
Merge pull request #2456 from ismaell/build-flags
...
Simplify build flags setup
2020-12-01 20:52:32 +01:00
Mislav Marohnić
d74086da92
Merge pull request #2505 from nilsleiffischer/patch-1
...
Fix typo in an error message
2020-12-01 20:42:31 +01:00
Mislav Marohnić
faa1e44f52
Merge pull request #2455 from ismaell/install-target
...
Add make (un)install targets for POSIX systems
Fixes #293
2020-12-01 20:33:37 +01:00
Mislav Marohnić
6f689ff051
Document make install
2020-12-01 20:31:20 +01:00
Sam Coe
e21c5100fa
Properly check env auth tokens in CheckAuth
2020-12-01 11:44:14 -05:00
Mislav Marohnić
df2ca9c9f9
Fix browser URL test on Windows
2020-12-01 15:55:40 +01:00
Mislav Marohnić
c92f416cc0
Simplify make install/uninstall
2020-12-01 15:46:18 +01:00
Mislav Marohnić
dc1fad9cb0
Fix respecting chosen action in interactive issue create
...
The `action` variable started being shadowed in the `if` block in
6671106448
2020-12-01 15:28:39 +01:00
Nils Leif Fischer
413ccb71cc
Delete an error message that is not useful (and had a typo)
2020-11-30 13:20:43 +01:00
Ismael Luceno
8d2881d5ea
Install manual pages
2020-11-29 21:01:38 +01:00
Ismael Luceno
da3287c26c
Add make (un)install targets for POSIX systems
...
The implementation imitates the behavior of build-systems generated by
GNU Automake.
Implemented targets:
- install
- install-strip
- uninstall
Implemented variables:
- DESTDIR
- prefix
- bindir
- INSTALL_STRIP_FLAG
Internal implementation details:
- install-bins variable collects user binaries to be installed
- install-dirs variable collects directories to be created
2020-11-29 21:01:38 +01:00
Max Horstmann
34d549e7b6
Document that reviewers can be teams ( #2465 )
...
Co-authored-by: Mislav Marohnić <mislav@github.com>
2020-11-26 17:31:15 +01:00
Mislav Marohnić
7c6574d8e9
Merge pull request #2480 from cli/bump-survey
...
Bump AlecAivazis/survey
2020-11-26 12:06:25 +01:00
Mislav Marohnić
08408805a2
Merge pull request #2479 from cli/prs-by-branch-order
...
Prioritize latest (open) PR when looking up PRs for a branch
2020-11-26 11:55:11 +01:00
Zach Boyle
1135e5e3ed
set delete-branch merge flag default to false ( #2466 )
...
Co-authored-by: Divya Ramanathan <ramanad@umich.edu>
2020-11-26 11:54:28 +01:00
Amanda Pinsker
504cfbc654
Merge pull request #2482 from cli/ds-docs
...
Add design system docs to contributing
2020-11-25 16:06:29 -08:00
Amanda Pinsker
436846a715
Add design system docs to contributing
2020-11-25 11:58:26 -08:00
Cristian Dominguez
ab05736b98
don't reset previously added metadata
2020-11-25 13:30:54 -03:00
Mislav Marohnić
e9e8f207cc
Bump AlecAivazis/survey
2020-11-25 14:52:13 +01:00
Mislav Marohnić
21e2544d73
Sort latest PRs first when looking up PRs for a branch
...
Fixes #2452
2020-11-25 12:06:35 +01:00
Vixb
37891a54d9
Update scoop install option ( #2478 )
...
Co-authored-by: Mislav Marohnić <mislav@github.com>
Co-authored-by: Jan Pokorný <JenomPokorny@gmail.com>
2020-11-25 11:40:30 +01:00
Cristian Dominguez
ea50666c30
Prompt: avoid resetting PR/issue metadata if no option is selected
2020-11-24 13:49:04 -03:00
Shubhankar Kanchan Gupta
9f84f0ffa1
Warn termux users with older Android versions ( #2467 )
...
Co-authored-by: Mislav Marohnić <mislav@github.com>
2020-11-24 12:56:26 +01:00
Nate Smith
959b1aae67
Merge pull request #2408 from cli/preserve-input
...
Preserve/restore pr and issue input
2020-11-23 13:39:43 -06:00
vilmibm
cf37ce7463
no shorthand for --recover
2020-11-23 11:24:28 -08:00
vilmibm
d6e84a75fb
switch to recover instead of resubmit
2020-11-23 11:21:34 -08:00
vilmibm
1d408eb30d
linter appeasement
2020-11-23 11:21:28 -08:00
vilmibm
f68909b7a8
use TempFile though the testing is gross
2020-11-23 11:21:28 -08:00