Commit graph

5289 commits

Author SHA1 Message Date
JP Ungaretti
aea8a0e021 Clean up code 2022-03-03 01:32:12 +00:00
JP Ungaretti
3582090fb8 Fix RPC call 2022-03-03 01:21:35 +00:00
JP Ungaretti
9e3b955163 Add cs jupyter 2022-03-01 22:38:35 +00:00
Mario Campos
97ea5e77b4
Fix obtained scope mapping to include implied scopes (#5256)
* Fix obtained scope mapping to include missing scopes

As is, `gotScopes` does not contain certain scopes because it doesn't check for the "special" scopes that imply other scopes. For example, the `repo` scope implies `repo:invite`.

* Add a comment in ScopesSuggestion explaining branch statements

* Delete whitespace to appease go-fmt
2022-03-01 14:37:58 +00:00
Mark Phelps
a9e92c9ed5
Fix HexToRGB panic (#5247) 2022-03-01 14:37:10 +00:00
dependabot[bot]
12f2e3cab0
Bump github.com/itchyny/gojq from 0.12.6 to 0.12.7 (#5263)
Bumps [github.com/itchyny/gojq](https://github.com/itchyny/gojq) from 0.12.6 to 0.12.7.
- [Release notes](https://github.com/itchyny/gojq/releases)
- [Changelog](https://github.com/itchyny/gojq/blob/main/CHANGELOG.md)
- [Commits](https://github.com/itchyny/gojq/compare/v0.12.6...v0.12.7)

---
updated-dependencies:
- dependency-name: github.com/itchyny/gojq
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-01 14:27:35 +00:00
Nate Smith
91c4a5d828
Merge pull request #5234 from markphelps/codespaces-accept-perms
Codespaces Create: Allow Accepting Permissions
2022-02-28 16:54:45 -06:00
Mislav Marohnić
25a4877f2e
Update triage.md (#5238) 2022-02-28 09:31:27 +01:00
Mark Phelps
dd5feda00a Update wording after consulting product 2022-02-25 17:32:08 -05:00
Mark Phelps
71f32376d0 Fix tests 2022-02-22 20:20:52 -05:00
Mark Phelps
707220a9b1 PR updates 2022-02-22 14:16:03 -05:00
Mark Phelps
1ea26f33d8 Add create test 2022-02-22 09:50:43 -05:00
Mislav Marohnić
cf4b73ff95
Merge pull request #5223 from cli/docs-improvements
Misc. docs improvements
2022-02-21 15:35:10 +01:00
Mislav Marohnić
57d0581504 Add note about git auth 2022-02-21 15:24:54 +01:00
Mislav Marohnić
112ca8bf91 Merge remote-tracking branch 'origin' into docs-improvements 2022-02-21 15:24:18 +01:00
Mislav Marohnić
2c981b70bf
Merge pull request #5221 from cli/string-enum-flag
Use StringEnumFlag helper in more places
2022-02-21 15:21:07 +01:00
Mislav Marohnić
9cbfe73140 Have core commands have consistent Short description 2022-02-18 18:39:30 +01:00
Mislav Marohnić
0f956c8502 auth login: clarify authentication alternatives 2022-02-18 18:39:30 +01:00
Mislav Marohnić
7235384f12 gh: list help topics in help output 2022-02-18 18:39:30 +01:00
Mislav Marohnić
286ba5e8dc issue/pr list: clarify search syntax 2022-02-18 18:39:30 +01:00
Mislav Marohnić
5f8bdd64da gh api: clarify how to pass API preview names 2022-02-18 18:39:30 +01:00
Mislav Marohnić
0f1aaae57c issue/pr comment: allow using editor in non-interactive mode
The user should be able to `gh config set prompt disabled` and still be
allowed to use `gh issue comment --editor`.
2022-02-18 18:38:55 +01:00
Mislav Marohnić
57f49d9f8a issue/pr comment: improve docs as it relates to editor 2022-02-18 18:38:44 +01:00
Mislav Marohnić
512208ca96 repo fork: tweak docs 2022-02-18 18:38:34 +01:00
Mislav Marohnić
19563c4a74 Use StringEnumFlag helper in more places 2022-02-18 12:52:47 +01:00
Mark Phelps
e7c2f973ae Support opting out of permissions 2022-02-17 15:11:12 -05:00
Jonathan Mayer
1eefda0b45
gh auth login: add git protocol flag (#5158)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-02-17 19:35:59 +00:00
Hanjingxue Boling
f4b4a4e18f
Update installation instructions for Fedora (#5204)
gh-cli has entered fedora's official repository and can be installed directly without adding a third-party repository.

Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-02-17 18:41:26 +00:00
Christian Gregg
c5dbf20ed4
Alias list as ls for all commands (#5214)
I always get tripped up whenever trying to list my codespaces, adding
`ls` as an alias to `list` feels natural enough.

Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-02-17 13:53:42 +01:00
Mark Phelps
84aad52b22
Merge branch 'cli:trunk' into codespaces-accept-perms 2022-02-16 10:08:49 -05:00
Mark Phelps
590acaa1d6 WIP 2022-02-15 19:35:53 -05:00
Josh Gross
c2a9c5a74b
Support filtering pull requests authored by GitHub Apps (#5180) 2022-02-15 19:36:06 +01:00
Mislav Marohnić
95b1e7f74e
Merge pull request #5019 from k-jun/fix/release-discussion-category
fix(release): discussion category with assets
2022-02-15 18:37:41 +01:00
Mislav Marohnić
5d36bcc4de Merge remote-tracking branch 'origin' into fix/release-discussion-category 2022-02-15 18:28:08 +01:00
Mislav Marohnić
72340076ae tests 2022-02-15 18:27:58 +01:00
Breno Silva
6e14426dfb
docs: improve repo edit docs (#5165)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-02-15 17:35:30 +01:00
Mislav Marohnić
3e0db567e8
Rotate our Windows signing certificates (#5196)
- The certificate pfx file is now read from WINDOWS_CERT_PFX
- The password to decode the pfx is in WINDOWS_CERT_PASSWORD
- Quit reading from desktop-secrets repo
- Switch osslsigncode to take in pfx instead of individual certs
- 🔥 obsolete setup scripts
2022-02-15 17:23:39 +01:00
Sam Coe
28d2b52769
release create: warn about unpushed local git tag (#5104)
If `gh release create <TAG>` was called and TAG exists locally but not on the remote, this warns about the unpushed tag to avoid recreating it on the remote. The user can pass a value for `--target` to silence the warning.
2022-02-15 16:36:37 +01:00
Nate Smith
fc5cbe8f1f
Merge pull request #5205 from cli/revert-4998
Revert changing the location of GPG key file
2022-02-14 14:48:05 -06:00
nate smith
32dada90ba revert PR 4998 2022-02-14 10:35:09 -06:00
Mislav Marohnić
bf83c660a1
Merge pull request #5143 from cli/pager-epipe-ignore
Ignore EPIPE errors when writing to a closed pager
2022-02-14 17:09:17 +01:00
Mislav Marohnić
0a5e220231 Ignore EPIPE errors when writing to a closed pager
While a gh command is writing stdout to a pager, the user may choose to
close the pager program before the pager has read all the data on its
standard input. In that case, the parent gh process will receive an
EPIPE error, which would bubble up its error handling and cause it to
print something like:

    write |1: broken pipe

Since this was caused by an explicit user action of closing the pager,
and since the user probably doesn't want to see this uninformative
error, this informs our global error handling of this error and causes
it to be ignored.
2022-02-10 16:42:00 +01:00
Mislav Marohnić
c9f44ffda9
Merge pull request #5186 from cli/credential-helper-fix
Fix authenticating git operations after `auth login --with-token`
2022-02-10 15:59:41 +01:00
Patrick Veverka
f6f8ba8b7b
Add display name for codespaces (#5044) 2022-02-09 16:15:03 +01:00
Mislav Marohnić
6701b526d1 Fix authenticating git operations after auth login --with-token
After completing the interactive `gh auth login` flow, the `hosts.yml`
config file will have been populated with both `oauth_token` and `user`
properties for the GitHub host. However, after `auth login --with-token`
only the `oauth_token` is persisted but no username.

This fixes `auth git-credential` behavior so it allows authentication
even if the `user` property is missing. It's entirely optional to send a
proper username for git authentication, since GitHub seems to ignore the
actual value sent and just focuses on the token itself.
2022-02-09 00:10:10 +01:00
dependabot[bot]
c3d451b9b6
Bump github.com/briandowns/spinner from 1.18.0 to 1.18.1 (#5182)
Bumps [github.com/briandowns/spinner](https://github.com/briandowns/spinner) from 1.18.0 to 1.18.1.
- [Release notes](https://github.com/briandowns/spinner/releases)
- [Commits](https://github.com/briandowns/spinner/compare/v1.18.0...v1.18.1)

---
updated-dependencies:
- dependency-name: github.com/briandowns/spinner
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-08 19:19:43 +01:00
endorama
825328031f
Add watch functionality to pr checks command (#4519)
* pr-checks: extract webMode

* pr-checks: extract checks information collection

* pr-checks: extract output utilities

* pr-checks: implement watch flag

* pr-checks: remove SIGINT interceptor

* pr-checks: exit with error if some task has failed

* update flags help text

* update default interval to 10s

* move interval flag parse to RunE

* refactor checksRunWatchMode to use infinite loop

* Refactor printTable function

* Refactor collect function

* Set up checksRun to use new refactored functions and simplify logic a bit

* Add tests

* Always set interval in opts

* use Duration flag

* Revert back to using int flag for consistency with run watch

* Use run watch screen clearing mechanism

* Re-add pager support

Co-authored-by: Sam Coe <samcoe@users.noreply.github.com>
2022-02-08 08:33:42 +01:00
Mislav Marohnić
b59cd63700
Merge pull request #5173 from joshmgross/joshmgross/gist-path-handling
Correctly handle Windows paths when creating gists
2022-02-07 20:06:32 +01:00
Josh Gross
f43574bfe0
Correctly handle Windows paths when creating gists 2022-02-06 23:21:20 +00:00
Yuki Hirasawa
4f0264e37b
spelling: possible (#5157) 2022-02-02 16:54:09 +01:00