Commit graph

18 commits

Author SHA1 Message Date
JP Ungaretti
3582090fb8 Fix RPC call 2022-03-03 01:21:35 +00:00
JP Ungaretti
9e3b955163 Add cs jupyter 2022-03-01 22:38:35 +00:00
Marwan Sulaiman
22c5269606
Fix flaky liveshare session test (#5111)
* Fix flaky liveshare session test

* typo

* PR comments
2022-01-27 11:20:50 -05:00
Jeff Hubbard
97d85d0ac0 Oops, left it as second from debugging 2021-10-28 16:33:13 -07:00
Jeff Hubbard
c18e54189c Adds a timeout context to the ssh waiter to prevent indefinite hanging 2021-10-27 15:40:49 -07:00
Mislav Marohnić
d68126af99 Avoid macOS prompt to allow incoming connections in liveshare tests
Listening on the localhost interface disallows connections from the
outside anyway, so the OS firewall doesn't have to prompt whether the
user wants to allow incoming connections to the Go process.
2021-10-14 14:23:36 +02:00
Jose Garcia
d5c9630fae
Merge pull request #4511 from cli/jg/keepalive-fix
codespace ssh: fix for nil logger on non-debugging scenarios
2021-10-13 14:44:10 -04:00
Jose Garcia
d6b5157eff Fix for nil logger on non-debugging scenarios 2021-10-13 14:15:26 -04:00
Marwan Sulaiman
b9bdef2b00
Add org scoped port forwarding + fix test formatting (#4497)
* Add org scoped port forwarding + fix test formatting

* Redesign port visibility

* Update pkg/cmd/codespace/ports.go

Co-authored-by: Jose Garcia <josebalius@github.com>

* Change sub command to privacy

* Example pr comment

* Fix test mock

* Fix test mock

Co-authored-by: Jose Garcia <josebalius@github.com>
2021-10-13 13:56:03 -04:00
Jose Garcia
5170a2931f Switch to standard lib log.Logger & support dfile
- --debug-file flag can now be used in conjuction with --debug to
  specify the debug file path
- Push out logger concerns to callers of liveshare
2021-10-12 15:45:05 -04:00
Jose Garcia
1aefc74378 Add more time between events 2021-10-07 16:48:09 -04:00
Jose Garcia
1ff58a3de7 Update docs, remove needless condition check 2021-10-07 16:39:43 -04:00
Jose Garcia
97cbdca84a Fix additional race in tests 2021-10-07 15:45:55 -04:00
Jose Garcia
2406f3f09a Fix races and remove unreachable code 2021-10-07 15:32:07 -04:00
Jose Garcia
8f5d6bb672 Tests for most of the new behavior
- Made the heartbeat interval configurable for easier testing
- Moved span to the top of connect to capture the full execution
2021-10-07 15:14:42 -04:00
Jose Garcia
55f4fcf05c Live Share session activity detection
- Session now accepts two new options: ClientName and Logger
- Port forwarder now supports a keepAlive parameter which when true,
  instructs the PF to call the session's keepAlive method.
- Port forwarder uses a new traffic monitor to detect I/O traffic and
  notify the session when applicable.
- The SSH command introduces a new debug flag which enables the command
  to log to a new temporary file. The file path is printed to the user.
2021-10-07 10:42:06 -04:00
Jose Garcia
53e4149c91 Update tests 2021-09-30 10:42:03 -04:00
Jose Garcia
f4a5f82312 Move internal/liveshare to pkg/liveshare 2021-09-30 10:34:27 -04:00