Andy Feller
b433792a44
Fix copilot replace test names
...
In refactoring how this parameter works, I forgot to update the related tests to match.
2025-07-16 15:09:13 -04:00
Andy Feller
5cf3d3b9a5
Use constant for Copilot name
...
Based on PR feedback from @bagtoad, this commit creates a new constant for the Copilot bot name, which is used in the assignee / reviewer selection as well as replacing `@copilot` when going to GitHub.com UI
2025-07-16 15:06:43 -04:00
Andy Feller
4f0a5807bf
Refactor CopilotReplacer logic based on PR feedback
...
Thanks to @bagtoad, this commit refactors the argument to `NewCopilotReplacer(bool)` from being where this is used to what it effect is has.
Because there is already precedence for display name being `<login> (<name>)`, I worried there would be confusion for `Copilot (AI)` being display name for assignees and reviewers but `Copilot` when going to GitHub.com UI. Instead, I renamed the argument based on whether the login is returned / replaced.
2025-07-16 14:42:11 -04:00
Andy Feller
e2bed653df
Implement actor and user assignee tests
2025-07-16 14:10:26 -04:00
Andy Feller
21202ff992
Improve comments from PR feedback
2025-07-16 08:47:12 -04:00
Andy Feller
fd1c31de59
Fix gh pr create tests from metadata change
...
These are the minimum fixes necessary to repair `gh pr create` tests after refactoring the underlying metadata resolution logic.
2025-07-11 15:32:17 -04:00
Andy Feller
554fe0f51f
Fix gh issue create tests, copilot web assign
...
This commit is primarily focused on fixing the existing `gh issue create` tests with the changes to the underlying queries retrieving the data for resolving metadata.
Additionally, a new test case for `gh issue create --web --assignee @copilot` was added to mirror existing tests. While exercising this capability, I found out the web UI apparently wants `copilot` instead of the `copilot-swe-agent` login, so changes to address that were a part of this commit.
2025-07-11 12:19:36 -04:00
Andy Feller
a8053d19a9
Resolve issue and PR metadata consistently
...
This commit refactors how `gh issue create` and `gh pr create` retrieve information needed to resolve metadata to be more in line with the approach used in `gh issue edit` and `gh pr edit`.
Previously, both commands used `prshared.fillMetadata(...)` function to retrieve assignees, reviewers, labels, and teams outside of `api.RepoMetadata(..)`. Now, these commands will consistently use the same logic and data for resolving metadata.
2025-07-11 10:21:17 -04:00
Andy Feller
49821b20f9
Add non-TTY issue create copilot test, todos
2025-07-08 15:19:09 -04:00
Andy Feller
c69f828019
Initial assign Copilot during issue create changes
...
- updated command documentation for new `--assignee @copilot` syntax
- updated `gh issue create` logic with feature detection for actor availability
- fixed bug where `--assignee` would not select default assignees due to login vs display name mismatch
- updated survey prompt logic to avoid parsing prompt options in favor of correlating with assignee / actor source
One thing that is not included in these changes is incorporating the GraphQL mutation to replace assignees with actors, which I will continue iterating on.
2025-07-02 16:22:12 -04:00
Daniel Krzeminski
b31f38c946
Fix: gh pr create prioritize --title and --body over --fill when --web is present ( #10547 )
...
* fix: prioritize title and body over autofill for prs
* fix: prioritize title and body over autofill tests
* refactor: collapse state conditions
---------
Co-authored-by: Babak K. Shandiz <babakks@github.com>
2025-06-24 12:54:43 +00:00
Andy Feller
2b89358543
Merge pull request #11161 from cli/andyfeller/111-golicenses-versioning-followup
...
Ensure automation uses pinned go-licenses version
2025-06-23 13:51:47 -04:00
Andy Feller
ce265d4ac2
Merge pull request #11160 from cli/kw/fix-broken-install-linux-links
...
Fix missing newline in install_linux.md
2025-06-23 13:32:07 -04:00
Andy Feller
728e973a20
Ensure automation uses pinned go-licenses version
2025-06-23 13:22:27 -04:00
Kynan Ware
74d10f8dec
Fix missing newline in install_linux.md
2025-06-23 11:16:20 -06:00
Kynan Ware
9ce1aeeb1c
Merge pull request #10823 from chax/install_solus
...
docs: install_linux.md: add Solus linux install instructions
2025-06-23 10:31:38 -06:00
Kynan Ware
802a75b19a
Apply suggestions from code review
2025-06-23 10:23:10 -06:00
Andy Feller
f7218561be
Merge pull request #11047 from cli/andyfeller/9422-license-compliance
...
Ensure lint workflow checks whether 3rd party license and code is up to date
2025-06-23 12:06:31 -04:00
Kynan Ware
8541d6e290
Merge branch 'trunk' into install_solus
2025-06-23 09:42:11 -06:00
Kynan Ware
51fd8edd85
Merge pull request #11158 from tMinamiii/chore/devcontainer-image-go-version
...
chore: update Go version to 1.24 in devcontainer configuration and docs
2025-06-23 09:23:16 -06:00
Andy Feller
b5867208a1
Update missed Go 1.23 references
2025-06-23 09:58:06 -04:00
TmINAMIII
6bfd4bbd77
chore: update Go version to 1.24 in devcontainer configuration
2025-06-22 01:57:48 +00:00
Andy Feller
11e8a8127d
Use make for license generation and checks
2025-06-20 16:53:11 -04:00
Andy Feller
4d1eb59c36
Use temp directory for license checks
2025-06-20 16:44:44 -04:00
Andy Feller
4e8d022448
Update 3rd party licenses
2025-06-20 16:26:59 -04:00
Andy Feller
98ea250ede
Merge branch 'trunk' into andyfeller/9422-license-compliance
2025-06-20 16:23:00 -04:00
Andy Feller
d4efe0bd0a
Merge pull request #11018 from ejahnGithub/eugene/release-verify
...
init release verify subcommands
2025-06-20 15:55:44 -04:00
Eugene
98d7135ccc
Merge branch 'trunk' into eugene/release-verify
2025-06-20 06:50:04 -07:00
ejahnGithub
169b909015
improve the description for gh release verify cmd
2025-06-19 10:18:23 -04:00
William Martin
dc7b22b659
Merge pull request #11149 from jinjingroad/trunk
...
chore: fix function name
2025-06-19 11:31:49 +02:00
jinjingroad
28d5de9d8e
chore: fix function name
...
Signed-off-by: jinjingroad <jinjingroad@sina.com>
2025-06-19 12:36:52 +08:00
Eugene
524aee8cfb
Merge branch 'trunk' into eugene/release-verify
2025-06-17 08:20:37 -07:00
William Martin
d9d0e14e85
Merge pull request #11145 from cli/kw/fix-step-order-in-codeql-workflow
...
Fix step order for CodeQL workflow
2025-06-17 17:03:43 +02:00
William Martin
b5613cdbbe
Merge pull request #10699 from laffer1/patch-1
...
Add instructions for MidnightBSD installation
2025-06-17 16:55:53 +02:00
Eugene
898bb42719
Merge branch 'trunk' into eugene/release-verify
2025-06-17 07:54:26 -07:00
William Martin
9cf0c73ae4
Merge pull request #10935 from MagneticNeedle/patch-1
...
docs: update install command for Debian
2025-06-17 16:54:02 +02:00
William Martin
6b36060d58
Update docs/install_linux.md
2025-06-17 16:43:25 +02:00
Kynan Ware
50e4a4ad15
Fix step order for CodeQL workflow
2025-06-17 08:41:14 -06:00
Vibhakar Solanki
1ac3f064f3
docs: update install command for Debian
...
Make sure that `sources.list.d` exists before trying to populate `github-cli.list`
2025-06-17 16:39:58 +02:00
William Martin
e51b03d989
Merge pull request #10888 from aconsuegra/ac/fix-acceptance-test-output
...
Fix expected error output of TestRepo/repo-rename-transfer-ownership
2025-06-17 16:26:16 +02:00
William Martin
fb35097dec
Merge pull request #11120 from cli/dependabot/go_modules/github.com/google/go-containerregistry-0.20.6
...
chore(deps): bump github.com/google/go-containerregistry from 0.20.3 to 0.20.6
2025-06-17 12:39:04 +02:00
dependabot[bot]
f55443d7b0
chore(deps): bump github.com/google/go-containerregistry
...
Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry ) from 0.20.3 to 0.20.6.
- [Release notes](https://github.com/google/go-containerregistry/releases )
- [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml )
- [Commits](https://github.com/google/go-containerregistry/compare/v0.20.3...v0.20.6 )
---
updated-dependencies:
- dependency-name: github.com/google/go-containerregistry
dependency-version: 0.20.6
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2025-06-17 10:05:53 +00:00
William Martin
fe3bf3eeca
Merge pull request #11142 from cli/bump-go-to-1.24
...
Bump go to 1.24
2025-06-17 12:04:08 +02:00
William Martin
49ed6c4681
Use t.Chdir in tests
2025-06-17 11:44:14 +02:00
William Martin
b4cd2273d8
Bump to Go 1.24
2025-06-17 11:44:14 +02:00
William Martin
86c251154e
Merge pull request #11121 from cli/11101-use-golangci-lint-version-2
...
Bump golangci-lint to v2
2025-06-17 11:43:14 +02:00
William Martin
d9a2ffbf06
Merge pull request #11123 from cli/dependabot/go_modules/github.com/in-toto/attestation-1.1.2
...
chore(deps): bump github.com/in-toto/attestation from 1.1.1 to 1.1.2
2025-06-17 10:07:05 +02:00
William Martin
ac6fe9c96b
Merge pull request #11134 from cli/11119-suggested-run-list-command-for-workflows-with-space-in-name-doesnt-work
...
Quote filenames suggested at the end of worklow run
2025-06-17 09:55:15 +02:00
Kynan Ware
6224368f2e
Merge pull request #11135 from cli/kw/improve-help-wanted-check
...
Improve help wanted check skipping logic
2025-06-16 13:29:59 -06:00
Andy Feller
14c2673d27
Merge branch 'trunk' into andyfeller/9422-license-compliance
2025-06-16 15:27:28 -04:00