Babak K. Shandiz
b5e24d5dbc
Merge pull request #12170 from cli/babakks/isolate-user-query-from-base-qualifiers
...
Isolate user-provided search query from contextual qualifiers
2025-11-20 17:03:20 +00:00
Babak K. Shandiz
56cdc36013
refactor(pkg/search): rename KeywordsVerbatim to ImmutableKeywords
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-20 16:53:16 +00:00
Babak K. Shandiz
1533d8177c
refactor(pkg/search): rewrite returns in a more verbose way
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-20 16:26:27 +00:00
Babak K. Shandiz
1cd4840199
fix(pr/shared): delegate query compilation to search package
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-20 13:35:24 +00:00
Babak K. Shandiz
76b2de8a18
test(pkg/search): assert verbatim keywords are respected
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-20 13:08:27 +00:00
Babak K. Shandiz
d8486ccf10
fix(pkg/search): add KeywordsVerbatim field to Query type
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-20 13:07:27 +00:00
Babak K. Shandiz
d3fb77f096
Merge pull request #12154 from cli/af/12153-agent-list-default
...
Remove extra flag default from help usage
2025-11-17 15:23:43 +00:00
Andy Feller
e85877dd75
Remove extra flag default from help usage
...
Fixes #12153
2025-11-17 10:09:17 -05:00
William Martin
8a4154cfe7
Refactor cfg out of CAPI Client
2025-11-14 20:21:54 +01:00
dependabot[bot]
680a8c4c4f
Merge pull request #12134 from cli/dependabot/github_actions/golangci/golangci-lint-action-9.0.0
2025-11-13 12:07:43 +00:00
dependabot[bot]
1a06438f91
chore(deps): bump golangci/golangci-lint-action from 8.0.0 to 9.0.0
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 8.0.0 to 9.0.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](4afd733a84...0a35821d5c )
---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2025-11-13 11:57:15 +00:00
Kynan Ware
85d6766c62
Merge pull request #12122 from cli/kw/fix-always-send-reviewer-array
...
`gh pr edit`: Ensure empty arrays for reviewers in PR API calls
2025-11-10 11:25:58 -07:00
Kynan Ware
273fccd908
Check user and teams nil state instead of length
2025-11-10 11:09:14 -07:00
Babak K. Shandiz
eb30e67236
Merge branch 'trunk' into kw/fix-always-send-reviewer-array
2025-11-10 09:33:13 +00:00
Babak K. Shandiz
55ab926f8e
Merge pull request #12123 from cli/kw/update-third-party-licenses
...
Update third-party licenses and dependencies
2025-11-10 09:32:54 +00:00
Kynan Ware
d91480aba9
Update third-party licenses and dependencies
2025-11-07 14:35:46 -07:00
Kynan Ware
e154601f7d
Ensure empty arrays for reviewers in PR API calls
...
Updated AddPullRequestReviews and RemovePullRequestReviews to send empty arrays instead of null values for reviewers and team_reviewers when no users or teams are specified, as required by the API.
2025-11-07 14:00:28 -07:00
Kynan Ware
44df793d56
Merge pull request #12112 from cli/kw/revert-11370
...
Integrate license checks back into lint workflow
2025-11-07 09:41:56 -07:00
Kynan Ware
cc178cf5e4
Update .github/workflows/lint.yml
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-11-07 09:31:36 -07:00
Kynan Ware
b917c4cd50
Annotate go-licenses install with version tag
...
Added a comment specifying the installed go-licenses commit corresponds to v2.0.1 for clarity in the lint workflow.
2025-11-07 09:27:40 -07:00
Kynan Ware
9eb019ae56
Integrate license checks back into lint workflow
...
Reverts https://github.com/cli/cli/pull/11370
2025-11-06 11:57:51 -07:00
Kynan Ware
152d328db8
Merge pull request #12084 from cli/babakks/add-basic-linters
...
chore: add basic linters
2025-11-04 10:46:40 -07:00
Kynan Ware
bb9641a78a
Merge pull request #12095 from cli/dependabot/go_modules/github.com/cli/go-gh/v2-2.13.0
...
chore(deps): bump github.com/cli/go-gh/v2 from 2.12.2 to 2.13.0
2025-11-04 10:24:54 -07:00
dependabot[bot]
f2d0f9e955
chore(deps): bump github.com/cli/go-gh/v2 from 2.12.2 to 2.13.0
...
Bumps [github.com/cli/go-gh/v2](https://github.com/cli/go-gh ) from 2.12.2 to 2.13.0.
- [Release notes](https://github.com/cli/go-gh/releases )
- [Commits](https://github.com/cli/go-gh/compare/v2.12.2...v2.13.0 )
---
updated-dependencies:
- dependency-name: github.com/cli/go-gh/v2
dependency-version: 2.13.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2025-11-04 17:15:12 +00:00
Babak K. Shandiz
895c314c5c
Merge pull request #12064 from cli/babakks/add-isimmutable-to-release-list
...
Add `isImmutable` to `release list` JSON output
2025-11-04 12:43:36 +00:00
Babak K. Shandiz
408f9e0de1
Merge branch 'trunk' into babakks/add-basic-linters
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:24:12 +00:00
Kynan Ware
c0d5f164f2
Merge pull request #12089 from cli/kw/use-source-govulncheck-scan-lint
...
CI: Update lint govulncheck to use source mode
2025-11-03 13:18:27 -07:00
Kynan Ware
52391ff0f8
Apply suggestions from code review
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-11-03 13:08:16 -07:00
Kynan Ware
b151f53d02
Add note on govulncheck source mode for Go 1.25
2025-11-03 13:05:33 -07:00
Babak K. Shandiz
917e365c5c
docs(pkg/search): fix typo
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:28 +00:00
Babak K. Shandiz
0e53651bb2
docs(repo garden): improve func godoc
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:27 +00:00
Babak K. Shandiz
d3b333e5be
fix: ignore nilerr on intentionally swallowed error
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:27 +00:00
Babak K. Shandiz
d002d30327
fix: resolve nilerr issues
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:26 +00:00
Babak K. Shandiz
f498f2e882
fix: resolve copyloopvar issues
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:26 +00:00
Babak K. Shandiz
3ad3fcdce9
fix: resolve gocritic issue
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:26 +00:00
Babak K. Shandiz
0eb5640edb
test(pkg/httpmock): ignore bodyclose on mock response value
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:25 +00:00
Babak K. Shandiz
2709c39179
refactor(repo garden): return pagination link instead of resp
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:25 +00:00
Babak K. Shandiz
9f65e89760
fix: close resp body (bodyclose)
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:25 +00:00
Babak K. Shandiz
d129b94fc5
refactor: remove returned resp from api.EndpointNeedsScopes
...
The returned response from `api.EndpointNeedsScopes` causes `bodyclose`
linter to raise a false positive error, assuming it's a new response that
its body needs to be closed.
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:24 +00:00
Babak K. Shandiz
dde7fce602
refactor(pkg/search): remove passing resp for pagination
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:24 +00:00
Babak K. Shandiz
c6c97b32d5
ci: enable basic linters
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:20 +00:00
Kynan Ware
6c1d1c4f49
Update lint govulncheck to use source mode
...
Replaces binary mode scan of 'bin/gh' with source mode scan of all packages using govulncheck.
2025-11-03 12:55:13 -07:00
Babak K. Shandiz
3d76c668f3
Merge pull request #12085 from cli/babakks/govulncheck-via-workflow-dispatch
...
chore: add `workflow_dispatch` to govulncheck triggers
2025-11-03 19:49:18 +00:00
Babak K. Shandiz
eaddf5baf9
chore: add workflow_dispatch to govulncheck triggers
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 19:43:01 +00:00
Kynan Ware
e73a0e077a
Merge pull request #11926 from cli/bump-go-1.25.3
...
Bump Go to 1.25.3
2025-11-03 11:32:09 -07:00
Kynan Ware
cd9e5e534f
Merge pull request #12068 from cli/kw/spike-custom-agents
...
`gh agent-task create`: support `--custom-agent`/`-a` flag
2025-10-31 18:19:44 -06:00
Kynan Ware
44653c5aeb
Add example for --custom-agent usage
...
Added a usage example to the help text demonstrating how to create a task with a custom agent using the --custom-agent flag.
2025-10-31 16:18:10 -06:00
Kynan Ware
5d17666a69
Update error messages in job creation tests
2025-10-31 16:16:03 -06:00
Kynan Ware
591050a8d2
Update pkg/cmd/agent-task/capi/job.go
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-10-31 16:06:37 -06:00
Kynan Ware
0dcb1d1e43
Add shorthand flag for custom-agent option
...
Introduces the '-a' shorthand for the --custom-agent flag in the agent-task create command, improving CLI usability.
2025-10-31 15:59:23 -06:00