Commit graph

283 commits

Author SHA1 Message Date
Mislav Marohnić
b894d3e134 Simplify delete implementation 2021-09-20 18:37:00 +02:00
Raffaele Di Fazio
c4f0eda96d force was actually needed by a next commit
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-20 11:54:30 +02:00
Raffaele Di Fazio
eca3ecb43b Merge branch 'main' into raffo/delete-codespaces 2021-09-20 11:53:35 +02:00
Raffaele Di Fazio
4721e7004b add threshold to delete by repo
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-20 11:10:44 +02:00
Raffaele Di Fazio
11024f71fa force is not used in delete by repo
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-20 10:27:29 +02:00
Alan Donovan
67a6f0a85d Merge pull request #168 from github/restore-delete-r-confirm
Restore confirmation to delete -r, lost in botched merge
2021-09-17 11:48:02 -04:00
Alan Donovan
1271e20b9b Merge pull request #169 from github/delete-no-list
delete -r: don't perform "list" operation
2021-09-17 11:28:53 -04:00
Alan Donovan
930f194507 Merge pull request #170 from github/list-show-branch-not-name
list: show branch (not name) in branch column
2021-09-17 11:28:26 -04:00
Alan Donovan
ce4bbe5bd8 list: show branch (not name) in branch column 2021-09-17 10:13:35 -04:00
Raffaele Di Fazio
23c9026f58 Merge branch 'main' into raffo/delete-codespaces 2021-09-17 16:13:12 +02:00
Alan Donovan
d23eca8c5f remove "list" operation from "delete -r" command 2021-09-17 09:51:11 -04:00
Alan Donovan
747d7e7173 Restore confirmation to delete -r, lost in botched merge 2021-09-17 09:49:46 -04:00
Alan Donovan
6ac8a0ad88 Merge pull request #165 from github/delete-parallel
Delete in parallel
2021-09-17 09:34:10 -04:00
Alan Donovan
610ab89c3d Merge branch 'main' into delete-parallel 2021-09-17 09:32:56 -04:00
Alan Donovan
4de4572813 add comment 2021-09-17 09:31:05 -04:00
Alan Donovan
fb197c8e75 Merge branch 'main' into delete-parallel 2021-09-17 09:30:48 -04:00
Raffaele Di Fazio
c6b5fb5ba3 add the tests
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-17 14:55:50 +02:00
Raffaele Di Fazio
054fec0ba1 address code comments
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-17 14:45:08 +02:00
Max Beizer
a4f1fa076b Fix up all the static-check warnings (#162) 2021-09-17 13:10:37 +02:00
Raffaele Di Fazio
29c2a17866 Update cmd/ghcs/delete.go
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-09-17 08:55:54 +02:00
Alan Donovan
bc74c4aafa make delete --repo parallel 2021-09-16 18:29:19 -04:00
Raffaele Di Fazio
455dabb484 use named params
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-16 18:49:44 +02:00
Raffaele Di Fazio
22e9da790c Update internal/api/api_test.go
Co-authored-by: CamiloGarciaLaRotta <camilogarcialarotta@github.com>
2021-09-16 18:43:16 +02:00
Raffaele Di Fazio
35e0f95243 Update cmd/ghcs/delete.go
Co-authored-by: CamiloGarciaLaRotta <camilogarcialarotta@github.com>
2021-09-16 18:42:41 +02:00
Raffaele Di Fazio
5cd90fea88 fix linter
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-16 16:45:07 +02:00
Raffaele Di Fazio
68f4cad1af implement delete all with thresold
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-16 16:42:53 +02:00
Christian Gregg
cc1b86461e Confirm deletion of codespaces with unpushed/uncommited changes (#129)
Adds a confirmation dialog on `ghcs delete` if the codespace in question
has unpushed or uncommited changes.

This confirmation can be skipped using the `--force` or `-f` flag.

Closes: #84
Closes: #10
2021-09-16 13:47:15 +01:00
Mislav Marohnić
5617db6614 Merge pull request #151 from github/ruleguard
Wrap errors using "%w" instead of "%v"
2021-09-16 12:21:36 +02:00
Mislav Marohnić
dbb4e0c177 Merge remote-tracking branch 'origin' into ruleguard 2021-09-16 11:46:50 +02:00
Jose Garcia
10ad85486f Merge pull request #154 from github/jg/fix-ctx-error
ghcs create/ssh: fix ctx cancellation errors & fix todo for X11 forwarding
2021-09-15 15:45:35 -04:00
Jose Garcia
45a9715e9f Merge pull request #158 from github/jg/go-liveshare-0.16.0
upgrade to go-liveshare 0.16.0
2021-09-15 15:40:58 -04:00
Jose Garcia
b2234969e4 update logs 2021-09-15 15:40:07 -04:00
Alan Donovan
eafadd3757 Merge pull request #156 from github/api-internal
move api to internal/api
2021-09-15 15:38:11 -04:00
Jose Garcia
26d3199082 add back codespaces.Shell 2021-09-15 15:18:54 -04:00
Jose Garcia
ecd0c70567 upgrade to go-liveshare 0.16.0 2021-09-15 15:15:28 -04:00
Jose Garcia
0f72e3d886 defer stopPolling and docs 2021-09-15 14:29:16 -04:00
Alan Donovan
06719866c9 move api to internal/ 2021-09-15 13:13:10 -04:00
Jose Garcia
547c629220 fix ctx cancellation errors & fix todo for X11 forwarding 2021-09-15 10:38:19 -04:00
Mislav Marohnić
fb5a35568c Ensure original errors are wrapped with "%w" instead of "%v" 2021-09-15 13:58:41 +02:00
Jose Garcia
3abde5f0c5 Merge pull request #148 from github/jg/remove-deprecation-msg
remove all deprecation messages and deprecated functionality
2021-09-13 14:44:40 -04:00
Jose Garcia
f5adc9e3a7 remove all deprecation messages and deprecated functionality 2021-09-13 10:58:00 -04:00
Alan Donovan
a5b985523c Merge pull request #147 from github/tty-windows
Don't assume stdin/stdout fds are 0/1 on windows
2021-09-13 09:30:39 -04:00
Alan Donovan
c4be0a0e28 this time without compile errors 2021-09-13 09:29:46 -04:00
Issy Long
74a4afcd77 Merge pull request #139 from github/fix-version-string
goreleaser: Fix version string replacement
2021-09-13 10:32:19 +01:00
Alan Donovan
1526ab5bff fix URL 2021-09-10 18:08:48 -04:00
Alan Donovan
af301bfff1 stdin/stdout fds are not 0/1 on windows 2021-09-10 17:36:20 -04:00
Jose Garcia
3ca3dd05a1 Merge pull request #143 from github/jg/ssh-flags
ghcs ssh: make flag description consistent
2021-09-10 16:04:09 -04:00
Jose Garcia
ad600d22ed merge upstream 2021-09-10 16:03:09 -04:00
Alan Donovan
8b06ffe2bd Merge pull request #145 from github/remove-script
Remove go-ghcs-crypto vendor script
2021-09-10 15:48:40 -04:00
Jose Garcia
6c907869ff Merge pull request #144 from github/jg/remove-terminal
ghcs ssh: remove terminal, bash_profile setup
2021-09-10 15:06:18 -04:00