Andy Feller
b8ef951de1
Shorten extension release checking from 3s to 1s
...
Addressing feedback from extension author demonstration about a noticable pause waiting for extension execution to complete due to amount of time waiting on channel.
2024-11-13 13:04:01 -05:00
Tyler McGoffin
9b9e654c76
Merge pull request #9866 from andyfeller/andyfeller/cli-cli-8183
...
Check extension for latest version when executed
2024-11-07 14:48:12 -08:00
Andy Feller
3ec657d087
Enhance extension upgrade tests for URL
2024-11-07 17:35:59 -05:00
Meredith Lancaster
6d4c74b252
Merge pull request #9856 from malancas/verify-attestation-monotonic-tests
2024-11-07 07:45:25 -07:00
Andy Feller
54c0739659
Delete .github/workflows/licenses.yml
2024-11-06 23:18:43 -05:00
Andy Feller
e629443a2c
Delete .github/licenses.tmpl
2024-11-06 23:18:32 -05:00
Andy Feller
ddf7287ab8
Test extension command update behaviors
...
This commit expands upon the previous work by creating tests around extension command execution and how various extension update scenarios are handled.
Along the way, the logic handling formatting update messaging has been switched to use `ColorScheme` in order to honor color behavior flags.
2024-11-06 22:49:02 -05:00
Tyler McGoffin
215e4f440f
Merge pull request #9863 from nilvng/nil/fix-7804
...
fix: `gh pr create -w` ignore template flag
2024-11-06 15:35:12 -08:00
Tyler McGoffin
667f90ad51
Merge branch 'trunk' into nil/fix-7804
2024-11-06 15:25:07 -08:00
nilvng
2eaab56912
chore: tidy up
2024-11-07 10:20:23 +11:00
nilvng
874fa7ad4d
feat: add test
2024-11-07 10:20:23 +11:00
nilvng
a780b488a3
fix: ignore template flag
2024-11-07 10:20:23 +11:00
Andy Feller
e356c69a6f
Merge pull request #9881 from cli/cmbrose/cs-config-autokey
...
Create the automatic key when specified with -i
2024-11-06 16:24:43 -05:00
Andy Feller
2435f6915b
Minor nit suggestion
2024-11-06 16:12:55 -05:00
Tyler McGoffin
ef8999749a
Merge pull request #9884 from cli/dependabot/github_actions/actions/attest-build-provenance-1.4.4
...
Bump actions/attest-build-provenance from 1.4.3 to 1.4.4
2024-11-06 11:53:12 -08:00
Caleb Brose
509a181d79
Remove unimplemented tests
2024-11-06 19:10:28 +00:00
William Martin
0f85e4e0e0
Merge pull request #9883 from cli/9882-gh-cache-list-json-should-return-when-no-caches-exist-instead-of-text-message
...
Print empty array for `gh cache list` when `--json` is provided
2024-11-06 18:18:44 +01:00
Meredith Lancaster
0665fb4916
comments
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-06 09:45:42 -07:00
Meredith Lancaster
b65c942e1f
update verification slice building
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-06 09:45:03 -07:00
Meredith Lancaster
eae3b5baec
Merge branch 'trunk' into verify-attestation-monotonic-tests
2024-11-06 09:41:33 -07:00
Meredith Lancaster
2f47d1c81c
Merge pull request #9877 from malancas/simplify-sigstore-verify-result-handling
...
Simplify Sigstore verification result handling in `gh attestation verify`
2024-11-06 09:38:07 -07:00
Caleb Brose
940560acf2
Fix ssh directory
2024-11-06 16:13:29 +00:00
Meredith Lancaster
ffc499110d
Merge branch 'trunk' into verify-attestation-monotonic-tests
2024-11-06 08:08:40 -07:00
Meredith Lancaster
f376ac1a2c
Merge branch 'trunk' into simplify-sigstore-verify-result-handling
2024-11-06 07:59:23 -07:00
Meredith Lancaster
446a0d5885
Merge pull request #9848 from malancas/attestation-refactor-policy
2024-11-06 07:50:25 -07:00
dependabot[bot]
2318fde15f
Bump actions/attest-build-provenance from 1.4.3 to 1.4.4
...
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance ) from 1.4.3 to 1.4.4.
- [Release notes](https://github.com/actions/attest-build-provenance/releases )
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md )
- [Commits](1c608d11d6...ef244123eb
2024-11-06 14:14:48 +00:00
William Martin
f608221737
Merge pull request #9862 from cli/dependabot/go_modules/github.com/creack/pty-1.1.24
...
Bump github.com/creack/pty from 1.1.23 to 1.1.24
2024-11-06 14:57:59 +01:00
William Martin
a569d1030d
Export empty results for cache list
2024-11-06 13:02:14 +01:00
Tyler McGoffin
fe5afb1205
Merge pull request #9876 from akx/delete-workflow-run-copy
...
Fix verbiage for deleting workflow runs
2024-11-05 15:11:51 -08:00
Caleb Brose
b4c221dfb7
Create the automatic key when specified with -i
2024-11-05 22:30:15 +00:00
Aarni Koskela
1c4c8e5145
Fix verbiage for deleting workflow runs
...
It's not deleting _workflows_ (which are specified in YAML)...
2024-11-04 17:55:35 +02:00
Meredith Lancaster
b9c9f0acc2
move comment
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-04 07:35:42 -07:00
Meredith Lancaster
3281bd457c
simplify logic, add comments
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-04 07:32:10 -07:00
Andrew Feller
47d77bd51b
Add version checking when executing extensions
...
Building on logic from the `gh ext list` for retrieving and assessing extension release information, this commit enhances the logic around invoking extensions to check for new releases.
Using the same user experience from checking `gh` version, this should only output information when the extension is used and gives the user information on how to upgrade depending on the type of extension and whether it is pinned or not.
```shell
andrewfeller@Andrews-MacBook-Pro cli % gh ext install dlvhdr/gh-dash --pin v4.6.0
✓ Installed extension dlvhdr/gh-dash
✓ Pinned extension at v4.6.0
andrewfeller@Andrews-MacBook-Pro cli % ./bin/gh dash
A new release of dash is available: 4.6.0 → 4.7.0
To upgrade, run: gh extension upgrade dash --force
https://github.com/dlvhdr/gh-dash
```
2024-11-02 13:14:05 -04:00
Andy Feller
bb1a6f262a
Merge branch 'cli:trunk' into trunk
2024-11-02 11:06:43 -04:00
Meredith Lancaster
91967cced8
Update pkg/cmd/attestation/verify/verify.go
...
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-01 09:51:05 -06:00
Meredith Lancaster
43810a5fc3
use predicate type stored in enforcementCriteria
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-01 09:17:47 -06:00
Meredith Lancaster
bb1584b52a
comment
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-01 09:02:56 -06:00
Meredith Lancaster
a6d15b4f60
update OIDC issuer logic
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-01 09:02:23 -06:00
Meredith Lancaster
a5eca00d0d
remove emtpy string checks
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-01 08:20:32 -06:00
dependabot[bot]
815fcb72b5
Bump github.com/creack/pty from 1.1.23 to 1.1.24
...
Bumps [github.com/creack/pty](https://github.com/creack/pty ) from 1.1.23 to 1.1.24.
- [Release notes](https://github.com/creack/pty/releases )
- [Commits](https://github.com/creack/pty/compare/v1.1.23...v1.1.24 )
---
updated-dependencies:
- dependency-name: github.com/creack/pty
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-11-01 14:10:24 +00:00
Meredith Lancaster
0fb82a6e7c
comments
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 17:11:02 -06:00
Meredith Lancaster
a7a70fc91c
check for SAN and SANRegex
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 16:59:25 -06:00
Meredith Lancaster
50cda0df44
add Valid method for EnforcementCriteria
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 16:56:49 -06:00
Meredith Lancaster
8336f797ad
use sigstore-go certificate.Summary type for criteria
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 16:27:21 -06:00
Meredith Lancaster
9f3d00960c
keep comment
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 16:16:09 -06:00
Meredith Lancaster
a81cb730fc
update VerifyCertExtensions args
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 16:14:28 -06:00
Meredith Lancaster
e6d0a067e6
Update pkg/cmd/attestation/verification/extensions.go
...
Co-authored-by: Phill MV <phillmv@github.com>
2024-10-31 16:09:45 -06:00
Meredith Lancaster
7948ce4dc9
rename function
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 16:09:08 -06:00
Meredith Lancaster
6f4b5ddc40
remove artifact from EnforcementCriteria
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-31 16:07:25 -06:00
