STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
8843 commits 87 branches 0 tags 160 MiB
Commit graph

4338 commits

Author SHA1 Message Date
William Martin
df8bb51c9c Always prompt on secret set when multiple remotes 2025-01-15 14:55:17 +01:00
Wing
0be5720c1c Update setdefault test 2025-01-15 14:55:17 +01:00
Wing
cad59036f5 Update docs for set-default 
NOTE: gh does not use the default repository for managing repository and environment secrets.
 2025-01-15 14:55:17 +01:00
Wing
3de2fd94b3 Prompt for secret commands 
Co-authored-by: William Martin <williammartin@github.com>
 2025-01-15 14:55:16 +01:00
Wing
57c9ee0ad2 Add tests for secret commands 
Co-authored-by: William Martin <williammartin@github.com>
 2025-01-15 14:55:16 +01:00
Wing
88988374b5 Add remote check to secret commands 
Co-authored-by: William Martin <williammartin@github.com>
 2025-01-15 14:55:16 +01:00
Tyler McGoffin
3feeb9a826 Add tests for deleteGist 2025-01-14 14:21:49 -08:00
Rajhans Jadhao
10d4d27d8c
Merge branch 'trunk' into rerun-err-msg 2025-01-14 15:04:15 +05:30
Daniel A. Ochoa
3370bc8a04
Merge branch 'trunk' into gh-gist-delete-prompt 2025-01-13 21:17:23 -06:00
Andy Feller
bc8c46b0b1 Make extension update check non-blocking 
Fixes #10235

This commit updates the Cobra command logic around extension upgrade checks to be non-blocking.

Previously, we were waiting for 1 second after the extension completed to allow the update checking logic complete, however users want the GitHub CLI to run as far as possible.
 2025-01-13 20:38:03 -05:00
Meredith Lancaster
ab26df324f
Merge branch 'trunk' into update-attestation-verify-table-output 2025-01-13 14:46:54 -07:00
Meredith Lancaster
2ddfe865f4
Update pkg/cmd/attestation/verify/verify.go 
Co-authored-by: Phill MV <phillmv@github.com>
 2025-01-13 13:02:05 -07:00
Tyler McGoffin
6fe21d8f52
Merge pull request #10197 from cli/jtmcg/remove-named-returns 
Remove naked return values from `ReadBranchConfig` and `prSelectorForCurrentBranch`
 2025-01-13 09:55:17 -08:00
Meredith Lancaster
112552fec1
Merge pull request #10185 from malancas/fetch-artifact-attestation-bundles-with-sas-url 2025-01-13 08:20:33 -07:00
Mateus Marquezini
4eb0e8138f
Merge branch 'trunk' into fix/issue_10042 2025-01-13 11:47:52 -03:00
Mateus Marquezini
c0f6eb0598 #10042: Attempt to add a new test scenario for handling error messages when TTY is unavailable 2025-01-13 11:39:48 -03:00
Andy Feller
41e99b9eab
Merge pull request #9934 from cli/andyfeller/cli-cli-8183-timeout-pt2 
Ensure extension update notices only notify once within 24 hours, provide ability to disable all extension update notices
 2025-01-13 09:12:32 -05:00
Michael Hoffman
e916ae5b43 Rename domain pkg to shared 2025-01-13 09:08:19 -05:00
Mateus Marquezini
977e2326a2 #10042: Applied code review suggestions to view_test.go 2025-01-13 11:06:13 -03:00
Rajhans Jadhao
9035f651c7
Merge branch 'trunk' into rerun-err-msg 2025-01-13 19:24:09 +05:30
Rajhans Jadhao
b41b77165b
show error message for rerun workflow older than a month ago 2025-01-13 19:21:58 +05:30
Andy Feller
3ada5af872 Enhance help docs on ext upgrade notices 
- update `gh help environment` to include that upgrade notices only happen when gh or extensions are executed
- update `gh ext --help` to include reference to upgrade notices and points to `gh help environment` for info on disabling
 2025-01-13 08:41:10 -05:00
Michael Hoffman
85f0be5bfd
Merge branch 'trunk' into create-autolinks 2025-01-13 08:37:41 -05:00
danochoa
1d9b4e4464 fix tests 2025-01-12 19:36:44 -06:00
danochoa
08f7706c42 fix tests 2025-01-12 19:18:24 -06:00
danochoa
7885167c70 gist delete - check no gists 2025-01-12 17:01:45 -06:00
Michael Hoffman
05f30ab44f
Merge branch 'trunk' into create-autolinks 2025-01-12 13:59:59 -05:00
Mateus Marquezini
24e9fed7e0 removed unnecessary space 2025-01-12 14:57:24 -03:00
Mateus Marquezini
c5d6ae6cf6
Update pkg/cmd/gist/edit/edit.go 
Update pkg/cmd/gist/edit/edit.go after code review

Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
 2025-01-12 14:53:20 -03:00
Mateus Marquezini
f65ac161ee
Merge branch 'trunk' into fix/issue_10042 2025-01-12 14:50:41 -03:00
zhuhaicity
13211af256 chore: fix some function names in comment 
Signed-off-by: zhuhaicity <zhuhai@52it.net>
 2025-01-12 15:07:04 +08:00
danochoa
5de282c970 drop description from prompts, fix tests 2025-01-11 01:35:12 -06:00
Andy Feller
0a1c9be656 Expand docs on cleaning extension update dir 
This summarizes a conversation within cli/cli#9934 PR regarding how the new extension update directory metadata would affect gh if not cleaned up.
 2025-01-10 14:57:10 -05:00
Andy Feller
97eb8a194e Simplifying cleanExtensionUpdateDir logic 
This function was doing some unnecessary heavy lifting detecting if the directory being deleted actually existed when `os.RemoveAll()` would handle directories that exist or not.
 2025-01-10 14:29:55 -05:00
Andy Feller
20062233c8 Separate logic for checking updates 
During discussion in cli/cli#9934, we can to the conclusion that the logic around checking for core GitHub CLI updates would diverge from GitHub CLI
extension updates over time.  To that end, this commit splits that logic into a separate function with a new environment variable.
 2025-01-10 14:16:46 -05:00
Tyler McGoffin
74cbd50d3f Restore old error functionality of prSelectorForCurrentBranch 
Before this refactor, the errors emitted by ghrepo.FromURL and
rem.FindName() were suppressed. It isn't clear whether this was
intentional or not, but we've made the decision here to maintain the
original error behavior while still refactoring the return values for more
clarity. I've left a comment at each error handling block to explain this
decision.

Additionally, I've added the necessary git command stubs to the other
tests in status_test.go so that the tests are now passing.
 2025-01-10 10:52:01 -08:00
nobe4
69b17272d6
fix: add back colon that I removed 2025-01-10 17:17:14 +01:00
nobe4
69ab0c9c85
fix: actually read how MaxFunc work and simplify the code 2025-01-10 16:31:13 +01:00
nobe4
1899b83509
fix: padded display 
Apply code suggestion from @andyfeller from:
- https://github.com/cli/cli/pull/10194#discussion_r1909761552
- https://github.com/cli/cli/pull/10194#discussion_r1909764278
 2025-01-10 16:28:50 +01:00
William Martin
889c4c75f3 Collapse dryrun checks in ext bin upgrade 2025-01-10 16:06:01 +01:00
Michael Hoffman
c09b5fa551
Merge branch 'trunk' into create-autolinks 2025-01-10 09:46:59 -05:00
Daniel A. Ochoa
d621b75ee7
Merge branch 'trunk' into gh-gist-delete-prompt 2025-01-10 01:25:19 -06:00
danochoa
7f71681ace gist delete - use in confirmation and success info 2025-01-10 01:07:11 -06:00
Tyler McGoffin
4c8d124d37
Merge pull request #10194 from nobe4/fancier-extention-upgrade 
feat: make the extension upgrade fancier
 2025-01-09 14:59:52 -08:00
Daniel A. Ochoa
928db3e66f
Merge branch 'trunk' into gh-gist-delete-prompt 2025-01-09 16:36:15 -06:00
Michael Hoffman
1207cef42b
Merge branch 'trunk' into create-autolinks 2025-01-09 16:06:06 -05:00
Tyler McGoffin
3d2748789e Rename test user in tests 2025-01-09 12:58:31 -08:00
Tyler McGoffin
100f9b473f Change pr number in test 2025-01-09 12:57:23 -08:00
Tyler McGoffin
e4f0b79173 Surface and handle error from ReadBranchConfig in parseCurrentBranch 
I've only added the one test for parseCurrentBranch because the function
appears to be largely exercised by TestFind. There's definitely an
opportunity for a bigger refactor of the tests, here, but I want to avoid
scope creep as I propagate the ReadBranchConfig api changes throughout the
codebase
 2025-01-09 12:46:55 -08:00
Tyler McGoffin
e4320ccc4b Directly stub headBranchConfig in Test_tryDetermineTrackingRef 2025-01-09 11:58:33 -08:00