Commit graph

1994 commits

Author SHA1 Message Date
vilmibm
ba46362a7f add createRun tests 2020-07-21 17:19:59 -05:00
vilmibm
5085a5eda2 WIP test works with mock 2020-07-21 15:17:30 -05:00
Mislav Marohnić
e373195817 WIP migrate gist create to separate package 2020-07-21 18:13:16 +02:00
Mislav Marohnić
6a48a604f0
Merge pull request #1383 from cli/gist-create-stdin
Fix creating gists from stdin with argument
2020-07-21 11:37:35 +02:00
Nate Smith
e18776c227
Merge pull request #1387 from cli/misc-scriptability
misc scriptability improvements
2020-07-20 12:33:58 -05:00
vilmibm
2dd42eb9aa minor alias scriptability changes 2020-07-20 11:10:34 -05:00
Nate Smith
eb1b9122d8
Merge pull request #1386 from cli/terminal-check-state
remove package level terminal check state
2020-07-20 11:07:50 -05:00
vilmibm
b7765591b7 remove package level terminal check state 2020-07-17 15:02:05 -05:00
Mislav Marohnić
1545674d5c 💅 Tweak --public flag description
Trying to generally avoid "when true" in descriptions of boolean flags
2020-07-17 19:13:14 +02:00
Mislav Marohnić
a1a3e2d7bf Pass FlagError by reference 2020-07-17 19:11:53 +02:00
Mislav Marohnić
73889e0c84
Merge pull request #1382 from cli/checkscopes-crash
Fix printing network error in case for failed HTTP requests
2020-07-17 19:09:29 +02:00
Mislav Marohnić
d90c387e04 Update gist create test
- use testify
- verify that the HTTP request is a POST to `/gists`
- more precise POST params matching in assertion
2020-07-17 18:24:34 +02:00
Mislav Marohnić
449fccf811 Enable passing stdin to gh gist create -
Goals:
- print command usage information on `gh gist create` when no args nor stdin
- disallow passing `-` as argument multiple times
- utilize Cobra's Args to do argument validation
2020-07-17 18:24:34 +02:00
Mislav Marohnić
2086ecb3d1 Fix printing network error in case for failed HTTP requests
The CheckScopes middleware tried to read from `res.Headers` before it
verified that `res` is available.
2020-07-17 18:24:13 +02:00
Nate Smith
1f97a9a4d1
Merge pull request #1371 from cli/ignore-nondotcom-remotes
Revert to ignoring non-github.com git remotes
2020-07-16 12:05:37 -05:00
Mislav Marohnić
f93261a6f9 Revert to ignoring non-github.com git remotes
This fixes a regression where extra git remotes pointing to
non-github.com hostnames could result in gh trying to parse repository
information from them.
2020-07-16 18:54:35 +02:00
Mislav Marohnić
4a2ff30444
Merge pull request #1370 from cli/docs-environment
Document supported environment variables
2020-07-16 18:38:18 +02:00
Mislav Marohnić
75086f0b80 💅 Improve readability of api example code
Tab indentation is replaced with two spaces to curb deep indentation.
2020-07-16 17:46:25 +02:00
Mislav Marohnić
9e4af479da Add command line docs for supported environment variables 2020-07-16 17:46:09 +02:00
Mislav Marohnić
89adc83194
Merge pull request #1363 from shihanng/feature/issue-1361__help
Dedent help texts based on shortest indent
2020-07-16 16:44:52 +02:00
Mislav Marohnić
e6083605c5 Fix spacing around gh help sections 2020-07-16 16:41:40 +02:00
Mislav Marohnić
065496781e Add indent helper function 2020-07-16 16:24:25 +02:00
Mislav Marohnić
4e15982046 Fix crash in dedent when blank lines are passed 2020-07-16 16:10:39 +02:00
Mislav Marohnić
1ed35a749a
Merge pull request #1282 from AliabbasMerchant/webInList
Support --web flag in issue and pr list
2020-07-16 15:27:54 +02:00
Mislav Marohnić
0528145159 Allow filter values with spaces in issue/pr list --web 2020-07-16 15:21:50 +02:00
Shi Han NG
3db8bc654a
dedent flags in rootUsageFunc 2020-07-16 22:04:40 +09:00
Shi Han NG
3fb90b43ba
dedent based on shortest indent 2020-07-16 22:04:10 +09:00
Mislav Marohnić
8626befd3f Merge remote-tracking branch 'origin' into webInList 2020-07-16 14:51:34 +02:00
Mislav Marohnić
4b87f5b18a
Merge pull request #1367 from cli/fix-internal-alias
fix variable shadowing
2020-07-16 14:46:40 +02:00
Mislav Marohnić
b0fede93c9
Merge pull request #1365 from cli/pr-checkout-fixes
pr checkout fixes for branch names
2020-07-16 14:31:04 +02:00
Mislav Marohnić
067d05a030
Merge pull request #1366 from cli/template-naming
Improve support for legacy issue/PR template names
2020-07-16 14:30:25 +02:00
Mislav Marohnić
68b347cffc
Merge pull request #1362 from cli/triage-releasing-tweaks
Expand our releasing, triage docs
2020-07-16 14:28:55 +02:00
Shi Han NG
7120b95731
add TestStripIndent 2020-07-16 08:33:00 +09:00
vilmibm
3f5893bcb4 fix variable shadowing 2020-07-15 12:36:45 -05:00
Nate Smith
619ef43f76
Merge pull request #1191 from cli/shell-alias
shell aliases
2020-07-15 12:24:36 -05:00
vilmibm
86912b31b2 stub sh lookup 2020-07-15 12:17:36 -05:00
vilmibm
cf3af450eb minor docs 2020-07-15 11:40:35 -05:00
vilmibm
cfb8eebf30 quietly return exit code of external command 2020-07-15 11:39:48 -05:00
vilmibm
acaaa28fd7 helper function for finding sh 2020-07-15 11:30:20 -05:00
Mislav Marohnić
07bee6a63c Improve support for legacy issue/PR template names
Now supports names such as `PULL-REQUEST-TEMPLATE` (dashes instead of
underscores) and `issue_template.txt` (any file extension, including no
extension), is valid.
2020-07-15 18:16:16 +02:00
Mislav Marohnić
dfb774cd38 Verify HTTP stubs in pr checkout tests 2020-07-15 16:18:36 +02:00
Mislav Marohnić
c232c8872c Abort pr checkout when PR has an invalid head branch name 2020-07-15 16:16:38 +02:00
Mislav Marohnić
305cd290ee Fix pr checkout <owner>:<branch> when it matches the default branch
First, consolidate the functionality between `pr merge` and `pr
checkout` that resolves the default branch name of the base repo. With
an added bonus, the new approach avoids an API request when one isn't
necessary.

Then, ensure that checking out 3rd-party PRs will result in local branch
name such as `<owner>/<branch>` when the head branch of the repository
matches the default branch of the base repository. We already have had
code in place to take care of this, but it only took effect in the `pr
checkout <number>`-style invocation.
2020-07-15 15:35:42 +02:00
Mislav Marohnić
6825944cad Reference named queries in pr checkout HTTP stubs 2020-07-15 14:54:30 +02:00
Shi Han NG
c7df292288
strip extra spaces from help texts 2020-07-15 21:38:49 +09:00
Mislav Marohnić
ee928a14a5 Add more notes to our releasing docs 2020-07-15 14:17:00 +02:00
Mislav Marohnić
e886df594b Add a note about help-wanted in triage docs 2020-07-15 14:12:57 +02:00
Mislav Marohnić
c8cf54c10c
Merge pull request #1258 from cli/ghe-remotes
Parse and respect non-github.com git remotes
2020-07-15 13:07:30 +02:00
Mislav Marohnić
6e9fab68c8
Merge pull request #1359 from cli/scopes-admin
Improvements to checking OAuth scopes
2020-07-15 13:05:27 +02:00
vilmibm
a9d93f8c57 correct docs 2020-07-14 19:42:05 -05:00