petercover
bad7098cfe
chore: fix some comments
...
Signed-off-by: petercover <raowanxiang@outlook.com>
2025-01-23 00:47:27 +08:00
William Martin
c3342cc173
Merge pull request #10236 from AMS21/patch-1
...
add install instructions for Manjaro Linux
2025-01-22 12:59:17 +01:00
William Martin
b2e0c6a68a
Merge pull request #10257 from cli/dependabot/go_modules/github.com/google/go-containerregistry-0.20.3
...
Bump github.com/google/go-containerregistry from 0.20.2 to 0.20.3
2025-01-22 12:29:15 +01:00
William Martin
113fe646f3
Bump go module version to 1.23
2025-01-22 12:10:03 +01:00
dependabot[bot]
9eb8002764
Bump github.com/google/go-containerregistry from 0.20.2 to 0.20.3
...
Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry ) from 0.20.2 to 0.20.3.
- [Release notes](https://github.com/google/go-containerregistry/releases )
- [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml )
- [Commits](https://github.com/google/go-containerregistry/compare/v0.20.2...v0.20.3 )
---
updated-dependencies:
- dependency-name: github.com/google/go-containerregistry
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2025-01-22 12:10:03 +01:00
William Martin
1bd07b9477
Merge pull request #10279 from mikelolasagasti/go-1.24-printf
...
Bump golangci-linter and address failures to prepare for Go 1.24 strictness
2025-01-22 12:08:39 +01:00
Tyler McGoffin
e0d3b9181a
Merge pull request #10227 from iamrajhans/rerun-err-msg
...
show error message for rerun workflow older than a month ago
2025-01-21 13:14:24 -08:00
William Martin
0a3706a404
Remove unncessary printf usage
2025-01-21 18:04:47 +01:00
William Martin
0ead3398a7
Bump golang ci lint to work with go 1.24
2025-01-21 17:55:39 +01:00
William Martin
ff922353bb
Merge pull request #10209 from cli/wm/add-remote-check-to-secret
...
Require repo disambiguation for secret commands
2025-01-21 15:24:49 +01:00
William Martin
53f80b2ebf
Merge pull request #10265 from robmorgan/patch-1
...
Tiny typo fix
2025-01-21 13:48:50 +01:00
Rajhans Jadhao
211aaefc39
Merge branch 'trunk' into rerun-err-msg
2025-01-21 10:38:23 +05:30
Kynan Ware
722fc67342
Merge pull request #10048 from mateusmarquezini/fix/issue_10042
...
Fix: `gh gist view` and `gh gist edit` prompts with no TTY
2025-01-20 12:12:53 -07:00
Mikel Olasagasti Uranga
4396e40a31
Fix: Ensure constant format strings in fmt and printf calls
...
Go 1.24 introduces stricter checks for format string validation.
This commit fixes instances where non-constant format strings were
used in calls to functions like `fmt.Errorf`, `fmt.Printf`, and similar.
Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
2025-01-20 16:27:27 +01:00
Andy Feller
fe74349fe4
Merge pull request #10269 from cli/BagToad-add-affected-version-to-bug-report-form
2025-01-17 22:55:03 -05:00
Caleb Brose
0c8591064d
Change back to exponential backoff
2025-01-17 14:09:33 -06:00
Caleb Brose
9b8cd7babd
Linter
2025-01-17 14:09:33 -06:00
Caleb Brose
31bff5b5a8
Better handling for codespace state polling
2025-01-17 14:09:33 -06:00
Kynan Ware
7942be56aa
Add affected version to bug report form
2025-01-17 12:07:32 -07:00
Rob Morgan
dcf5cc8724
fix: tiny typo fix
2025-01-17 18:08:59 +08:00
Kynan Ware
60f8417d4b
Merge pull request #10250 from cli/dependabot/go_modules/google.golang.org/protobuf-1.36.3
...
Bump google.golang.org/protobuf from 1.36.2 to 1.36.3
2025-01-16 14:21:33 -07:00
Andy Feller
07c63558b8
Merge pull request #10184 from cli/dependabot/go_modules/github.com/gabriel-vasile/mimetype-1.4.8
...
Bump github.com/gabriel-vasile/mimetype from 1.4.7 to 1.4.8
2025-01-16 15:56:25 -05:00
Kynan Ware
facd0caa29
Fix: accidental whitespace in gist edit
2025-01-16 11:44:46 -07:00
Kynan Ware
5b6fd53a88
Fix: gist edit test name
2025-01-16 11:36:48 -07:00
Kynan Ware
dec46670bb
Fix: gist edit/view tests var name consistency
2025-01-16 11:14:33 -07:00
Kynan Ware
a2dce589d6
Merge 'trunk' into fix/issue_10042
2025-01-16 11:06:36 -07:00
Kynan Ware
35d81e3ff5
Fix: Gist edit tests for interactivity
...
This changes the gist edit tests to use the positive `istty` instead of the previous inverse `nontty`, which is consistent with the way other commands are written.
2025-01-16 10:46:07 -07:00
Andy Feller
8288011149
Merge pull request #10239 from cli/andyfeller/10235-non-blocking-ext-update
...
Make extension update check non-blocking
2025-01-16 08:40:39 -05:00
William Martin
cc4bf0fc9f
Add small wait to extension update tests
2025-01-16 14:10:42 +01:00
Andy Feller
243acaf579
Refactor test based on PR feedback
2025-01-16 00:08:45 -05:00
Rajhans Jadhao
143d628f1b
Merge branch 'trunk' into rerun-err-msg
2025-01-16 09:02:31 +05:30
dependabot[bot]
2757d22b4b
Bump google.golang.org/protobuf from 1.36.2 to 1.36.3
...
Bumps google.golang.org/protobuf from 1.36.2 to 1.36.3.
---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2025-01-15 14:49:31 +00:00
William Martin
e7ffb1e435
Fix typo in secret base repo selection comment
2025-01-15 14:55:18 +01:00
William Martin
88a64d2a11
Change wording on secret repo prompt
2025-01-15 14:55:17 +01:00
William Martin
b382b24728
Print informative message before prompting for secret repo
2025-01-15 14:55:17 +01:00
William Martin
a47327aee6
Secret base repo prompting should not use resolved remote
...
This is because the secret commands don't use the SmartBaseRepo behaviour, and therefore
don't care about the resolved remote.
2025-01-15 14:55:17 +01:00
William Martin
ce47fabc27
Move secret base repo prompting earlier
2025-01-15 14:55:17 +01:00
William Martin
5630252f78
Add acceptance test for secrets remote disambiguation
2025-01-15 14:55:17 +01:00
William Martin
d831e3e1db
Remove validated TODO and add review warning
2025-01-15 14:55:17 +01:00
William Martin
4da4c82090
Rename secret BaseRepo func
2025-01-15 14:55:17 +01:00
William Martin
870da79886
Use smarter base repo funcs for secret commands
2025-01-15 14:55:17 +01:00
William Martin
73244c010e
Move secret repo validation into secrets subpackage
2025-01-15 14:55:17 +01:00
William Martin
df8bb51c9c
Always prompt on secret set when multiple remotes
2025-01-15 14:55:17 +01:00
Wing
0be5720c1c
Update setdefault test
2025-01-15 14:55:17 +01:00
Wing
cad59036f5
Update docs for set-default
...
NOTE: gh does not use the default repository for managing repository and environment secrets.
2025-01-15 14:55:17 +01:00
Wing
3de2fd94b3
Prompt for secret commands
...
Co-authored-by: William Martin <williammartin@github.com>
2025-01-15 14:55:16 +01:00
Wing
57c9ee0ad2
Add tests for secret commands
...
Co-authored-by: William Martin <williammartin@github.com>
2025-01-15 14:55:16 +01:00
Wing
88988374b5
Add remote check to secret commands
...
Co-authored-by: William Martin <williammartin@github.com>
2025-01-15 14:55:16 +01:00
Tyler McGoffin
adc5f01d23
Merge pull request #10214 from cli/dependabot/go_modules/github.com/sigstore/protobuf-specs-0.3.3
...
Bump github.com/sigstore/protobuf-specs from 0.3.2 to 0.3.3
2025-01-14 16:08:39 -08:00
Tyler McGoffin
12ee8b7a86
Merge pull request #10154 from danochoa/gh-gist-delete-prompt
...
gh gist delete: prompt for gist id
2025-01-14 14:42:13 -08:00