Kynan Ware
53d0d5d192
fix(editable): include DefaultLogins in EditableAssignees clone
2025-05-16 12:54:01 -06:00
Kynan Ware
6f1906073f
doc(params): incorrect func name in comment
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-05-16 12:51:09 -06:00
Kynan Ware
a28e2d8784
refactor(api): use constant for Copilot login
2025-05-16 12:28:46 -06:00
Kynan Ware
debf0bbaf2
test(params): enhance Copilot replacer tests for edge cases
...
- Added tests for handling nil and empty slices in the Copilot replacer.
- Simplified test structure by removing unnecessary wantErr field.
2025-05-16 09:50:24 -06:00
Kynan Ware
871671be52
fix(params): remove needless err return
2025-05-16 09:40:29 -06:00
Kynan Ware
c5f2d7bde7
doc(editable): remove needless comment
2025-05-16 09:37:20 -06:00
Kynan Ware
375c6cd28f
feat(issue/pr edit): support @copilot in assignee flags
...
- Introduced CopilotReplacer to handle `@copilot` mentions in assignee lists.
2025-05-15 12:50:03 -06:00
Kynan Ware
51b1e6cd6f
Merge branch 'kw/gh-cli-909-911-assign-actors-to-prs' into kw/gh-cli-916-special-actor-assignee-names
2025-05-15 11:27:14 -06:00
Kynan Ware
52b6ebff9c
doc(pr edit): Add comments describing the use of DefaultLogins
2025-05-15 10:52:31 -06:00
Kynan Ware
9a5ea87d75
fix(issues): fix non-interactive assignee matching to logins&IDs
2025-05-15 09:56:35 -06:00
Kynan Ware
6162a7c524
fix(api): correct var name capitalization
2025-05-15 09:33:36 -06:00
Kynan Ware
eace1e889a
feat(editable): update assigned actors to use display names
...
- Refactored AssignedActors to return display names instead of logins.
- Updated related functions to ensure consistency in display names.
- Enhanced comments for clarity on display name logic and actor types.
2025-05-14 20:26:53 -06:00
Kynan Ware
5dc854c75e
doc(issue edit): clarify synchronous handling of assignees
2025-05-14 11:50:11 -06:00
Kynan Ware
08cd1dc7db
feat(issue edit): replacing actor assignee is done synchronously with updateIssue
2025-05-14 11:43:29 -06:00
Kynan Ware
dfd600713f
refactor(api): rename assignable user types and methods
2025-05-14 08:53:47 -06:00
Kynan Ware
218152f7c5
fix(issue edit): resolve race condition in actor assignment
2025-05-09 23:26:06 -06:00
Kynan Ware
0efdfed068
feat(issue edit): support assigning actors to issues
2025-05-09 22:56:09 -06:00
Kynan Ware
ee9d169204
feat(issue edit): fetch assignable actors
2025-05-09 15:13:11 -06:00
Kynan Ware
7b86830ade
Merge pull request #10729 from nopcoder/trunk
...
Fix panic on `gh pr view 0`
2025-05-02 09:47:48 -06:00
William Martin
e995a873cb
Feature detect v1 projects on non-interactive pr create
2025-05-02 15:08:34 +02:00
William Martin
c5d8e6f8f5
Merge pull request #10821 from cli/wm/projectsv1-deprecation-pr-view
...
Feature detect v1 projects on pr view
2025-05-02 15:07:40 +02:00
William Martin
64370ce73e
Cleanup run command stubbed finders in tests
2025-05-02 14:48:52 +02:00
Barak Amar
232c024987
Merge branch 'trunk' into trunk
2025-05-01 22:16:55 +03:00
William Martin
3bcf9758ad
Feature detect v1 projects on pr view
2025-05-01 15:31:36 +02:00
Sinan Sonmez (Chaush)
0a1e7a1fdc
Add --delete-last option to pr comment and issue comment ( #10596 )
...
* deletion for issues with confirmation flag
* add handling for interaction case
* finish implementation for issues
* finish the implementation for issues
* finalize the implementation for PR
* fix missing --yes flag for PR
* address PR comments related to feedbacks
* improve CommentablePreRun for pre checks
* improve confirmation prompt and truncate long comment body
* address PR comments on tests
* Truncate comment for confirmation prompt
Signed-off-by: Babak K. Shandiz <babakks@github.com>
* Improve test case descriptions
Signed-off-by: Babak K. Shandiz <babakks@github.com>
* Fix mock comment body
Signed-off-by: Babak K. Shandiz <babakks@github.com>
* Remove irrelevant prompt stub
Signed-off-by: Babak K. Shandiz <babakks@github.com>
* Use `opts.Interactive` as TTY indicator
Signed-off-by: Babak K. Shandiz <babakks@github.com>
* Fix expected `Interactive` value
Signed-off-by: Babak K. Shandiz <babakks@github.com>
* Polish `TestNewCmdComment`
Signed-off-by: Babak K. Shandiz <babakks@github.com>
---------
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Co-authored-by: Babak K. Shandiz <babakks@github.com>
2025-05-01 14:12:55 +01:00
Barak Amar
a491578751
Merge branch 'trunk' into trunk
2025-04-29 14:33:21 +03:00
Barak Amar
692bdaf578
Apply code review changes
2025-04-29 14:32:51 +03:00
Azeem Sajid
9ed733fa5e
Add closingIssuesReferences JSON field to pr view ( #10544 )
...
* [gh pr view] Support `closingIssuesReferences` JSON field
* Support pagination
* Support pagination
* Fix typo
* Add more fields
2025-04-29 11:48:20 +01:00
Barak Amar
afba7b9e8b
Merge branch 'trunk' into trunk
2025-04-28 18:17:36 +03:00
William Martin
fb97b3efaa
Fix pr create when push.default tracking and no merge ref ( #10863 )
...
* Fix pr create when push.default tracking and no merge ref
* Update pkg/cmd/pr/shared/find_refs_resolution.go
---------
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
2025-04-24 16:41:14 +00:00
William Martin
c208b1f075
Feature detect v1 projects on web mode issue create
2025-04-17 21:04:08 +02:00
William Martin
c8dd61d837
Feature detect v1 projects on non-interactive issue create
2025-04-17 17:51:38 +02:00
Barak Amar
a1f5d42283
Update the test code to align with latest changes
2025-04-17 17:13:28 +03:00
Barak Amar
265139f268
Merge branch 'trunk' into trunk
2025-04-17 09:56:12 -04:00
William Martin
a9dbda6913
Rework ref usage when finding and creating PRs
2025-04-15 13:38:10 -06:00
Kynan Ware
76de5f07ca
test(pr finder): run test in parallel
2025-04-15 13:38:10 -06:00
Kynan Ware
041f02c980
docs(pr create): standard <user>:<branch> syntax
...
Standardize <user>:<branch> syntax wherever it is described in comments.
2025-04-15 13:38:10 -06:00
Kynan Ware
6dae35b442
test(finder): change assert to require
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-15 13:38:10 -06:00
Kynan Ware
e999976b3d
refactor(pr create): add PullRequestRefs HasHead
2025-04-15 13:38:10 -06:00
Kynan Ware
b61b2298d2
doc: fix PullRequestRefs comment
2025-04-15 13:38:10 -06:00
Barak Amar
747f015f48
test pr number 0
2025-04-07 22:38:28 +03:00
Andy Feller
918cafc222
Deprecate ColorScheme.Gray for ColorScheme.Muted
...
This commit converts all of the places using ColorScheme.Gray and ColorScheme.Grayf to Muted and Mutedf.
There is a little extra tidying up with local variable names or converting code to use Mutedf format.
2025-04-06 10:18:48 -04:00
Barak Amar
06d22d96c0
handle find pr number 0
2025-04-04 11:14:02 +03:00
Andy Feller
bbb8213e9c
Refactor commentable logic
2025-03-19 07:56:53 -04:00
Andy Feller
018b6d6d07
Initial pass fixing gh issue and gh pr comment
...
There is still a bit of work to get the gh pr comment tests in order, however this goes a way towards fixing the issue along with acceptance tests.
Also, it turns out some of the issue acceptance tests were really running `pr` tests.
2025-03-17 23:18:36 -04:00
William Martin
11b9496e17
Fix checkout when URL arg is from fork and cwd is upstream
2025-02-27 16:56:11 +01:00
latzskim
26414865c4
Address pr comments
2025-02-19 16:56:23 +01:00
latzskim
e516e5ed5d
[gh issue/pr comment] Create a comment if no comment already
2025-02-12 21:04:22 +01:00
Kynan Ware
026672e79e
Merge branch 'trunk' into nil/fix-2329
2025-02-01 12:37:44 -07:00
nilvng
42c9d244f7
remove duplicated Prompter type
2025-02-01 11:45:37 +11:00
