Commit graph

9233 commits

Author SHA1 Message Date
Kynan Ware
c4be95afd9 refactor(prompter): remove unused variable 2025-04-08 11:58:50 -06:00
Kynan Ware
ef58e627f9 test(prompter): timeout for tests is 1s 2025-04-08 11:44:14 -06:00
Kynan Ware
d8d3874778 fix(prompter): use os.lookupenv for accessible prompter 2025-04-08 11:38:54 -06:00
Kynan Ware
fb80b5bd86 test(prompter): remove needless NO_COLOR set 2025-04-07 14:56:33 -06:00
Kynan Ware
c5ffb3cbfe
test: use example.com in tests 2025-04-07 14:54:41 -06:00
Kynan Ware
66407402c0
doc: comment typos and formatting
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-07 14:53:31 -06:00
Kynan Ware
0543aac53c test(prompter): add basic survey prompter test 2025-04-07 12:54:03 -06:00
Kynan Ware
2a851e33e8 test(prompter): fix race conditions 2025-04-07 11:59:05 -06:00
Kynan Ware
5996f882fc doc(envs): speech synthesis prompter 2025-04-07 10:40:29 -06:00
Kynan Ware
f89700160b doc(prompter): clarify comments 2025-04-04 15:08:17 -06:00
Kynan Ware
0b49522467 refactor(prompter): less magic strings 2025-04-04 15:07:21 -06:00
Kynan Ware
2e48cadf58 fix(prompter): remove impossible condition 2025-04-04 15:05:23 -06:00
Kynan Ware
5c39e0bd10 fix(prompter): notes about Confirm default 2025-04-04 14:52:25 -06:00
Kynan Ware
4cf048a8d1 fix(prompter): input returns default when blank 2025-04-04 11:33:10 -06:00
Kynan Ware
5b0d49c6ec test(prompter): more tests for bad input 2025-04-04 11:06:40 -06:00
Kynan Ware
a30df14b6a refactor(prompter): rename env var for speech synthesizer friendly prompter 2025-04-03 13:08:16 -06:00
Kynan Ware
49ddacf5b8 docs(prompter): doc prompter interface 2025-04-03 13:06:31 -06:00
Kynan Ware
02fc12e7b7 fix(linter): linter errors 2025-04-03 08:51:54 -06:00
Kynan Ware
88e6285b49 test(prompter): move to external package 2025-04-03 08:45:58 -06:00
Kynan Ware
8827803bd1 test(prompter): skip vt10x tests on Windows 2025-04-03 08:25:33 -06:00
Kynan Ware
e299b56c0f test(prompter): remove needless variable declaration 2025-04-02 13:08:36 -06:00
Kynan Ware
e42af35839 tests(prompter): rename huhprompter 2025-04-02 13:00:46 -06:00
Kynan Ware
0d7fd36f11 test(prompter): replace assert with require 2025-04-02 12:58:44 -06:00
Kynan Ware
94bbd26aab fix(prompter): rename huhprompter 2025-04-02 12:56:44 -06:00
Kynan Ware
f7de9e0c11 test(prompter): go-expect based prompter tests 2025-04-02 12:56:44 -06:00
Kynan Ware
88a98ea63a
feat(prompter): include no as false-y value
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-02 11:58:10 -06:00
Kynan Ware
92b1a8e0f0 test(prompter): remove t.parallel calls
t.Parallel() cannot be used when env vars are being set.
2025-03-31 16:01:16 -06:00
Kynan Ware
e973ee332d fix(md prompter): accessible prompt allows blank
Allow the accessible markdownEditor prompt to be blank when the blank
comes from the result of an interactive session with an editor, even when
blankAllowed is false.

This behavior aligns the accessible prompter with the behavior of the
current standard prompter.
2025-03-31 15:58:20 -06:00
Kynan Ware
7b0c09541d feat(md prompter): md prompt respects blankAllowed
Accessible prompter now respects blankAllowed and
will not prompt for "skip" if blankAllowed is false.
2025-03-31 15:52:26 -06:00
Kynan Ware
202c1ad16b feat(prompter): add accessible prompter support 2025-03-31 15:04:57 -06:00
Kynan Ware
e30244686c
Merge pull request #10680 from cli/kw/update-go-gh-and-document-sprig-funcs
Update go-gh and document available sprig funcs
2025-03-28 12:22:14 -06:00
Kynan Ware
aac43870d4 test(release view): fix indentation 2025-03-28 12:11:57 -06:00
Kynan Ware
c6b4da8f20 doc(formatting): add line breaks for readability 2025-03-28 12:00:06 -06:00
Andy Feller
77ae842eb0
Merge pull request #10649 from cli/andyfeller/table-headers-contrast-github-cli-831
Ensure table headers are thematically contrasting
2025-03-28 13:30:49 -04:00
Andy Feller
eabd02793e Renaming tabl eheader variables for maintainability 2025-03-28 13:19:27 -04:00
Kynan Ware
89def92f04 doc(formatting): update sprig func descriptions 2025-03-28 09:58:48 -06:00
Kynan Ware
c1fbc2f05b test(many): fix whitespace in tests expectations
Due to https://github.com/charmbracelet/glamour/pull/334, the margin
used for markdown rendering has changed by a couple spaces. This
corrects the relevant tests to accomodate that change.
2025-03-27 14:21:13 -06:00
Kynan Ware
0750750f7c
Merge pull request #10660 from cli/kw/fix-run-list-with-org-required-workflows
`run list`: do not fail on ruleset imposed workflows
2025-03-27 13:36:29 -06:00
Kynan Ware
229216e830 doc(run shared): clarify 404 handling 2025-03-26 15:29:20 -06:00
Kynan Ware
49588555c3
Merge branch 'trunk' into kw/update-go-gh-and-document-sprig-funcs 2025-03-26 12:38:10 -06:00
Andy Feller
ce4f5c5970
Merge pull request #10683 from cli/andyfeller/10590-alias-delete-test-safeguard
Implement safeguard for `gh alias delete` test, prevent wiping out GitHub CLI configuration
2025-03-26 14:08:48 -04:00
Andy Feller
86ad62a62d Fixes #10590
Implement missing safeguard causing `gh alias delete` tests to wipe out tester's GitHub CLI configuration.
2025-03-26 13:42:39 -04:00
Kynan Ware
ffd42ea256 docs: add Sprig library functions to help topics 2025-03-26 10:21:41 -06:00
Kynan Ware
efa1825eff chore: update go-gh to v2.12.0 2025-03-26 10:21:22 -06:00
Andy Feller
79f1b07fb1 Implement and fix tests for table headers 2025-03-25 15:29:05 -04:00
Kynan Ware
c6f574ccb1
test(run list): update rulesets test name
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-03-24 14:14:50 -06:00
Kynan Ware
30960d59bc
doc(run list): add enterprise ruleset notes
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-03-24 14:04:16 -06:00
Kynan Ware
a35ae3b8bb refactor(tests): update test name for org workflows 2025-03-24 12:54:47 -06:00
Kynan Ware
d3ad4f410b docs(run list): doc runs without workflow names 2025-03-24 12:45:03 -06:00
Kynan Ware
5817f6fce9 fix(run list): do not fail on org workflows 2025-03-24 12:34:50 -06:00