Commit graph

1856 commits

Author SHA1 Message Date
Pavel Borzenkov
c66eebc6fb api: return structured error for failed API calls
`fmt.Errorf` hides information and makes it hard to test for specific
conditions in returned error. Return a structured error instead.

Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
2020-06-27 18:47:34 +03:00
Pavel Borzenkov
aa8f8e8904 httpmock: propagate original HTTP request to HTTP response
So that it's possible to access it in mocked HTTP tests.

Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
2020-06-27 18:47:06 +03:00
Mislav Marohnić
15a7ab6b92
Merge pull request #1187 from gabgodBB/Disabling_color_for_output_file
Issue #930 - Removing color for output files
2020-06-24 17:18:22 +02:00
Mislav Marohnić
ab903bdfc0
Merge pull request #1155 from metalogical/FIX-detached-head
fix regression in support for detached HEAD state
2020-06-24 17:01:22 +02:00
Nate Smith
9c804907db
Merge pull request #1252 from cli/pr-checkout-maintainercanmodify
Fix `pr checkout OWNER:BRANCH` when maintainer can modify
2020-06-23 16:47:05 -05:00
Mislav Marohnić
657e633238
Merge pull request #1222 from cli/api-pagination
Add `api --paginate` option
2020-06-23 19:01:16 +02:00
Mislav Marohnić
c945fb4336 Automatically add per_page=100 to paginated REST requests
Most endpoints respect this parameter by default. Those that don't will
just ignore it. The `per_page=100` parameter is not added if there is
already a `per_page` parameter specified in the request.
2020-06-23 18:42:57 +02:00
Corey Johnson
6d70f31b66
Merge pull request #994 from AliabbasMerchant/fix-incorrect-docs
Fix incorrect docs in Issue&PR create
2020-06-23 09:38:08 -04:00
Mislav Marohnić
ac7d5ecc44 Ensure markdown still passed through Glamour in no-color mode 2020-06-22 19:44:16 +02:00
Mislav Marohnić
e084a4563f Fix pr checkout OWNER:BRANCH when maintainer can modify
We did not use to request the necessary GraphQL fields to determine
whether the PR in question can be modified by maintainers (i.e. pushed
back to).
2020-06-22 19:36:55 +02:00
Mislav Marohnić
04b18ea8cb 🔥 unused var 2020-06-22 19:32:06 +02:00
Mislav Marohnić
55be0d2a9c Tweak isColorEnabled 2020-06-22 19:18:18 +02:00
Mislav Marohnić
53738c8803
Merge pull request #1249 from HowJMay/trunk
fix typo
2020-06-22 13:57:07 +02:00
HowJMay
2fc4c000b5 fix typo 2020-06-22 15:19:50 +08:00
Mislav Marohnić
caa9b20eaf
Merge pull request #1243 from AliabbasMerchant/fix1219
Fix pr create not using .github/pull_request_template.md
2020-06-18 17:12:06 +02:00
AliabbasMerchant
ae695e98ce Fix pr create not using .github/pull_request_template.md 2020-06-18 09:00:56 +05:30
Nate Smith
70c98a6a4e
Merge pull request #1192 from cli/triage-triage-triage
Add notes to triage doc
2020-06-17 13:07:59 -05:00
vilmibm
ab5cc6ae67 mention future label 2020-06-17 12:25:50 -05:00
Nate Smith
717f1da1e8
Merge pull request #1221 from cli/mislav/help-flag
The ultimate help/arguments handler
2020-06-17 11:20:58 -05:00
Mislav Marohnić
f4ecd365a6 api command: add GraphQL support for --paginate 2020-06-17 18:02:20 +02:00
Mislav Marohnić
3f940c98f1 Add assertion for 1st api request before pagination 2020-06-16 18:19:39 +02:00
Mislav Marohnić
7907def880 api command: add support for REST pagination 2020-06-16 18:16:49 +02:00
Mislav Marohnić
4662abb312 Merge remote-tracking branch 'origin' into fix-incorrect-docs 2020-06-16 17:08:10 +02:00
Mislav Marohnić
518f751f58 Merge remote-tracking branch 'origin' into mislav/help-flag 2020-06-16 16:54:47 +02:00
Mislav Marohnić
7b225bf1c9
Merge pull request #1147 from ShubhankarKG/issue_list
Added examples and custom error message for space separated issues
2020-06-16 16:53:02 +02:00
Mislav Marohnić
27cce8e3ca Apply the no-args handler to issue/pr status commands 2020-06-16 16:50:34 +02:00
Mislav Marohnić
3fea249d70 💅 tweak issue/pr create examples 2020-06-16 16:43:05 +02:00
Mislav Marohnić
f64e5f16eb Add special case for unsupported gh <command> help 2020-06-16 16:06:51 +02:00
Mislav Marohnić
311536433c The ultimate --help & spelling suggester handler
- short command usage output now lists subcommands instead of flags for
  parent commands

- mistyping a subcommand now results in a non-zero exit status

- requesting `--help` or `-h` for any command now prints help docs on
  stdout and exits with 0
2020-06-16 15:41:46 +02:00
Mislav Marohnić
ce59deb7b3 Show inherited flags in help output 2020-06-16 13:58:31 +02:00
Mislav Marohnić
9c75cff94b Show command usage output on invalid flags being passed 2020-06-16 13:58:01 +02:00
Mislav Marohnić
b838ac4014 Improve no args error handler and extend it to other commands 2020-06-15 21:01:32 +02:00
Mislav Marohnić
d583f8b5fa Merge remote-tracking branch 'origin' into issue_list 2020-06-15 20:30:34 +02:00
Corey Johnson
6aba8b314e Merge branch 'triage-triage-triage' of https://github.com/cli/cli into triage-triage-triage 2020-06-15 09:31:05 -07:00
Corey Johnson
1fbb2ba491 false 2020-06-15 09:30:28 -07:00
Corey Johnson
b27f371c5d Fixup 2020-06-15 09:30:09 -07:00
Corey Johnson
d60e7586ed Header two! 2020-06-15 09:30:03 -07:00
Corey Johnson
dab44547ee Make a list 2020-06-15 08:38:58 -07:00
Corey Johnson
ee19d10b95 Update update line 2020-06-15 08:29:23 -07:00
Corey Johnson
1178f20f3d
Update docs/triage.md
Thanks @aliabbasMerchant

Co-authored-by: Aliabbas Merchant <merchantaliabbas@gmail.com>
2020-06-15 08:27:44 -07:00
Mislav Marohnić
352999e971
Merge pull request #1211 from ShubhankarKG/package
Added description to nfpms
2020-06-15 15:37:34 +02:00
Eddú Meléndez Gonzales
c70756d596
Improve message when draft pr is created (#1202)
Fixes #1199

Co-authored-by: Mislav Marohnić <mislav@github.com>
2020-06-15 15:27:30 +02:00
ShubhankarKG
21a96baf93 Added description to nfpms 2020-06-15 17:45:04 +05:30
Mislav Marohnić
aabf34d092
Merge pull request #1204 from ObliviousParadigm/doc_fixes
DOC: Changed few sentences
2020-06-15 11:06:06 +02:00
ObliviousParadigm
5851ee26dd DOC: Changed few sentences
Moved code blocks to new lines to maintain consistency
2020-06-15 01:03:27 +05:30
AliabbasMerchant
84f3d46338 Better example section in issue and pr create 2020-06-14 21:53:56 +05:30
Corey Johnson
4388ff1a91 spelling mistakes 2020-06-12 14:42:32 -07:00
Corey Johnson
1105902935 Add more notes to triage doc 2020-06-12 14:40:03 -07:00
gabgodBB
e6e8f701a2 Issue #930 - Removing color for output files 2020-06-12 14:26:38 -03:00
Nate Smith
54e0534b1b
Merge pull request #1177 from cli/simplifycompositelit
Remove redundant type declarations for composite struct literals
2020-06-12 10:56:06 -05:00