Parth Patel
c714ed6fdf
added api tests
2021-10-08 22:02:59 -04:00
Parth
c894587761
added function tests
2021-10-08 21:02:40 -04:00
Parth
3001afda77
full lint fix
2021-10-08 17:38:56 -04:00
Parth Patel
28bfd8e773
lint fix
2021-10-08 17:21:03 -04:00
Parth Patel
b9c60e8dc8
remove go.mod change
2021-10-08 17:18:15 -04:00
Parth Patel
2ff8732836
minor fix
2021-10-08 17:05:36 -04:00
Parth Patel
e6e8d72428
added full functionality
2021-10-08 17:03:37 -04:00
Parth Patel
7725116428
works
2021-10-08 15:37:01 -04:00
Parth
1b4abd67a9
added api
2021-10-08 15:06:43 -04:00
Parth Patel
f249518361
error handling
2021-10-07 11:39:26 -04:00
Parth Patel
8f3911bb30
added unfinished api call
2021-10-07 11:36:58 -04:00
Parth Patel
5ff7ae89b6
added more stuff
2021-10-07 10:59:08 -04:00
Parth Patel
2d6c1e21d7
added a bunch of stuff
2021-10-06 14:09:45 -04:00
Jose Garcia
cd1eec5e38
Merge pull request #4448 from cli/jg/codeowners
...
Add codeowners
2021-10-06 13:55:56 -04:00
Jose Garcia
6f978dd8a4
Merge pull request #4440 from cli/jg/choose-codespace-prompt
...
codespace: choose codespace prompt improvements
2021-10-06 13:55:45 -04:00
Jose Garcia
b44474c32b
Revert rename for ports cmd
2021-10-06 13:47:20 -04:00
Jose Garcia
bdc9ad30e7
Revert other rename changes
2021-10-06 13:46:04 -04:00
Jose Garcia
811d841fae
Merge branch 'trunk' of github.com:cli/cli into jg/choose-codespace-prompt
2021-10-06 13:40:01 -04:00
Gabriel Ramírez
3d0d95ce2b
Merge pull request #4439 from geramirez/geramirez/codespaces-pagination
...
Adding pagination to list codespaces
2021-10-06 12:38:50 -05:00
Jose Garcia
771ac714ac
Update docs
2021-10-06 11:47:18 -04:00
Jose Garcia
a509c2d884
Remove unused guid
2021-10-06 11:45:43 -04:00
Jose Garcia
3a28643630
Keep codespace struct in API for now
...
- Use a private codespace structure in the cmd pkg to encapsulate common
behavior
2021-10-06 11:44:26 -04:00
Gabriel Ramírez
20ae9d305d
Fetch 100 codespaces by default
2021-10-06 14:53:55 +00:00
Jose Garcia
073200a275
Add codeowners
2021-10-06 10:19:17 -04:00
Gabriel Ramírez
e29a0ac7c4
Merge branch 'geramirez/codespaces-pagination' of https://github.com/geramirez/cli into geramirez/codespaces-pagination
2021-10-06 14:18:57 +00:00
Gabriel Ramírez
34f9c0a67c
Updating docs and interation exit condition to not check the final page
2021-10-06 14:18:44 +00:00
Gabriel Ramírez
237fdd40c8
Update internal/codespaces/api/api.go
...
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-10-06 09:03:49 -05:00
Jose Garcia
017632d63d
Merge branch 'trunk' of github.com:cli/cli into jg/choose-codespace-prompt
2021-10-06 09:57:39 -04:00
Jose Garcia
52e16dfe09
Merge pull request #4446 from cli/jg/get-codespace-api
...
codespace: switch `API.GetCodespace` to new API endpoint
2021-10-06 09:41:01 -04:00
Jose Garcia
b2ff4c321a
Remove unused structs
2021-10-06 09:25:39 -04:00
Jose Garcia
7c497f283b
Update test signature
2021-10-06 09:15:07 -04:00
Jose Garcia
8bb55359b1
Update mock API
2021-10-06 09:10:00 -04:00
Jose Garcia
8135fdbd99
Switch GetCodespace to new API endpoint
...
- Drop GetCodespaceToken as it is no longer necessary
- Introduces new behavior with the API to optionally include connection
details in the GET request. Ommitting to do so results in a faster
response
2021-10-06 08:50:42 -04:00
Gabriel Ramírez
aa49a3a557
Adding a second condition just in case
2021-10-05 21:43:28 +00:00
Gabriel Ramírez
61b0fe36b2
Adding additional tests for mid-flight deletions and additions
2021-10-05 21:31:47 +00:00
Gabriel Ramírez
02145cc4fd
Updated PR with suggestions
...
- created a new method to avoid defer pileup issue
- removed extra api call at the end of the sequence
2021-10-05 21:15:24 +00:00
Gabriel Ramírez
c6dc50983d
Update internal/codespaces/api/api.go
...
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-10-05 15:33:22 -05:00
Gabriel Ramírez
4314f734e3
Update internal/codespaces/api/api.go
...
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-10-05 15:33:16 -05:00
Gabriel Ramírez
e793a5961d
Add strconv
2021-10-05 19:00:21 +00:00
Gabriel Ramírez
fd5894d28d
Merge remote-tracking branch 'upstream/trunk' into geramirez/codespaces-pagination
2021-10-05 18:58:23 +00:00
Gabriel Ramírez
409cd9c388
Fixing Has() issue due to go version
2021-10-05 18:49:41 +00:00
Jose Garcia
7fe8357d40
Better short name
2021-10-05 13:30:17 -04:00
Jose Garcia
1971292175
Fixes bug there are +2 codespaces with a conflict
...
- Tracks conflicting name going forward for other records
- Moves the git status dirty star into a constant so we can reference it
2021-10-05 13:24:47 -04:00
Jose Garcia
a8d1718f21
Merge branch 'trunk' of github.com:cli/cli into jg/choose-codespace-prompt
2021-10-05 12:57:11 -04:00
Gabriel Ramírez
777978644c
Adding pagination to list codespaces
2021-10-05 16:49:40 +00:00
Jose Garcia
616d6c2db1
Merge pull request #4431 from cli/jg/get-skus-public
...
codespace machine: switch `API.GetCodespacesMachines` to use new API
2021-10-05 12:44:38 -04:00
Jose Garcia
975bd7c08a
Change choose codespace prompt
...
- Repo + branch is favored
- Codespace name is included to disambiguate between two codespaces
- Move Codespace model out of out API into its own package
- Update call sites and group behavior under codespace.Codespace
2021-10-05 11:23:12 -04:00
Jose Garcia
3652307cf3
Merge pull request #4429 from cli/jg/start-codespace-public
...
codespace create: update `API.StartCodespace` to use new API endpoint
2021-10-05 09:20:33 -04:00
Jose Garcia
a2e6df18e7
Merge pull request #4432 from cli/jg/rename-pkg
...
codespace: rename the cmd pkg to codespace
2021-10-05 08:23:36 -04:00
Jose Garcia
50d8f1e09a
Merge pull request #4409 from cli/jg/delete-codespace-public
...
codespace delete: update DeleteCodespaces to new API endpoint
2021-10-05 08:20:53 -04:00
