Commit graph

195 commits

Author SHA1 Message Date
Alan Donovan
cbbfafee98 Merge branch 'main' of https://github.com/github/ghcs 2021-09-08 18:04:56 -04:00
Alan Donovan
3a46f2ac56 add --lightstep flag for tracing 2021-09-08 17:15:42 -04:00
Jose Garcia
6b0510f81a Merge pull request #125 from github/jg/revert-errgroup
ghcs ssh/logs: revert errgroup usage
2021-09-08 15:17:11 -04:00
Jose Garcia
d8138c08b8 revert errgroup usage for ssh and logs 2021-09-08 14:56:16 -04:00
Jose Garcia
466ad8572c Merge pull request #122 from github/jg/go-liveshare-0.13.0
upgrade to go-liveshare 0.13.0
2021-09-08 14:32:35 -04:00
Jose Garcia
5569cc56c6 Merge pull request #120 from github/jg/output-logger
output pkg: new Errorln method and add comments
2021-09-08 13:34:14 -04:00
Jose Garcia
fda40a9682 new Errorln method and add comments 2021-09-08 10:29:30 -04:00
Alan Donovan
07300aeb38 Merge pull request #119 from github/silence-errors
ghcs: don't double-print errors
2021-09-07 07:12:57 -04:00
Alan Donovan
d395dae3a8 don't double-print errors 2021-09-06 15:17:24 -04:00
Alan Donovan
dd5fe49420 Merge pull request #114 from github/listen-race
Update to go-liveshare@v0.12.0
2021-09-06 14:56:20 -04:00
Alan Donovan
9e81dc7fde fix missing error return 2021-09-03 12:56:47 -04:00
Alan Donovan
2c660fa2e5 avoid ListenTCP helper 2021-09-03 12:55:40 -04:00
Alan Donovan
43198b24aa use errgroup 2021-09-03 12:50:11 -04:00
Alan Donovan
a56a84947a Update ghcs for go-liveshare@v0.12.0 2021-09-03 10:11:29 -04:00
Alan Donovan
88146a16a0 Merge pull request #110 from github/join-session
Update to go-liveshare v0.11.0
2021-09-02 17:26:01 -04:00
Alan Donovan
786a631995 fix local/remote confusion in getPorts (!) 2021-09-02 17:21:24 -04:00
Alan Donovan
981b2545bc sketch of changes for https://github.com/github/go-liveshare/pull/13 2021-09-02 17:08:17 -04:00
Alan Donovan
1162c8adff fix go vet loopclosure finding 2021-09-02 16:02:09 -04:00
Alan Donovan
4e2c20606a Merge branch 'main' into join-session 2021-09-02 15:57:34 -04:00
Alan Donovan
cee761238b update go-liveshare@v0.11.0 2021-09-02 15:54:00 -04:00
Alan Donovan
3485bacc97 fix StartSharing data race 2021-09-02 15:53:56 -04:00
Jose Garcia
ab47e97540 Merge pull request #112 from github/jg/start-errs
api start: ignore any 7 err code in start
2021-09-02 14:14:41 -04:00
Jose Garcia
090af2290b pr feedback 2021-09-02 14:13:40 -04:00
Jose Garcia
5c65cfd249 ignore any 7 err code in start 2021-09-02 13:42:52 -04:00
Jose Garcia
881e6d5940 Merge pull request #111 from github/jg/remove-dir
ghcs ssh: remove dir command
2021-09-02 13:33:53 -04:00
Jose Garcia
c15d810d68 remove extra verb arg 2021-09-02 13:27:12 -04:00
Alan Donovan
8570f4111d sketch after API changes in go-liveshare#11 2021-09-02 12:38:27 -04:00
Alan Donovan
65c19a3317 Merge pull request #107 from github/spelling-again
use correct correct spelling of codespace
2021-09-02 11:38:25 -04:00
Alan Donovan
45f9ae76f4 Merge pull request #108 from github/update-liveshare
Update go-liveshare to v0.10.0
2021-09-02 09:48:28 -04:00
Alan Donovan
c31fc05746 more typo fixes 2021-09-02 09:09:05 -04:00
Alan Donovan
72a2099a50 fix breakage from API changes 2021-09-01 17:50:24 -04:00
Alan Donovan
49ccdd3d21 use correct correct spelling of codespace 2021-09-01 17:26:26 -04:00
Jose Garcia
ef8dde4d2e Merge pull request #106 from github/jg/sku-params
ghcs create: pass branch for sku selection, pre-select if only one is returned
2021-09-01 16:43:02 -04:00
Jose Garcia
bfeb4e77c9 remove dir command 2021-09-01 14:38:37 -04:00
Jose Garcia
2163aba3d5 pass branch for sku selection, pre-select if only one is returned 2021-09-01 13:54:45 -04:00
Alan Donovan
c0fbb7e9fb Merge pull request #99 from github/runcommand
preparatory cleanups to ssh tunnel/port forwarding code
2021-08-31 17:30:00 -04:00
Alan Donovan
3aad0bbeb4 check context error in PollPostCreateStates 2021-08-31 17:27:53 -04:00
Alan Donovan
37b2f5e979 Merge branch 'main' into runcommand 2021-08-31 17:18:52 -04:00
Alan Donovan
4a45feb7f0 Merge pull request #101 from github/fix-80
Suppress display of usage message after errors
2021-08-31 16:35:49 -04:00
Alan Donovan
6a527941bf suppress display of usage message after errors 2021-08-31 16:35:28 -04:00
Alan Donovan
5238f249f3 Merge pull request #105 from github/product-spelling
spell product names (Codespace, Live Share) correctly in UI
2021-08-31 16:24:47 -04:00
Alan Donovan
f1c3a22a0b Merge branch 'main' into product-spelling 2021-08-31 16:24:41 -04:00
Alan Donovan
68792d5aa5 Merge branch 'main' into runcommand 2021-08-31 16:19:37 -04:00
Edmundo Gonzalez
d6f52ae557 Merge pull request #91 from github/edgonmsft/codespaces-ssh-rpc
Implement RPC interface so that the codespaces agent starts and configures ssh in the codespace
2021-08-31 13:05:56 -07:00
Jose Garcia
ebb04d1753 format code 2021-08-31 19:52:32 +00:00
Jose Garcia
535d832f8a small tweak 2021-08-31 15:50:04 -04:00
Alan Donovan
c0aae52289 move port choice, and PortForwarder.Start call, into clients 2021-08-31 13:58:46 -04:00
Alan Donovan
509e037a5e address review comments 2021-08-31 12:02:29 -04:00
Alan Donovan
bbcf2dd321 spell product names (Codespaces, Live Share) correctly 2021-08-31 11:15:26 -04:00
Alan Donovan
fee4b484ea Merge pull request #102 from github/fix-12
remove sleep 1s in ssh subcommand
2021-08-31 09:20:35 -04:00