Commit graph

402 commits

Author SHA1 Message Date
Mislav Marohnić
cc7b2f0ea8 Consistently use "pull request" instead of "PR" in user-facing copy 2019-12-11 09:31:57 +01:00
Corey Johnson
5949ca4b56 Merge pull request #142 from github/empty-pr-list
Add empty state for `gh pr list`
2019-12-10 12:04:41 -08:00
Corey Johnson
71add1baf5 Merge pull request #130 from github/rm-obsolete-fixtures
Cleanup: remove unused fixture files
2019-12-09 09:10:51 -08:00
Corey Johnson
4de0a76234 Merge pull request #141 from github/add-url-branch-to-usage
Add better usage docs for `gh pr view` `gh pr checkout` `gh issue view`
2019-12-06 14:39:43 -08:00
Corey Johnson
e9cbf8f3ba Merge pull request #143 from github/newlines-are-the-devils-whitespace
Don't display newlines in pr and issue lists
2019-12-06 14:34:56 -08:00
Corey Johnson
eb414bf2a1 Add a little test 2019-12-06 14:33:04 -08:00
Corey Johnson
f70473c234 Replace excessive whitespace 2019-12-06 14:32:55 -08:00
Corey Johnson
00b38bb11c Add better message to empty gh issue list 2019-12-06 14:10:01 -08:00
Corey Johnson
9aa3f35f8a Better language in the "no pr" state 2019-12-06 13:33:57 -08:00
Corey Johnson
387b9d9544 better name? 2019-12-06 13:33:23 -08:00
Corey Johnson
f1eb29b791 Add colorableErr 2019-12-06 13:32:36 -08:00
Mislav Marohnić
5f90cdc801 Elaborate on what is accepted as issue/PR arguments 2019-12-06 18:01:36 +01:00
Mislav Marohnić
4b8921f011 Consistently use {} to denote mutually exclusive options 2019-12-06 18:01:14 +01:00
Mislav Marohnić
8222e7d74f Consistently use <> to denote placeholders 2019-12-06 17:59:36 +01:00
Corey Johnson
bbb91d6a2a Replace newlines 2019-12-05 14:12:12 -08:00
Corey Johnson
fee303699a Show message when there are no PRs 2019-12-05 12:01:05 -08:00
Corey Johnson
196cdddb5e Merge pull request #140 from github/wtf-finder
Don't open PRs in the finder
2019-12-05 11:42:06 -08:00
Corey Johnson
cce2fd4a22 Add better usage docs 2019-12-05 11:40:36 -08:00
Corey Johnson
50fccd796a not needed 2019-12-05 09:58:45 -08:00
Corey Johnson
ee7f6339ae Return url for PRs 2019-12-05 09:54:30 -08:00
Mislav Marohnić
9425d33b3d Merge pull request #127 from github/help-site
Generate help docs to GitHub Pages
2019-12-05 18:37:46 +01:00
Corey Johnson
7c1390d02d Merge pull request #131 from github/move-config-to-folder
Move config to a directory
2019-12-04 15:53:34 -08:00
Corey Johnson
ae68acb901 Move to context package 2019-12-04 15:39:25 -08:00
Mislav Marohnić
5c4a94e13a Merge pull request #132 from github/pr-create--web
Add `gh pr create --web` to open a PR using web flow
2019-12-04 22:31:57 +01:00
Mislav Marohnić
551f365bfc Merge pull request #129 from github/pr-arg-selector
Support issue/PR URLs & PR branch names passed as arguments
2019-12-04 22:03:07 +01:00
Corey Johnson
418da8713b Merge pull request #128 from github/add-feedback
Add google form link to root help description
2019-12-04 10:48:33 -08:00
Corey Johnson
07993058e6 Update go.mod 2019-12-04 10:47:44 -08:00
Corey Johnson
51a65c64c3 Merge pull request #99 from github/upgrade-gh-reminder
Add alert text for users to update gh
2019-12-04 10:11:50 -08:00
Corey Johnson
b6adf7f4b1 Merge branch 'master' into upgrade-gh-reminder 2019-12-04 09:55:23 -08:00
Mislav Marohnić
fb8a7e26e6 Reset bool flags so they don't leak between tests 2019-12-04 16:47:11 +01:00
Mislav Marohnić
5ac4b1e6d6 Implement pr create --web 2019-12-04 16:26:40 +01:00
Mislav Marohnić
5d644d2468 Silence stderr in git push during pr create but show it on failures 2019-12-04 16:16:10 +01:00
Mislav Marohnić
87a1490d1e Improvements to update notifier authentication
- Check for updates even if `~/.config/gh` does not exist. In this case,
  the API call is unauthenticated.

- Avoid having the update notifier ever triggering the OAuth flow.
2019-12-04 15:41:08 +01:00
Mislav Marohnić
aaad263a3e Update output of upgrade available notice
- Individual components are now colored
- We don't say "Release notes" anymore since the URL doesn't contain
  any release notes yet
2019-12-04 15:14:48 +01:00
Mislav Marohnić
ba0a441e23 Allow configuring the update notifier from the outside
To test the update notifier:

    rm -f bin/gh; GH_VERSION=v0.2.3 LDFLAGS='-X main.updaterEnabled=github/homebrew-gh' make
2019-12-04 15:07:10 +01:00
Mislav Marohnić
67f0cf3ce3 Improvements to update notifier
- Only report an update available if the version number of the release
  is greater than the current version

- Removes `command` dependency from `update` package; instead, pass
  current version as an argument

- Remove `brew upgrade` instructions since we can't be certain that gh
  was installed via Homebrew in the first place.

- Does not check for updates unless stderr is a tty

- Preserve stderr color output even if stdout is not a tty

- Fixes stderr color output on Windows
2019-12-04 14:47:27 +01:00
Corey Johnson
14561cba9f Don't print an error if file doesn't exist 2019-12-03 16:44:37 -08:00
Corey Johnson
40d45da12d more documentation 2019-12-03 16:38:13 -08:00
Corey Johnson
afaab6d16c Add a config migration function 2019-12-03 16:36:45 -08:00
Corey Johnson
4b9cca3129 Change where the config file is located 2019-12-03 16:36:35 -08:00
Mislav Marohnić
b50e485019 🔥 unused fixture files 2019-12-03 22:02:55 +01:00
Mislav Marohnić
b125c08c37 🔥 obsolete fixture file 2019-12-03 22:01:50 +01:00
Mislav Marohnić
4e859fa7ca Validate PR passed as pr view <url> before opening it 2019-12-03 21:45:28 +01:00
Mislav Marohnić
b223176b37 Accept issue URL in issue view <issue>
Also validates that the issue passed either by number or by URL exists.
2019-12-03 21:41:22 +01:00
Mislav Marohnić
29de133ccf Accept PR URL or branch argument in pr checkout <pr> 2019-12-03 21:19:09 +01:00
Corey Johnson
fb7ea2c6a6 Don't use env vars! 2019-12-03 12:16:29 -08:00
Mislav Marohnić
519e731038 Allow specifying PR URL or branch name for pr view <pr> 2019-12-03 20:52:36 +01:00
Mislav Marohnić
5bfcab8ba1 Merge pull request #124 from github/pr-list-assignee
Support `-a, --assignee` in `pr list`
2019-12-03 20:06:35 +01:00
Mislav Marohnić
f87680e804 Explain multiple code paths 2019-12-03 19:52:45 +01:00
Mislav Marohnić
db7874add5 go fmt 2019-12-03 17:26:34 +01:00