Commit graph

2473 commits

Author SHA1 Message Date
Mislav Marohnić
cd2adfeba0 Port listing gists to githubv4 GraphQL client
- Fetching more than 100 gists is now supported
- The GraphQL query name is now `GistList` instead of `ListGists` for
  consistency with other queries
- Avoid fetching unnecessary Files fields
- Gists are now rendered in the order that the API returned them in
- The gist timestamp for machine-readable output is now rendered in
  RFC3339 format instead of in `time.Time.String()` format which is only
  meant for debugging and is not considered stable
- Ensure newlines in gist description are rendered as spaces
2020-10-05 20:33:31 +02:00
Mislav Marohnić
1859728f7e Fix parsing gist list --public/--secret flags
It's not sufficient to use `Changed("public")` to test if a boolean flag
was activated, since the user might have passed `--public=false`.
Instead, check the true value of the flag.

The `--public` and `--secret` flags should be mutually exclusive, so now
if both are activated, `--secret` takes precedence.
2020-10-05 20:27:05 +02:00
Matthew Gleich
f124370154
♻️ Refactor to only pass time in once for test
Signed-off-by: Matthew Gleich <email@mattglei.ch>
2020-10-04 15:02:13 -04:00
Matthew Gleich
d8ef8b836e
🐛 Fix stubs
Signed-off-by: Matthew Gleich <email@mattglei.ch>
2020-10-04 01:57:36 -04:00
Matthew Gleich
89e1ee3217
♻️ Refactor gist list to use graphQL
Signed-off-by: Matthew Gleich <matthewgleich@gmail.com>
2020-09-17 16:27:23 -04:00
Billy Griffin
458aace100
Merge pull request #1719 from cli/were-no-strangers-to-hub
Update comparison with hub as of 1.0
2020-09-17 07:02:42 -06:00
Billy Griffin
3632961376
Update comparison with hub as of 1.0 2020-09-17 06:56:48 -06:00
Mislav Marohnić
d822b064e3
Merge pull request #1716 from sohnryang/patch-1
Add sudo to pacman install command
2020-09-17 11:59:37 +02:00
Mislav Marohnić
fd5ef8fdd1
Merge pull request #1717 from droideck/fix-dnf-update
Fix dnf update command
2020-09-17 11:41:50 +02:00
Simon Pichugin
329adacc77 Fix dnf update command 2020-09-17 11:32:10 +02:00
Ryang Sohn
8053a62159
Add sudo to pacman install command
`pacman -S` requires sudo just like other package managers.
2020-09-17 14:51:47 +09:00
Nate Smith
38ee249891
Merge pull request #1710 from cli/pager-docs
Document `gh config set pager ...` option
2020-09-16 16:42:03 -05:00
Nate Smith
9657a74cea
Merge pull request #1713 from cli/debians
support more debians
2020-09-16 16:41:40 -05:00
vilmibm
f46ebf9cea support more debians 2020-09-16 12:47:16 -05:00
Mislav Marohnić
ae86361c25 Document gh config set pager ... option 2020-09-16 19:11:07 +02:00
Amanda Pinsker
51d6bcb4f1
Merge pull request #1638 from cli/readme-updates
Update README.md
2020-09-16 13:08:32 -04:00
Amanda Pinsker
2570f13768
Merge branch 'trunk' into readme-updates 2020-09-16 13:02:56 -04:00
Mislav Marohnić
b2e36a0979
Merge pull request #1706 from cli/base-resolve
Improve repository base and head resolution
2020-09-16 18:53:21 +02:00
Nate Smith
bdadb3058b
Merge pull request #1699 from cli/more-gists
bunch of gist stuff
2020-09-16 11:36:54 -05:00
vilmibm
7c986c0454 help typo 2020-09-16 11:23:14 -05:00
Mislav Marohnić
6d0da077b6
Merge pull request #1631 from cli/color-env
Add support for CLICOLOR standard
2020-09-16 18:20:13 +02:00
Mislav Marohnić
cd32ef8389
Merge pull request #1708 from cli/wsl-detection
Fallback browser when `xdg-open` does not exist
2020-09-16 18:16:27 +02:00
vilmibm
2b70e8266a better time stub 2020-09-16 10:57:20 -05:00
Mislav Marohnić
b2de27c624 Fix Survey's presentation of default values
For default values for e.g. `Input` prompts, Survey uses the literal "white" color, which makes no sense on dark terminals and is literally invisible on light backgrounds.

This overrides Survey to output a gray color for 256-color terminals and "default" for basic terminals.
2020-09-16 17:57:13 +02:00
Mislav Marohnić
88aacc14f0 Fix gray color presentation across terminals
We used to send the ANSI sequence for "bright black" when we wanted gray, but this color turns out to not be visible in some popular color schemes.

Instead, when we detect a 256-color terminal, switch to displaying a color sequence for gray that is consistent and does not depend on terminal color scheme.
2020-09-16 17:57:13 +02:00
Sam Coe
9058feebec
Fix up structure for better testing 2020-09-16 17:19:11 +02:00
Sam Coe
fd1d09dfc2
Clean up linux logic to have better default logic 2020-09-16 16:56:47 +02:00
Mislav Marohnić
086d8ed29a Merge remote-tracking branch 'origin' into color-env 2020-09-16 16:51:38 +02:00
Mislav Marohnić
3049db646f
Merge pull request #1630 from cli/pager-for-everyone
Extend PAGER support to all commands producing significant output
2020-09-16 16:22:58 +02:00
Mislav Marohnić
fa2513dea6 Document PAGER environment variable 2020-09-16 16:15:57 +02:00
Mislav Marohnić
f6dd1bcd0a Add the pager config option 2020-09-16 16:15:37 +02:00
Mislav Marohnić
c643778701 Have only one test assert default config rendering 2020-09-16 16:10:53 +02:00
Sam Coe
7551139caf
Address PR comments 2020-09-16 16:04:58 +02:00
Mislav Marohnić
00ac966c65 Merge remote-tracking branch 'origin' into pager-for-everyone 2020-09-16 15:58:54 +02:00
Mislav Marohnić
5a2c7e7957
Merge pull request #1707 from cli/fix-zsh-autocomplete
Remove square brackets from persistent flag description to fix zsh autocomplete
2020-09-16 15:53:41 +02:00
Sam Coe
dd1c24a20a
Use LookPath to determine if xdg-open exists 2020-09-16 15:52:34 +02:00
Mislav Marohnić
f99a55438f Remove issue create examples from pr create 2020-09-16 15:48:13 +02:00
Mislav Marohnić
f9239661f2 Reuse the StubRepoInfoReponse test helper 2020-09-16 15:01:13 +02:00
Mislav Marohnić
7a8db80420 Prompt for push target during pr create
We no longer guess the head repository using heuristics; instead, we
present the user with the choice of pushable repositories and an
additional option to create a new fork.

The new `pr create --head` flag is available for the user to specify the
head branch in `branch` or `owner:branch` format and completely skip any
forking or auto-pushing checks.
2020-09-16 14:49:36 +02:00
Sam Coe
6d111b2458
Use WSL2 detection to pick browser 2020-09-16 14:45:06 +02:00
Sam Coe
3f3c781ab6
Remove square brackets from persistent flag description to fix zsh autocomplete 2020-09-16 11:47:15 +02:00
vilmibm
0d45dd82f3 finish edit tests 2020-09-15 17:29:54 -05:00
vilmibm
15cf786c5a wip tests 2020-09-15 17:20:36 -05:00
vilmibm
a9ab2a98fc move Edit to opts for testing 2020-09-15 17:04:43 -05:00
vilmibm
62f54f0f02 start on edit tests 2020-09-15 16:18:26 -05:00
vilmibm
ada2c56606 test gist view 2020-09-15 16:05:30 -05:00
vilmibm
4a467864d5 linter appeasement 2020-09-15 15:22:28 -05:00
vilmibm
f124b426fe tweak gist view; support --filename 2020-09-15 14:56:13 -05:00
vilmibm
a61c897e4c show filename if no description 2020-09-15 14:55:55 -05:00
vilmibm
ba5b639be4 finish list tests 2020-09-15 14:33:14 -05:00