Commit graph

4640 commits

Author SHA1 Message Date
Jose Garcia
d02876e6ea Rename the cmd pkg to codespace 2021-10-04 14:16:04 -04:00
Jose Garcia
93cea6d370
Merge pull request #4408 from cli/jg/create-codespace-public
codespace create: update startCreate to use new API endpoint
2021-10-01 12:55:44 -04:00
Jose Garcia
86a4706ed2 Update startCreate to use new API endpoint
- Updates the signature of startCreate
- Can't update API.CreateCodespace just yet until we support expanded
  access on the GET codespace endpoint which is used for polling
2021-10-01 11:29:16 -04:00
Jose Garcia
68e54a5904
Merge pull request #4407 from cli/jg/list-codespaces-public
codespace list: update ListCodespaces to use new API endpoint
2021-10-01 11:28:37 -04:00
Mislav Marohnić
cb6db95ec6
Merge pull request #4403 from cli/cs-concurrent-requests
Don't allow the lazyLoadedHTTPClient mutex to wrap `Do()`
2021-10-01 17:26:04 +02:00
Jose Garcia
05297b8c8d Update ListCodespaces to use new API endpoint
- Removes the need for a User to list codespaces which should result in
  a slight speed improvement.
2021-10-01 10:37:15 -04:00
Mislav Marohnić
77e8b16b27
Merge pull request #4405 from cli/bump-survey
Bump Survey to fix "Unexpected escape sequence"
2021-10-01 14:20:37 +02:00
Mislav Marohnić
6249bee148 Bump Survey to fix "Unexpected escape sequence"
https://github.com/AlecAivazis/survey/pull/367
2021-10-01 14:14:55 +02:00
Mislav Marohnić
a723813064 Don't allow the lazyLoadedHTTPClient mutex to wrap Do()
We only need a mutex around accessing `l.httpClient`, but never around
the actual HTTP request.
2021-10-01 11:18:15 +02:00
Jose Garcia
be22cabe0b
Merge pull request #4395 from cli/jg/move-ghcs-cmd
pkg/cmd/codespace: move `cmd/ghcs` to `pkg/cmd/codespace`
2021-09-30 12:49:50 -04:00
Jose Garcia
0859de0124 Merge branch 'trunk' of github.com:cli/cli into jg/move-ghcs-cmd 2021-09-30 12:38:41 -04:00
Jose Garcia
ab27d1b5e1
Merge pull request #4394 from cli/jg/move-codespace-api
codespace api: move `internal/api` to `internal/codespaces/api`
2021-09-30 12:02:14 -04:00
Jose Garcia
94953ed3fc Merge branch 'trunk' of github.com:cli/cli into jg/move-codespace-api 2021-09-30 11:52:22 -04:00
Jose Garcia
4e9c443adf
Merge pull request #4393 from cli/jg/move-liveshare
liveshare: move location from `internal/liveshare` to `pkg/liveshare`
2021-09-30 11:50:07 -04:00
Jose Garcia
9e6c11e767 Move cmd/ghcs to pkg/cmd/codespace
- Delete pkg/cmd/codespace/main as it is no longer needed in this
  codebase
2021-09-30 11:20:13 -04:00
Jose Garcia
23d41ddb0d Format files 2021-09-30 11:09:59 -04:00
Jose Garcia
b5bbb442fd Move internal/api to internal/codespaces/api 2021-09-30 11:06:43 -04:00
Jose Garcia
53e4149c91 Update tests 2021-09-30 10:42:03 -04:00
Jose Garcia
f4a5f82312 Move internal/liveshare to pkg/liveshare 2021-09-30 10:34:27 -04:00
Jose Garcia
877ad22da6
Merge pull request #4384 from cli/import-codespaces
Import codespaces
2021-09-30 09:44:29 -04:00
Jose Garcia
a1e72af1da
Merge pull request #4392 from cli/jg/validate-host-key
codespace: validate host public keys
2021-09-30 09:26:28 -04:00
Jose Garcia
2ce14f603f Update tests with mock public key and test case 2021-09-30 08:40:18 -04:00
Jose Garcia
5b5c3da393 Validate host public keys 2021-09-30 08:16:28 -04:00
Mislav Marohnić
c4ec0a65ba
Merge pull request #4363 from RasmusWL/patch-1
Also set `pushRemote` on `gh pr checkout` from fork
2021-09-30 12:01:47 +02:00
Nate Smith
af812e2bdc
Merge pull request #4373 from cli/ext-bin-upgrade
binary extensions list & upgrade
2021-09-29 16:03:05 -05:00
Jose Garcia
c3ce95ea1c Add mutex to guard httpClient 2021-09-29 16:45:51 -04:00
Mislav Marohnić
0d0152b0fa Have gh codespace inherit the correct API client 2021-09-29 21:21:16 +02:00
vilmibm
7efd06b87d rename function 2021-09-29 13:43:37 -05:00
vilmibm
a2e7eaf808 test update available for binary ext in list 2021-09-29 13:39:00 -05:00
Jose Garcia
9bc50f5ab8
Merge pull request #4379 from cli/import-codespaces-add-nacl
Switch to using cli/crypto & test fixes
2021-09-29 10:49:30 -04:00
Mislav Marohnić
48bac0abd2 Fix race in codespaces delete test 2021-09-29 16:40:40 +02:00
Jose Garcia
a0f11b6664 Handle concurrency in tests and logger
- Live Share tests
- Logger implementation for ghcs
2021-09-29 16:40:40 +02:00
Jose Garcia
0e98b30651 Remove internal crypto pkg in favor of fork 2021-09-29 16:40:31 +02:00
vilmibm
ef08712354 test list 2021-09-28 19:27:21 -05:00
vilmibm
3971df4f93 switch to stubBinaryExtension 2021-09-28 19:23:28 -05:00
vilmibm
392460b81e WIP switching to stubBinaryExtension 2021-09-28 15:45:49 -05:00
vilmibm
541ed3ba6f test Upgrade with binary exts 2021-09-28 15:33:11 -05:00
vilmibm
22c1778b9f TODOs 2021-09-28 15:04:45 -05:00
vilmibm
94778a9cb0 un-stupid the file mode 2021-09-28 15:04:39 -05:00
vilmibm
1fe49fa776 fix listing, cleanup 2021-09-28 13:07:01 -05:00
vilmibm
54ec5329c5 add ability to upgrade binary extensions 2021-09-28 13:03:00 -05:00
vilmibm
db5bbf799f use manager io in Upgrade 2021-09-28 13:03:00 -05:00
Mislav Marohnić
7673622830 Mount gh codespace command 2021-09-28 17:03:05 +02:00
Mislav Marohnić
f749590e87 Replace old "github/ghcs" import statements 2021-09-28 16:57:56 +02:00
Mislav Marohnić
e64607d07b Merge remote-tracking branch 'ghcs/main' into import-codespaces
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-09-28 16:46:27 +02:00
Mislav Marohnić
f947ef3448 Remove lightstep configuration
The `github.com/shirou/gopsutil` dependency of lightstep-tracer is
giving us trouble during building.

Ref. https://github.com/shirou/gopsutil/issues/976

Another build problem raises its head even after we upgrade gopsutil to
a version where the above bug is fixed.
2021-09-28 16:42:35 +02:00
Mislav Marohnić
0483765da5 Merge pull request #190 from github/app-struct
Introduce an App struct that executes core business logic
2021-09-28 15:46:57 +02:00
Alan Donovan
4015af0427 Merge pull request #192 from github/json-error
create: decode JSON error heuristically
2021-09-27 18:04:55 -04:00
Alan Donovan
57d9b1a9e1 create: decode JSON error heuristically 2021-09-27 14:51:52 -04:00
Nate Smith
425bc64859
Merge pull request #4090 from bchadwic/pr-checks
Revised pending and skipped symbols for pr checks / run commands
2021-09-27 09:25:21 -07:00