STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
402 commits 87 branches 0 tags 160 MiB
Commit graph

402 commits

This branch
This branch
All branches
Author SHA1 Message Date
Jose Garcia
d0c65e5490 Linter fixes 2021-09-23 11:36:27 -04:00
Jose Garcia
f4396e8f1a Inline go-liveshare with history 2021-09-23 11:28:04 -04:00
Jose Garcia
9ae7eb5869 Merge branch 'go-liveshare-download' into jg/inline-go-liveshare 2021-09-23 11:19:46 -04:00
Jose Garcia
6ca35d0e73 Moved files to liveshare dir 2021-09-23 11:18:49 -04:00
Jose Garcia
3e26a15342 Merge pull request #188 from github/jg/update-liveshare 
Update to go-liveshare v0.20.0
 2021-09-23 10:22:09 -04:00
Jose Garcia
f1c35ba9da Update docs 2021-09-23 10:21:01 -04:00
Jose Garcia
fb12f4108f Merge pull request #181 from github/jg/poll-on-async-creation 
ghcs create: poll for codespaces that are being retried by the server
 2021-09-23 10:10:57 -04:00
Jose Garcia
a3c900c3b9 Merge pull request #185 from github/jg/buffer-channels 
Add buffered to channels to avoid goroutine leak
 2021-09-23 10:07:56 -04:00
Jose Garcia
9654dc4bd3 Update to go-liveshare v0.20.0 2021-09-23 10:07:14 -04:00
Jose Garcia
186b90b12e Rename request type 2021-09-23 08:29:24 -04:00
Jose Garcia
13d7804a35 Remove API test, inline poller 2021-09-23 08:26:23 -04:00
Jose Garcia
4e0ac15fe0 Add buffer to channels to avoid goroutine leak 2021-09-22 15:10:47 -04:00
Jose Garcia
9a558bc58c Early return if polling is not required 
- Add context to errors in poller
 2021-09-22 15:03:12 -04:00
Jose Garcia
208f1721b5 Rename ProvisionCodespaceParams 2021-09-22 13:21:02 -04:00
Jose Garcia
70a2ea2e6a PR Feedback 
- Rename ProvisionCodespace -> CreateCodespace
- Rename createCodespace -> startCreate
- Additional docs/comments
- Simplify ProvisionCodespaceParams
 2021-09-22 13:19:26 -04:00
Jose Garcia
d2d21996bc Move ProvisionCodespace to API client 
- Make CreateCodespace private along with its errors
 2021-09-22 11:49:41 -04:00
Jose Garcia
8c5330d9e9 Rename error 2021-09-22 10:04:18 -04:00
Jose Garcia
2a0ea1617b Handle specific error for GetCodespaceToken 2021-09-22 09:40:45 -04:00
Jose Garcia
86717f14a1 Implement codespaces.Provision 
- Move polling logic into the Provision function
- Document the behavior expected of callers when an ErrCreateAsyncRetry
  is returned
 2021-09-22 09:09:09 -04:00
Alan Donovan
770151313f Merge pull request #22 from github/connect 
Merge NewClient and JoinWorkspace into Connect
 2021-09-22 08:55:26 -04:00
Jose Garcia
48e3473a95 PR Feedback 
- Bring context.Timeout into the poller
- Accept duration and interval
- Other tidy up
 2021-09-21 18:18:30 -04:00
Alan Donovan
f8a8713520 refactor Options API 2021-09-21 15:27:23 -04:00
Jose Garcia
861811baf0 Upgrade pkg name after merge 2021-09-21 14:02:05 -04:00
Jose Garcia
d5b03df406 Merge branch 'main' of github.com:github/ghcs into jg/poll-on-async-creation 2021-09-21 14:01:37 -04:00
Alan Donovan
b3b675d108 Merge NewClient and JoinWorkspace into Connect 2021-09-21 12:44:30 -04:00
Jose Garcia
323462ca5c Poll codespace on ErrCreateAsyncRetry error 
- Introduce tests for the poller
- Attempt to fetch codespace for 2 mins
 2021-09-21 12:37:11 -04:00
Mislav Marohnić
090e0c81a1 Merge pull request #171 from github/cli-migration 
Split out "main" package from "ghcs"
 2021-09-21 18:06:06 +02:00
Mislav Marohnić
683d847dd2 Merge remote-tracking branch 'origin' into cli-migration 2021-09-21 17:38:41 +02:00
Jose Garcia
8a53c4369e Merge pull request #179 from github/jg/close-session 
liveshare: close sessions
 2021-09-21 10:14:22 -04:00
Jose Garcia
e8e914c220 PR Feedback 
- Upgrade to go-liveshare v0.19.0
- Remove export helper method
- Use local implementation
 2021-09-21 10:05:48 -04:00
Alan Donovan
0f88081bfa Merge pull request #178 from github/check-authorized-keys 
ghcs ssh: check user has authorised SSH keys
 2021-09-21 10:03:45 -04:00
Alan Donovan
d3d1ce726d do logs too 2021-09-21 10:02:55 -04:00
Jose Garcia
0b68aaab7e Return error on 202 responses 
- Start implementing the retry/poll flow
 2021-09-21 09:59:16 -04:00
Jose Garcia
7765628033 Merge pull request #21 from github/jg/err-context 
Add error context to Session.Close
 2021-09-21 09:56:27 -04:00
Jose Garcia
5f6b3a5eee Add error context to Session.Close 2021-09-21 13:46:30 +00:00
Alan Donovan
f33d430500 Merge pull request #177 from github/delete-surplus-args 
delete: reject positional arguments
 2021-09-21 09:26:22 -04:00
Jose Garcia
a83b3c0816 Update to go-livesare v0.18.0 
- Only set err if closeErr is non-nil
 2021-09-21 08:46:32 -04:00
Jose Garcia
5e9382e8b4 Merge pull request #20 from github/jg/close-session-v2 
Close RPC conn only
 2021-09-21 07:54:04 -04:00
Jose Garcia
23f6d449e0 Close RPC conn only 
- Only close SSH if RPC fails. Closing RPC automatically closes the
  underlying stream which in this case is the SSH connection.
- I thought about closing the SSH conn instead of RPC, but there is a
  bit more cleanup that the RPC library needs to do.
 2021-09-20 21:16:54 +00:00
Jose Garcia
7f682f9c39 Close Live Share sessions 
- New helper method codespaces.CloseSession to be used using defer
- Upgrade to go-liveshare v0.17.0
 2021-09-20 16:56:57 -04:00
Jose Garcia
82d7733f43 Merge pull request #19 from github/jg/session-closer-tidy-up 
Allow clients to Close a Session, general tidy up
 2021-09-20 16:36:16 -04:00
Jose Garcia
40886479ae Close SSH even if RPC Close fails 2021-09-20 20:35:12 +00:00
Alan Donovan
dbb80d8b1e check for authorised SSH keys 2021-09-20 16:01:43 -04:00
Alan Donovan
9e08b7477d delete: reject position args 2021-09-20 13:40:45 -04:00
Jose Garcia
57d04dc5f0 Allow clients to Close a Session, general tidy up 
- Allow clients to call Close on a Session to clean up resources
- Switch to the %w verb for error wrapping
- Fix typo on Port struct after verifying the server does not have a
  typo
 2021-09-20 13:16:38 +00:00
Mislav Marohnić
836075215d Merge remote-tracking branch 'origin' into cli-migration 2021-09-20 13:59:32 +02:00
Jose Garcia
85f79ed8e8 Merge pull request #159 from github/jg/ssh-cmd-flags 
ghcs ssh: ssh flags and command support
 2021-09-20 07:43:16 -04:00
Jose Garcia
82c19729d3 Wrap -- with optional argument brackets 2021-09-17 15:17:38 -04:00
Jose Garcia
47c6a5fce8 Update usage 2021-09-17 15:13:09 -04:00
Jose Garcia
5890d6ad66 Switch if block logic, assert err string 2021-09-17 15:04:55 -04:00