Caleb Brose
d3d72dd820
Add test for hasUploadedPublicKeyForConfig
2022-08-02 21:37:02 +00:00
Caleb Brose
4053880776
Merge remote-tracking branch 'origin/trunk' into cmbrose/no-auto-key-if-uploaded
2022-08-02 20:58:15 +00:00
Caleb Brose
d3c07706a4
Merge branch 'cmbrose/no-auto-key-if-uploaded' of https://github.com/cli/cli into cmbrose/no-auto-key-if-uploaded
2022-08-02 20:57:55 +00:00
Caleb Brose
88b28c5228
Fix api mock
2022-08-02 20:57:52 +00:00
Nate Smith
b9c1605c41
Merge pull request #5974 from cli/ext-alias
...
ext alias
2022-08-02 17:51:40 +02:00
Mislav Marohnić
92b7a30540
Merge pull request #5994 from cli/parse-remotes
...
Fix parsing base repo out of outdated git remotes
2022-07-26 12:20:18 +02:00
Sam Coe
2cdb9d34d4
Use SkipDefaultHeaders option ( #5996 )
2022-07-26 07:15:50 +02:00
Mislav Marohnić
e7029616cb
Fix parsing base repo out of outdated git remotes
...
If any of the repositories named by git remotes could not be found via
API lookup, a "could not resolve to a Repository" error would be thrown,
but the goal of the base repo logic was to ignore NOT_FOUND errors.
2022-07-25 20:17:32 +02:00
Mislav Marohnić
96d64832c8
Merge pull request #5989 from cli/api-no-json-htmlescape
...
Avoid HTML-escaping `gh api` JSON output
2022-07-25 17:26:13 +02:00
Mislav Marohnić
f34fc61a9a
api: avoid HTML-escaping JSON output
...
json.Marshal does HTML-escaping by default, which is what we don't want since we're printing to the terminal instead of embedding this JSON into a HTML document.
2022-07-25 13:10:44 +02:00
vilmibm
a659676270
ext alias
2022-07-22 11:53:05 -05:00
Caleb Brose
c9290cbc2c
Merge remote-tracking branch 'origin/trunk' into cmbrose/no-auto-key-if-uploaded
2022-07-22 11:08:21 -05:00
Caleb Brose
c9ca2608e6
Invert check
2022-07-22 11:07:57 -05:00
Caleb Brose
414a74b5f5
Even better config support
2022-07-22 11:03:14 -05:00
Mislav Marohnić
02881b4783
Correctly determine run started/elapsed timestamps ( #5945 )
...
This switches `run list` and `run view` commands to measure how long ago did the run happen by using `run_started_at`, which is the timestamp of the latest run in a series, instead of `created_at`, which is the timestamp of the first run. This change also fixes accurate duration for in-progress runs.
2022-07-21 17:30:46 +02:00
Caleb Brose
2ca8f8b633
Merge pull request #5969 from jungaretti/jungaretti/disable-ssh-password
...
Remove misleading Codespaces ssh/copy password prompt
2022-07-20 14:33:07 -05:00
JP Ungaretti
ec9e50ff93
Always set PasswordAuthentication option
2022-07-19 16:55:14 -07:00
Caleb Brose
d421664d1f
reduce diff
2022-07-17 01:19:42 +00:00
Caleb Brose
6c9d1a9fd4
Switch to using -G instead
2022-07-17 01:09:05 +00:00
Caleb Brose
f313953642
Initial pass
2022-07-16 20:38:23 +00:00
Nate Smith
954689ea9f
Merge pull request #5681 from heaths/issue5679
...
Use alternate screen buffer for watching runs
2022-07-14 15:03:43 -07:00
Mislav Marohnić
25756aaf88
Merge pull request #5943 from cli/uncache-http-client
...
Remove accidental caching from `repo list` and other commands
2022-07-14 19:17:23 +02:00
Mislav Marohnić
c22a85e2b5
Remove accidental caching from repo list and other commands
...
Any gh command that has invoked NewCachedHTTPClient has also
inadvertently enabled caching for the original `http.Client` due to the
nature that NewCachedHTTPClient mutates the original argument passed.
2022-07-14 19:10:32 +02:00
Nate Smith
7b7929bb6b
Merge pull request #5939 from pxeger/5934
...
Strip whitespace when adding topics
2022-07-14 09:39:51 -05:00
Patrick Reader
0cf2600725
strip whitespace when adding topics
...
closes #5934
2022-07-14 13:17:40 +01:00
Sam Coe
9d70d62520
Set blank headers so they are not automatically resolved by go-gh ( #5935 )
2022-07-14 14:13:34 +02:00
Sam Coe
e5cf302ad8
Post go-gh integration cleanup ( #5933 )
2022-07-13 14:58:50 +02:00
vilmibm
1bcf97b914
Merge remote-tracking branch 'origin' into issue5679
2022-07-12 15:40:29 -05:00
Sam Coe
1e8cb9c1b2
Fix login flow ( #5928 )
2022-07-12 15:46:35 +02:00
Taylor Faubion
11b1059237
fix gh run download <run-id> not getting > 100 artifacts ( #5799 )
...
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-07-12 11:01:38 +00:00
Mislav Marohnić
dea1af1227
pr checks: avoid deduplicating same-named checks under different workflows ( #5919 )
2022-07-12 09:48:39 +00:00
Mislav Marohnić
1037917d67
Merge pull request #5916 from cli/fork-without-rename
...
repo fork: directly fork under the desired name
2022-07-12 11:37:59 +02:00
ffalor
821f8ba1d2
Add error message to pr close when missing args ( #5885 )
2022-07-11 15:30:12 +00:00
Mark Phelps
994fbebf0a
Merge pull request #5873 from cli/fix-codespace-pending-create-panic
2022-07-11 10:05:34 -04:00
Mislav Marohnić
0f67999d52
Merge pull request #5915 from cli/pr-status-headref
...
pr status: fix detecting PR for curent branch
2022-07-11 14:00:59 +02:00
Mislav Marohnić
5656296ade
repo fork: directly fork under the desired name
...
A new GitHub feature landed where the API client can specify the desired
name of the new fork. This avoids the necessity of subsequently having
to rename the forked repo after the fork operation has created one.
For backwards compatibility, the renaming logic is still here, but
activates only if the resulting repo name is not the desired name.
2022-07-11 13:54:58 +02:00
Mislav Marohnić
04485144ea
pr status: fix detecting PR for curent branch
2022-07-11 13:16:33 +02:00
dependabot[bot]
dd8ad5c5fa
Bump github.com/gabriel-vasile/mimetype from 1.4.0 to 1.4.1 ( #5903 )
...
Bumps [github.com/gabriel-vasile/mimetype](https://github.com/gabriel-vasile/mimetype ) from 1.4.0 to 1.4.1.
- [Release notes](https://github.com/gabriel-vasile/mimetype/releases )
- [Commits](https://github.com/gabriel-vasile/mimetype/compare/v1.4.0...v1.4.1 )
---
updated-dependencies:
- dependency-name: github.com/gabriel-vasile/mimetype
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-11 11:00:24 +02:00
Mislav Marohnić
24798b4ee0
Merge pull request #5910 from casswedson/typo-smash
...
chore: typo hunting ft. codespell
2022-07-11 09:18:14 +02:00
casswedson
00bc550dc6
chore: typo hunting ft. codespell
2022-07-09 21:41:09 -05:00
Mark Phelps
6014b31d03
Fix case where codespace created while in provisioning state causes panic
2022-07-01 13:08:44 -04:00
Caleb Brose
604adc57ef
Merge pull request #5859 from cli/cmbrose/fix-auto-key-path
...
Use `codespaces.auto` instead for the automatic ssh keys
2022-06-29 12:35:42 -05:00
cmbrose
b2fe329011
Close files to actually fix windows
2022-06-29 12:28:21 -05:00
Caleb Brose
4eac4fbf4c
Make a new dir per test to work around windows failures
2022-06-29 11:48:23 -05:00
Caleb Brose
b5348f661e
Handle case of partial name match
2022-06-29 11:36:27 -05:00
Caleb Brose
1aa457499d
Use Fatal instead to avoid nil-ref
2022-06-29 11:27:18 -05:00
Caleb Brose
fb4ad53dd0
Check MkdirAll error
2022-06-29 11:17:24 -05:00
Caleb Brose
1bae759d3e
Don't use strings.Replace
2022-06-29 11:10:50 -05:00
Caleb Brose
77ecd0a147
Rename public key first for edge cases
2022-06-29 10:56:31 -05:00
Caleb Brose
2ac379f689
Comment
2022-06-29 10:54:07 -05:00