Commit graph

3423 commits

Author SHA1 Message Date
Mislav Marohnić
d43720620e Tweak build scripts to enable cross-compiling
The main build script for this project is `script/build.go` which
implements Makefile-like building of the `gh` binary and associated man
pages. Our Makefile defers to the Go script.

However, when setting GOOS, GOARCH, and other environment variables to
modify the target for the resulting binary, these environment variables
would affect the execution of `build.go` as well, which was unintended.

This tweaks our Makefile to reset variables like GOOS and GOARCH when
building the `build.go` script itself, ensuring that the built script
runs on the same platform, and adds the ability to pass environment
variables as arguments to `go run script/build.go`. This allows the
following usage on platforms without `make`:

    go run script/build.go GOOS=linux

With this style of invocation, the GOOS setting does not actually affect
`go run` itself; just the `go build` that is executed in a child process.
2021-04-09 15:48:12 +02:00
Nate Smith
d78e215c19
Merge pull request #3368 from cli/display-all-the-logs
Display all run logs
2021-04-07 20:20:52 -05:00
Nate Smith
ed0ef6ad14
Merge branch 'trunk' into display-all-the-logs 2021-04-07 20:12:47 -05:00
Nate Smith
7f02141364
obsolete TODO 2021-04-07 19:55:57 -05:00
Nate Smith
c2375205f4
golf 2021-04-07 19:55:44 -05:00
Nate Smith
35c55fd72e
Merge pull request #3349 from cli/artifact-download
Add `run download` command for fetching workflow artifacts
2021-04-07 14:55:08 -05:00
vilmibm
878bdb8d50 add an example 2021-04-07 14:48:28 -05:00
vilmibm
9b5e92e64a make test windows friendly 2021-04-07 14:47:12 -05:00
Mislav Marohnić
026dc4657a Merge remote-tracking branch 'origin' into artifact-download 2021-04-07 20:26:31 +02:00
Mislav Marohnić
a449a1a6f7 Add tests for artifact rendering in run view 2021-04-07 20:26:12 +02:00
Mislav Marohnić
6ce12c07f6 Move Artifact to the "shared" package 2021-04-07 20:26:12 +02:00
Mislav Marohnić
0e94de1ce6 Address run download feedback
- With no arguments in TTY mode, prompt which artifacts to download
- Change `--pattern` argument to be just `--name` and only do exact
  matching
- For multi-archive downloads, prefix the destination path with the name
  of the artifact
- Add tests exercising HTTP functionality
- Avoid "zipslip" path injection when extracting ZIP files
- Add tests for ZIP extraction
2021-04-07 19:56:28 +02:00
Mislav Marohnić
a4a41c23e6 Have StringSet preserve original order of values 2021-04-07 19:55:09 +02:00
Nate Smith
b6277e7ce2
Merge pull request #3324 from cli/run-watch
gh run watch
2021-04-07 12:30:22 -05:00
vilmibm
65524f1ea8 review feedback 2021-04-07 12:19:47 -05:00
Sam Coe
5cb4ece754
Renaming and cleanup 2021-04-07 10:10:11 -07:00
Sam Coe
67e45f1bce
Display all run logs 2021-04-07 09:31:59 -07:00
vilmibm
c8e481e165 gh run watch 2021-04-06 20:27:09 -05:00
vilmibm
c8d1d6e8b4 sigh 2021-04-05 15:39:14 -05:00
vilmibm
97b15fea2d xplatform oops 2021-04-05 15:33:31 -05:00
vilmibm
b5fc794b78 support --log for runs 2021-04-05 15:23:21 -05:00
Nate Smith
b2e32a508d
Merge pull request #3330 from cli/man-gen-test
Add tests for manual pages generation
2021-04-05 14:21:44 -05:00
vilmibm
b705b3d6ba make ExitStatus reflect focused job 2021-04-05 14:11:06 -05:00
Nate Smith
20c58f1a0b
Merge pull request #3357 from cli/run-flags
support --web in gh run view
2021-04-05 13:41:00 -05:00
vilmibm
3f95e4595f tweak error text 2021-04-05 13:35:47 -05:00
Sam
211324d90e
Merge pull request #3337 from cli/workflow-view-2
Workflow view
2021-04-05 09:37:29 -07:00
vilmibm
1424e4a973 support --web when focusing a job 2021-04-04 21:33:27 -05:00
vilmibm
7fc9295786 support --web for run view 2021-04-04 21:27:20 -05:00
Mislav Marohnić
8552cacf79 Fix test after merge 2021-04-02 21:04:31 +02:00
Mislav Marohnić
9c4afca003 Merge remote-tracking branch 'origin' into artifact-download 2021-04-02 21:00:25 +02:00
Mislav Marohnić
b41681cbb7 Restore Go < 1.16 compatibility 2021-04-02 20:54:56 +02:00
Mislav Marohnić
51a0a27a6f Add ARTIFACTS information to run view 2021-04-02 20:52:41 +02:00
Mislav Marohnić
c54e3c9ca8 Add run download command for downloading workflow artifacts 2021-04-02 20:42:18 +02:00
Sam Coe
e15189f43e
Address PR comments 2021-04-02 10:16:09 -07:00
Sam Coe
d1b153c6dc
Yaml to YAML 2021-04-02 09:43:33 -07:00
Sam Coe
5566289d1c
workflow view 2021-04-02 09:36:57 -07:00
Nate Smith
216cfb631f
Merge pull request #3333 from cli/run-rerun
gh run rerun
2021-04-02 11:06:15 -05:00
Nate Smith
9fe7326d46
Merge pull request #3338 from cli/merge-job-run-view
absorb job view into run view
2021-04-02 11:00:48 -05:00
vilmibm
238a371477 no need to hide this 2021-04-02 10:58:33 -05:00
Sam
658004a6ef
Merge pull request #3347 from cli/hostname-override
Quick fix: respect default hostname when parsing `owner/repo` pairs
2021-04-02 08:56:28 -07:00
Sam Coe
ee687d7e7f
Add tests for quick fix 2021-04-02 08:42:19 -07:00
Sam
01b3f0f1cb
Merge pull request #3341 from cli/actions-help-section
Add section in help for actions commands
2021-04-02 08:34:35 -07:00
Mislav Marohnić
a35d451b67 Fix PR automation workflow
- Use AUTOMATION_TOKEN to get around "resource not available by
  integration". It looks like jobs triggered from community pull
  requests do not have permissions to write to our project.

- Tolerate the "project already has the associated issue" error for
  staff as non-fatal.
2021-04-02 15:31:22 +02:00
Mislav Marohnić
69ca2dda4a Quick fix: respect default hostname when parsing owner/repo pairs
This re-enables using GH_HOST to set a default hostname when
supplying repo argument like `gh repo clone owner/repo`.
2021-04-02 15:16:27 +02:00
Mislav Marohnić
815ae7a22d
Merge pull request #3334 from g14a/fix/nontty-fork
fix premature return while forking repo non interactively
2021-04-02 11:44:16 +02:00
Sam Coe
8b1ed28121
Add section in help for actions commands 2021-04-01 21:05:50 -07:00
vilmibm
8a60ea3c62 gh run rerun 2021-04-01 19:32:36 -05:00
vilmibm
1ddb33bf3c add GetRunsWithFilter 2021-04-01 19:32:36 -05:00
Gowtham Munukutla
19c95cf358 Merge branch 'trunk' of https://github.com/cli/cli into fix/nontty-fork 2021-04-01 10:49:22 +05:30
Gowtham Munukutla
5caf01c564 add test for non tty fork 2021-04-01 10:49:12 +05:30