Commit graph

451 commits

Author SHA1 Message Date
Mislav Marohnić
d5cb5574d0 💅 simplify generateCompareURL and test 2020-10-21 12:09:46 +00:00
Leonardo
d0bee19eaf Query escape branch names to allow branch/#123 names 2020-10-21 12:09:46 +00:00
Sam
becb316308
Merge pull request #2177 from jonathanlloyd/use-canonical-capitalization-in-remotes
Clone repos using canonical username/repo name capitalization
2020-10-20 09:23:21 +02:00
Sam
f8fd61cc6c
Merge pull request #2157 from rista404/print-auth-token-1514
Add ability to print auth token
2020-10-20 08:46:45 +02:00
Sam
5a8c0713c2
Merge pull request #2138 from cristiand391/validate-git-protocol-config
Validate git protocol config before setting it
2020-10-20 08:44:57 +02:00
Ryan Nystrom
f1ea9102c4
Merge pull request #2201 from cli/rn/login-scopes
Add --scopes to login
2020-10-16 18:43:21 -04:00
Mislav Marohnić
14a222bade Let the receiver choose how to format the cfg.Set() value error 2020-10-16 18:54:36 +00:00
Mislav Marohnić
7d317a81be
Merge pull request #1622 from ShubhankarKG/prMergeConfirmations
PR Merge confirmations
2020-10-16 20:17:54 +02:00
Ryan Nystrom
02883a89e3 add tests 2020-10-16 15:59:41 +00:00
Ryan Nystrom
93bc389269 Add scopes flag to login 2020-10-15 22:04:18 +00:00
Mislav Marohnić
813fbc9b8d Ensure that we don't reuse the same deserialization struct over pagination iterations
This is to avoid subtle deserialization issues in nested slices.
2020-10-14 15:38:21 +02:00
Jonathan Lloyd
8f44aee76a Load repo and parent in single query 2020-10-13 20:41:16 +01:00
Jonathan Lloyd
a5ec03d000 Improve test args 2020-10-12 23:57:47 +01:00
Jonathan Lloyd
487b62d3b9 Clone repos using canonical username/repo name capitalization
GitHub user/repo names are case insentitive. This can cause issues when dealing with
repos programmatically using systems that aren't aware of this (e.g. go packages).

This commit updates the cloning logic of the CLI to query the API for the canonical
capitalization and uses that for the clone operation.

Fixes: #1845
2020-10-12 23:39:18 +01:00
rista404
2bdfc10e0a
Add ability to print auth token 2020-10-11 12:55:34 +02:00
Mislav Marohnić
a2aa07d497
Merge pull request #2134 from ShubhankarKG/updates
Update shouldCheckForUpdate
2020-10-09 18:30:48 +02:00
Mislav Marohnić
ce8f37aca2 💅 tweak update notifier 2020-10-09 18:15:28 +02:00
ShubhankarKG
78b67fabdd 1. Added GH_NO_UPDATE_NOTIFIER to hhelp_topics
2. Updated test to check if passed variable is not empty
2020-10-08 21:22:26 +05:30
Pushpamk
581783176a deleted comment 2020-10-08 20:34:10 +05:30
Pushpamk
f8a49ca624 updated reference comment 2020-10-08 16:04:28 +05:30
Pushpamk
40a0b0d511 updated new github doc. link 2020-10-08 00:55:44 +05:30
Nate Smith
14a5e00c4a
Merge pull request #2034 from cristiand391/check-gist-ownership
Check gist ownership before editing
2020-10-05 16:20:34 -05:00
Nate Smith
d63b5a9297
Merge pull request #1763 from Matt-Gleich/trunk
♻️ Refactor gist list to use graphQL
2020-10-05 16:15:39 -05:00
Nate Smith
edec480b34
Merge pull request #2057 from cli/auth-scopes-doc
Specify minimum required token scopes in `gh help auth login`
2020-10-05 16:00:25 -05:00
Nate Smith
9869b874f8
Merge pull request #2072 from jmdejong/garden-resore-terminal
restore tty settings after gh repo garden
2020-10-05 15:34:18 -05:00
vilmibm
fa68a3a858 linter appeasement 2020-10-05 15:19:49 -05:00
Mislav Marohnić
cd2adfeba0 Port listing gists to githubv4 GraphQL client
- Fetching more than 100 gists is now supported
- The GraphQL query name is now `GistList` instead of `ListGists` for
  consistency with other queries
- Avoid fetching unnecessary Files fields
- Gists are now rendered in the order that the API returned them in
- The gist timestamp for machine-readable output is now rendered in
  RFC3339 format instead of in `time.Time.String()` format which is only
  meant for debugging and is not considered stable
- Ensure newlines in gist description are rendered as spaces
2020-10-05 20:33:31 +02:00
Mislav Marohnić
1859728f7e Fix parsing gist list --public/--secret flags
It's not sufficient to use `Changed("public")` to test if a boolean flag
was activated, since the user might have passed `--public=false`.
Instead, check the true value of the flag.

The `--public` and `--secret` flags should be mutually exclusive, so now
if both are activated, `--secret` takes precedence.
2020-10-05 20:27:05 +02:00
Dimitris Apostolou
6f550b5d12
Fix typos 2020-10-04 22:16:30 +03:00
Matthew Gleich
f124370154
♻️ Refactor to only pass time in once for test
Signed-off-by: Matthew Gleich <email@mattglei.ch>
2020-10-04 15:02:13 -04:00
Matthew Gleich
d8ef8b836e
🐛 Fix stubs
Signed-off-by: Matthew Gleich <email@mattglei.ch>
2020-10-04 01:57:36 -04:00
troido
974c6d8958 restore tty settings after gh repo garden
the command 'gh repo garden' used to leave the terminal in noecho mode when exiting

This restores the tty settings to their state before running 'gh repo garden'
2020-10-03 11:01:38 +02:00
Mislav Marohnić
49909b5123 Tweak gh auth login examples 2020-10-01 19:56:56 +02:00
Mislav Marohnić
cc2b86f3a6 Specify minimum required token scopes in gh help auth login 2020-10-01 19:56:33 +02:00
Cristian Dominguez
c6b9e8454f Update gist edit tests 2020-09-30 12:35:22 -03:00
Cristian Dominguez
67c0a1a409 Check gist ownership before editing 2020-09-30 12:35:04 -03:00
Harsh Shandilya
0107b00043
Don't override user provided title and body when --fill is used (#1994)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-30 16:15:30 +02:00
Sam Coe
74d6eb96be
Address PR comments 2020-09-30 12:55:05 +02:00
Sam Coe
bda27a46ae
Extract version command 2020-09-30 12:49:17 +02:00
Sam Coe
1a1a6303cd
Move disable auth check to bottom 2020-09-30 12:49:17 +02:00
Sam Coe
53a97c3414
Extract rootFlagErrrorFunc into root help 2020-09-30 12:49:17 +02:00
Sam Coe
f00a0f2854
Move completion command out of root package 2020-09-30 12:49:17 +02:00
Sam Coe
c52fc72291
Extract bareHTTPClient function 2020-09-30 12:49:14 +02:00
Teubel György
9b2fe1ee30 Disable pager when set to "cat" 2020-09-29 23:21:59 +02:00
Nate Smith
e24035681d
Merge pull request #2003 from cristiand391/refactor-gist-create
Refactor gist create to reuse existing structs
2020-09-29 15:27:31 -05:00
Nate Smith
127d0b8717
Merge pull request #2020 from tgyurci/gh-pager-env
Add support for GH_PAGER
2020-09-29 14:52:58 -05:00
Nate Smith
aa72881baa
Merge pull request #1962 from ricardoseriani/change-default-answer-after-delete-branch
Set default answer to "no" for "deleting branch after merge" question
2020-09-29 11:29:41 -05:00
Teubel György
b71261219c Add support for GH_PAGER 2020-09-29 17:42:25 +02:00
Nate Smith
3c6e355a1c
Merge pull request #1967 from aldahick/fix/repo-garden-few-commits
Fix some bugs in `repo garden` in repositories with few commits
2020-09-29 10:27:10 -05:00
Pranjal Mittal
3a9b9de940
Modification of help text for usage of gh pr checks (#1915) 2020-09-29 11:25:02 +02:00