Commit graph

2654 commits

Author SHA1 Message Date
Mislav Marohnić
d5cb5574d0 💅 simplify generateCompareURL and test 2020-10-21 12:09:46 +00:00
Leonardo
d0bee19eaf Query escape branch names to allow branch/#123 names 2020-10-21 12:09:46 +00:00
Sam
becb316308
Merge pull request #2177 from jonathanlloyd/use-canonical-capitalization-in-remotes
Clone repos using canonical username/repo name capitalization
2020-10-20 09:23:21 +02:00
Sam
869f5118c6
Merge pull request #2178 from quiye/milestone-int32-validation
Add int32 validation to milestone numbers
2020-10-20 09:17:22 +02:00
Sam
f8fd61cc6c
Merge pull request #2157 from rista404/print-auth-token-1514
Add ability to print auth token
2020-10-20 08:46:45 +02:00
Sam
5a8c0713c2
Merge pull request #2138 from cristiand391/validate-git-protocol-config
Validate git protocol config before setting it
2020-10-20 08:44:57 +02:00
Ryan Nystrom
f1ea9102c4
Merge pull request #2201 from cli/rn/login-scopes
Add --scopes to login
2020-10-16 18:43:21 -04:00
Mislav Marohnić
14a222bade Let the receiver choose how to format the cfg.Set() value error 2020-10-16 18:54:36 +00:00
Cristian Dominguez
09401b30b6 Validate git protocol config before setting it 2020-10-16 18:54:25 +00:00
Mislav Marohnić
7d317a81be
Merge pull request #1622 from ShubhankarKG/prMergeConfirmations
PR Merge confirmations
2020-10-16 20:17:54 +02:00
Ryan Nystrom
02883a89e3 add tests 2020-10-16 15:59:41 +00:00
Ryan Nystrom
93bc389269 Add scopes flag to login 2020-10-15 22:04:18 +00:00
Mislav Marohnić
02f494693c
Merge pull request #2190 from quiye/issues-data-race
Fix issue label overrides caused by pagination
2020-10-15 13:42:30 +02:00
Mislav Marohnić
e270cdb29e Simplify test to avoid use of reflect 2020-10-14 15:54:42 +02:00
Mislav Marohnić
813fbc9b8d Ensure that we don't reuse the same deserialization struct over pagination iterations
This is to avoid subtle deserialization issues in nested slices.
2020-10-14 15:38:21 +02:00
zamasu
a90b62fb6c Fix parsing labels in paginated IssueList 2020-10-14 15:32:45 +02:00
Mislav Marohnić
2565c9dc24
Merge pull request #2186 from cli/help-wanted-docs
Improve contributing documentation
2020-10-14 12:02:00 +02:00
Jonathan Lloyd
8f44aee76a Load repo and parent in single query 2020-10-13 20:41:16 +01:00
Mislav Marohnić
bd25dae5e0 Update triaging docs 2020-10-13 18:07:05 +02:00
Mislav Marohnić
d66fd2fe9e Remove needs-user-input from "please avoid"
The user input might have come in a reply already, but the maintainers
haven't gotten around to remove the stale label yet. This shouldn't
prevent someone from submitting a PR.
2020-10-13 18:06:00 +02:00
Mislav Marohnić
ef907463d9 Fix label links 2020-10-13 18:05:27 +02:00
Mislav Marohnić
b3f64acc55 Clarify contributions section 2020-10-13 17:44:13 +02:00
Mislav Marohnić
3d734a5e7e Merge remote-tracking branch 'origin' into help-wanted-docs 2020-10-13 17:43:12 +02:00
Mislav Marohnić
bb6a571ab5 Tweak contributing guidelines 2020-10-13 16:40:40 +02:00
Mislav Marohnić
f87b684447
Merge pull request #2156 from waldyrious/patch-2
Improve installation instructions in README
2020-10-13 13:24:00 +02:00
zamasu
d4e6fc11d7 Add int32 validation to milestone numbers 2020-10-13 08:36:47 +09:00
Jonathan Lloyd
a5ec03d000 Improve test args 2020-10-12 23:57:47 +01:00
Jonathan Lloyd
487b62d3b9 Clone repos using canonical username/repo name capitalization
GitHub user/repo names are case insentitive. This can cause issues when dealing with
repos programmatically using systems that aren't aware of this (e.g. go packages).

This commit updates the cloning logic of the CLI to query the API for the canonical
capitalization and uses that for the clone operation.

Fixes: #1845
2020-10-12 23:39:18 +01:00
Waldir Pimenta
10e1c5260c Suggested changes from PR review 2020-10-12 13:10:52 +01:00
Waldir Pimenta
d29fc16df9 Suggested changes from PR review 2020-10-12 11:57:43 +01:00
rista404
2bdfc10e0a
Add ability to print auth token 2020-10-11 12:55:34 +02:00
Waldir Pimenta
c38003d78b
Improve installation instructions
- Mention downloadable binaries for macOS and Linux
- Mention Homebrew for Linux
- Cleanup whitespace throughout the file
2020-10-11 10:57:04 +01:00
Mislav Marohnić
20f88bbd5a Update references to the help wanted label after rename
GitHub has some special behavior for the `help wanted` label, but not
the `help-wanted` label, so I've renamed ours.

Bonus: updated links to docs.github.com
2020-10-09 19:06:25 +02:00
Mislav Marohnić
a2aa07d497
Merge pull request #2134 from ShubhankarKG/updates
Update shouldCheckForUpdate
2020-10-09 18:30:48 +02:00
Mislav Marohnić
ce8f37aca2 💅 tweak update notifier 2020-10-09 18:15:28 +02:00
ShubhankarKG
78b67fabdd 1. Added GH_NO_UPDATE_NOTIFIER to hhelp_topics
2. Updated test to check if passed variable is not empty
2020-10-08 21:22:26 +05:30
Sam
338e03631c
Merge pull request #2132 from Pushpamk/documentation
updated new github doc. link
2020-10-08 17:21:35 +02:00
Pushpamk
581783176a deleted comment 2020-10-08 20:34:10 +05:30
Pushpamk
f8a49ca624 updated reference comment 2020-10-08 16:04:28 +05:30
ShubhankarKG
fa536990e6 revert accidentally committed config options 2020-10-08 12:19:17 +05:30
ShubhankarKG
3a22ab7eba Update shouldCheckForUpdate 2020-10-08 12:04:57 +05:30
Pushpamk
40a0b0d511 updated new github doc. link 2020-10-08 00:55:44 +05:30
Mislav Marohnić
0d593e78aa
Merge pull request #2056 from cli/scoop
Fix updating scoop bucket, homebrew-core formula on release
2020-10-06 15:04:06 +02:00
Mislav Marohnić
01bd0dce5e fix hub release download 2020-10-06 15:01:59 +02:00
Mislav Marohnić
38ef66a06f Improve release titles 2020-10-06 15:01:55 +02:00
Mislav Marohnić
2eab4a940f
Merge pull request #2025 from mmontes11/pr-create-use-git-branch-show-current
Avoding --short option in git symbolic-ref for getting the current branch
2020-10-06 14:31:34 +02:00
Mislav Marohnić
54e292703b
Merge pull request #2054 from cli/ghe-auth
Handle edge cases in GHE auth
2020-10-06 14:27:32 +02:00
Mislav Marohnić
115357c6af
Merge pull request #2035 from cli/ghe-2.20-compat
GHE 2.20 compatibility for `pr` commands
2020-10-06 12:50:08 +02:00
Nate Smith
14a5e00c4a
Merge pull request #2034 from cristiand391/check-gist-ownership
Check gist ownership before editing
2020-10-05 16:20:34 -05:00
Nate Smith
d63b5a9297
Merge pull request #1763 from Matt-Gleich/trunk
♻️ Refactor gist list to use graphQL
2020-10-05 16:15:39 -05:00