Mislav Marohnić
da2a732c6a
Merge pull request #2997 from g14a/feature/add-files-to-gist
...
Feature/add files to gist
2021-02-27 14:49:46 +01:00
Mislav Marohnić
8f96e406ac
Improve error handling and avoid writing confirmation to stdout
...
Right now the `gist edit` command doesn't write anything to stdout, so
let's keep it that way until we want to intentionally provide some
feedback in the terminal.
2021-02-27 12:23:18 +01:00
Mislav Marohnić
406d7eee45
💅 cleanup gist edit -a feature
2021-02-27 12:07:35 +01:00
Sam
a49654970c
Merge pull request #3024 from cli/normalize-pr-commands
...
Normalize pr command arguments
2021-02-26 10:31:06 -08:00
Mislav Marohnić
823514022d
Merge pull request #3036 from cli/pr-merge-no-commits
...
Avoid crash in `pr merge` when the pull request has no commits
2021-02-26 13:08:27 +01:00
Mislav Marohnić
492f45422e
Add a note about the style of git tests
2021-02-26 13:07:38 +01:00
Gowtham Munukutla
7fd0634a24
rebase with trunk
2021-02-25 14:47:26 +05:30
Mislav Marohnić
e4ce0d76aa
Merge pull request #3022 from ganboonhong/pr-edit-branch
...
Add `pr edit --base` to change the base branch of a PR
2021-02-24 15:57:50 +01:00
Mislav Marohnić
896f2273e8
Merge pull request #3021 from g14a/bug/gist-deletion
...
Accept only one argument when deleting a gist
2021-02-24 15:37:06 +01:00
Mislav Marohnić
d97e8fe172
Add live tests for some methods in the git package
...
We relied too much on stubs for these methods. These new tests actually
invoke `git` commands in the context of a test repository.
2021-02-24 15:05:56 +01:00
Mislav Marohnić
0f85304e3e
Avoid crash in pr merge when verifying whether a PR had diverged
...
A PR is not guaranteed to have commits, it seems, so add a guard against
assuming that there is always a head commit.
2021-02-24 14:37:29 +01:00
Gowtham Munukutla
66d4307bce
return msg instead of too many arguments
2021-02-24 18:05:11 +05:30
Gowtham Munukutla
79b77b4273
Merge branch 'trunk' of https://github.com/cli/cli into bug/gist-deletion
2021-02-24 15:54:29 +05:30
Gowtham Munukutla
61eb7eeeab
Add msg in gist delete
2021-02-24 15:53:07 +05:30
Gowtham Munukutla
56ead91702
Add helper function to validate exact args in cmdutil
2021-02-24 15:49:40 +05:30
Gowtham Munukutla
3e5d5a23c0
add fixturefile const in tests
2021-02-24 10:22:56 +05:30
Gowtham Munukutla
d4e14beb57
remove unwanted tests and unwanted functionality
2021-02-24 10:14:31 +05:30
Gowtham Munukutla
8f1c467001
Merge branch 'trunk' of https://github.com/cli/cli into feature/add-files-to-gist
2021-02-24 09:44:19 +05:30
Gowtham Munukutla
a6fa14866b
updating tests WIP
2021-02-24 09:44:11 +05:30
Sam Coe
34da59777b
Revert close and reopen changes
2021-02-23 13:24:48 -08:00
Mislav Marohnić
98df059e84
Merge pull request #3020 from cli/brew-upgrade-notice
...
Avoid upgrade notice for recent release if gh is under Homebrew prefix
2021-02-23 21:04:57 +01:00
Sam Coe
9d062ed8fc
Normalize pr command arguments
2021-02-23 09:17:35 -08:00
boonhong
732e919a83
Add pr edit --base to change the base branch of a PR
2021-02-24 00:15:04 +08:00
Mislav Marohnić
c5af4ddfdc
Merge pull request #3009 from cli/git-credential-env
...
Fix `auth git-credential` when the token comes from environment
2021-02-23 16:32:23 +01:00
Gowtham Munukutla
cbf8a0d964
Accept only one argument when deleting a gist
2021-02-23 20:12:26 +05:30
Gowtham Munukutla
a60a6d854b
Merge branch 'trunk' of https://github.com/cli/cli into feature/add-files-to-gist
2021-02-23 17:13:07 +05:30
Mislav Marohnić
27aea42d8a
Avoid upgrade notice for recent release if gh is under Homebrew prefix
...
Before, when gh detected there was a new release in the `cli/cli` repo,
it would show this notice:
A new release of gh is available: {V1} → {V2}
Additionally, when the release was more than 24h old, we would show this
to Homebrew users:
To upgrade, run: brew update && brew upgrade gh
Ref. feb4acc2c0
2021-02-23 12:24:51 +01:00
Mislav Marohnić
d6798b1852
Merge pull request #3019 from cli/ghe-paste-token
...
Fix pasting Personal Access Token to `auth login` for GHE
2021-02-23 11:34:02 +01:00
Mislav Marohnić
cfddda8829
Indicate workflow scope is GHE 3.0+ only during auth login
2021-02-23 10:52:29 +01:00
Mislav Marohnić
f807795491
Fix pasting Personal Access Token to auth login for GHE
2021-02-23 10:19:11 +01:00
Mislav Marohnić
9bf1668b3f
Fix auth git-credential when the token comes from environment
...
When a token such as GH_TOKEN is set through environment variables and
`~/.config/gh/hosts.yml` is non-existent, the `auth git-credential get`
command used to fail due to missing username.
Since GitHub username isn't at all required for token authentication,
use the `x-access-token` faux username instead of trying to obtain one
from a config file.
2021-02-19 15:37:11 +01:00
Gowtham Munukutla
faffc4de95
Add go fmt to pass ci/cd
2021-02-19 12:05:20 +05:30
Gowtham Munukutla
f56b38908e
Merge branch 'trunk' of https://github.com/cli/cli into feature/add-files-to-gist
2021-02-19 12:02:24 +05:30
Gowtham Munukutla
4ed10140ab
Resolved PR review comments and test cases
2021-02-19 12:02:17 +05:30
Mislav Marohnić
04dcb327ca
Merge pull request #2996 from cli/ghe-branchprotectionrule
...
Fix `pr status` for GHE 2.22 and older
2021-02-18 19:41:04 +01:00
Gowtham Munukutla
882bd1adb1
add go lint to pass checks
2021-02-18 22:39:56 +05:30
Mislav Marohnić
dcff6c4f2d
Fix pr status for GHE 2.22 and older
...
This queries for the availability of the `branchProtectionRule` field on
"Ref" before trying to request it from GraphQL.
2021-02-18 17:46:13 +01:00
Gowtham Munukutla
a4a194011f
gofmt
2021-02-18 19:18:49 +05:30
Gowtham Munukutla
9a4fd0d706
Remove unwanted prompt for user. Unwanted test as well
2021-02-18 19:17:42 +05:30
Gowtham Munukutla
d469f4b2cc
Merge branch 'trunk' of https://github.com/cli/cli into feature/add-files-to-gist
2021-02-18 18:46:40 +05:30
Gowtham Munukutla
bff8b3007a
Add test cases and improve errors with color schemes
2021-02-18 18:45:43 +05:30
Nate Smith
2f563babbf
Merge pull request #2990 from cli/ssh-key-commands
...
Add `ssh-key add` command and publish `ssh-key`
2021-02-17 14:30:37 -06:00
Mislav Marohnić
1a9e42ed55
Add ssh-key add command and publish ssh-key
2021-02-17 19:46:59 +01:00
Nate Smith
e91b97b4c5
fully restore fork remote renaming behavior ( #2982 )
...
* fully restore fork remote renaming behavior
* catch blank remote name and error + arg tests
* hard wrap fork usage
* do not rename if remote-name supplied
* tweak error text
2021-02-17 12:33:22 -06:00
Nate Smith
4a897f70c3
Merge pull request #2962 from ulwlu/fix_prompt_string_when_creating_remote_repository
...
Fix prompt string when creating remote repository
2021-02-17 12:32:27 -06:00
Mislav Marohnić
c148a9ba24
Merge pull request #2989 from cli/pr-merge-immediate-edit
...
pr merge: avoid prompting to enter editor after editing phase is chosen
2021-02-17 19:26:17 +01:00
Mislav Marohnić
a90997ec95
pr merge: avoid prompting to enter editor after editing phase is chosen
...
When user chooses "Edit commit message", open the editor immediately
instead of showing an additional prompt to open the editor.
2021-02-17 18:47:17 +01:00
Mislav Marohnić
70d4786e37
Merge pull request #2988 from cli/strict-status-checks-base
...
pr status: fix checking branch protection rules on the base branch
2021-02-17 18:13:15 +01:00
Mislav Marohnić
05421db404
pr status: fix checking branch protection rules on the base branch
...
Instead of checking branch protection rules on the main branch of the
repository, branch protection rules for a specific PR should be checked
on its base branch, since not all PRs are based on the main branch.
Additionally, do not display "Up to date" if the actual merge status
reported from the server was "UNKNOWN" or "DIRTY", since in those cases
"Up to date" could be false information.
2021-02-17 18:04:49 +01:00
Mislav Marohnić
3b117e6c3c
Merge pull request #2539 from divyaramanathan/issue-create-template
...
Implementing issue template GraphQL API call
2021-02-17 17:59:42 +01:00
