Commit graph

7527 commits

Author SHA1 Message Date
gabemontero
dd7ea5adff list the various alias permutations for the command and subcommands
this occurs from either utlizing the help function for a specific command/subcommand
combination or when 'gh reference' lists the command tree
2024-05-17 09:30:53 -04:00
William Martin
3b9f9a8f59
Merge pull request #9095 from cli/wm/rework-auth-tests-with-new-credential-abstractions
Rework first auth tests with new gitcredential abstractions
2024-05-17 15:26:49 +02:00
William Martin
a37253746e Remove TODO and add comment on LoginFlow tests 2024-05-17 14:51:02 +02:00
William Martin
3fe555b0bb Comment the purpose of the helper config contract 2024-05-17 14:33:19 +02:00
William Martin
540bda1a6b Test git credentials are configured in LoginFlow 2024-05-17 14:31:21 +02:00
William Martin
ba1afa2c5d Add HelperConfig contract test and FakeHelperConfig 2024-05-17 14:16:14 +02:00
William Martin
3ea937d903 Inject GitCredentialFlow to LoginFlow as test seam 2024-05-17 13:26:23 +02:00
Andy Feller
e14f0d79bd
Merge pull request #9079 from cli/pr_checks_json
feat: add json output for `gh pr checks`
2024-05-16 13:14:16 -04:00
William Martin
eb5dc7f298
Merge pull request #9089 from cli/wm/refactor-git-credential-code
Refactor git credential flow code
2024-05-16 18:48:18 +02:00
William Martin
3803fd04b9 Add Helper test for Windows 2024-05-16 17:01:41 +02:00
William Martin
64d50e6fbc Add tests for gitcredentials Updater 2024-05-16 15:37:18 +02:00
William Martin
37abb3ec96 Fix mistaken git installation error check 2024-05-16 14:38:51 +02:00
William Martin
e07a26d81c Move gitcredentials HelperConfig and add tests 2024-05-16 14:34:28 +02:00
William Martin
d75548a630 Comment the new gitcredentials package 2024-05-16 13:48:53 +02:00
William Martin
187c5016f0 Comment the git credential flow 2024-05-16 13:39:42 +02:00
William Martin
818d4ba5b8 Remove unnecessary credential setup private method 2024-05-16 13:39:42 +02:00
William Martin
c16836bcf7 Use tighter interface in setup-git 2024-05-16 13:39:42 +02:00
William Martin
177cf7d35b Rename gitcredentials Configure to ConfigureOurs 2024-05-16 13:15:26 +02:00
William Martin
bd4ba5c39a Make gitcredential helper smarter 2024-05-16 13:15:26 +02:00
William Martin
af589aa2f3 Move fetching configured helper into gitcredentials 2024-05-16 12:39:11 +02:00
William Martin
a3d65e0dce Extract units for configuring and updating git credential helpers 2024-05-16 12:32:55 +02:00
Andy Feller
ac5510362b Implement ExportData to filter json fields
In order to filter json fields, the `ExportData` interface needed to be implemented with logic that iterated on the selected fields.
2024-05-14 09:49:07 -04:00
nobe4
8a1995c98d
fix: rename fields list 2024-05-14 08:06:54 +02:00
nobe4
dabfb1ede8
Merge branch 'trunk' into pr_checks_json 2024-05-14 08:01:42 +02:00
nobe4
178fc2e51e
feat: add json output for PR checks 2024-05-14 07:57:38 +02:00
Andy Feller
4b077daf7e
Merge pull request #9075 from cli/dependabot/go_modules/github.com/sigstore/protobuf-specs-0.3.2
build(deps): bump github.com/sigstore/protobuf-specs from 0.3.1 to 0.3.2
2024-05-13 13:03:55 -04:00
dependabot[bot]
b918967bf5
build(deps): bump github.com/sigstore/protobuf-specs from 0.3.1 to 0.3.2
Bumps [github.com/sigstore/protobuf-specs](https://github.com/sigstore/protobuf-specs) from 0.3.1 to 0.3.2.
- [Release notes](https://github.com/sigstore/protobuf-specs/releases)
- [Changelog](https://github.com/sigstore/protobuf-specs/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sigstore/protobuf-specs/compare/v0.3.1...v0.3.2)

---
updated-dependencies:
- dependency-name: github.com/sigstore/protobuf-specs
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-13 14:53:11 +00:00
Andy Feller
af0288910c
Merge pull request #8987 from kuzdogan/patch-1
Add --latest=false to `gh release create` docs
2024-05-10 13:03:01 -04:00
William Martin
a47b96cc8b
Merge pull request #9063 from cli/9058-gh-repo-fork-no-longer-respects-the-git-protocol-of-the-original-repo-when-git_protocol-is-not-configured
Fix repo fork regression
2024-05-10 17:35:13 +02:00
Andy Feller
b8529f4e8e
Merge pull request #9066 from cli/andyfeller/codespace-edges-doc
Creating doc to capture Codespace usage guidance
2024-05-10 10:06:38 -04:00
William Martin
a9fa1407b6 Add further docs to Option type 2024-05-10 11:05:59 +02:00
William Martin
85e81a50da Comment further on config changes 2024-05-10 10:55:41 +02:00
William Martin
88631d13d4 Remove unnecessary config list variable 2024-05-10 10:49:07 +02:00
William Martin
bc5329e9db Fix mistaken find and replace for Option type 2024-05-10 10:48:45 +02:00
William Martin
07e0ff7127 Fix repo fork to use remote protocol if none configured 2024-05-10 10:48:36 +02:00
William Martin
d0e436b369 Avoid reconstructing config Options on each use 2024-05-10 10:48:24 +02:00
William Martin
8a4f32b4e2 Make config list less fallible 2024-05-10 10:48:17 +02:00
William Martin
8a82e3a856 Provide more type safety around config values 2024-05-10 10:48:11 +02:00
William Martin
1d38230675
Move config interfaces into gh package (#9060) 2024-05-10 10:39:36 +02:00
William Martin
2543c22463
Merge pull request #9068 from szepeviktor/typos
Fix typos
2024-05-10 07:37:34 +02:00
Viktor Szépe
6d9dd57774 Fix typos 2024-05-09 20:15:27 +00:00
Andy Feller
70acabc132 Creating doc to capture Codespace usage guidance 2024-05-09 08:27:58 -04:00
Andy Feller
f11f096695
Merge pull request #8934 from babakks/8588-improve-run-list-doc
Improve `run list` doc with available `--json` fields
2024-05-08 17:01:16 -04:00
Meredith Lancaster
c9e8fd6c64
Fix attestation verify source repository check bug (#9053)
* add build source repo URI extension when repo is provided, add integration tests for this change

Signed-off-by: Meredith Lancaster <malancas@github.com>

* add initial docs on specifying cert identity

Signed-off-by: Meredith Lancaster <malancas@github.com>

* wording

Signed-off-by: Meredith Lancaster <malancas@github.com>

* add reusable workflow example

Signed-off-by: Meredith Lancaster <malancas@github.com>

* add more test cases

Signed-off-by: Meredith Lancaster <malancas@github.com>

* tweak to verify docs

---------

Signed-off-by: Meredith Lancaster <malancas@github.com>
Co-authored-by: Phill MV <phillmv@github.com>
2024-05-08 07:44:52 -06:00
William Martin
08e8ee6746
Merge pull request #9059 from cli/wm/fix-unused-params
Fix unused params across project
2024-05-08 11:43:46 +02:00
William Martin
5007c18f5f Fix unused params across project 2024-05-07 17:50:43 +02:00
Babak K. Shandiz
4ac966f030
Fix test function name
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-06 18:35:54 +01:00
Babak K. Shandiz
05a87b9664
Add test to verify JSON fields section is rendered in Markdown
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-06 18:01:12 +01:00
Babak K. Shandiz
ad71f8cf9f
Output JSON Fields section in Markdown
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-06 18:00:54 +01:00
Babak K. Shandiz
5b99a4a2ec
Add test to verify JSON fields section is rendered
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2024-05-06 17:57:50 +01:00